Skip to content

Security: defense-in-depth audit findings (2 items) #28

Description

@somethingwithproof

Defense-in-Depth Audit

An automated security audit identified 2 defense-in-depth opportunities in plugin_cycle.

Breakdown

XSS(1), CSRF(1)

Recommended fixes

  • SQLi: Convert string-concatenated SQL to db_execute_prepared() / db_fetch_*_prepared()
  • XSS: Wrap get_request_var() in HTML contexts with html_escape_request_var()
  • CMD: Verify exec()/shell_exec() args use cacti_escapeshellarg()
  • Path: Add realpath() + prefix validation for include/require with variable paths
  • Deser: Add array('allowed_classes' => false) to unserialize() calls
  • CSRF: Verify forms integrate with Cacti CSRF framework

All recommended changes are PHP 7.0+ compatible.

Related PR: #27

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions