fix(mactrack): address Copilot review on site_scan --web flag and error surfacing

Make --web conditional on $web param in mactrack_site_scan (was always added).
Append subprocess exit-code errors to data['content'] so the AJAX client
shows failures rather than an empty dialog.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

lib/mactrack_functions.php

@@ -3145,7 +3145,8 @@ function mactrack_rescan($web = false) {
 			$data['content'] = ob_get_clean();
 
 			if ($exit_code !== 0) {
-				$data['error'] = 'rescan process exited with code ' . intval($exit_code);
+				$data['error']    = 'rescan process exited with code ' . intval($exit_code);
+				$data['content'] .= '<p class="textError">' . html_escape('Subprocess error: exit code ' . intval($exit_code)) . '</p>';
 			}
 		}
 	}
@@ -3175,7 +3176,7 @@ function mactrack_site_scan($web = false) {
 
 		// create the command script
 		$command_string = $config['base_path'] . '/plugins/mactrack/poller_mactrack.php';
-		$extra_args     = ' --web -sid=' . cacti_escapeshellarg($dbinfo['site_id']);
+		$extra_args     = ' -sid=' . cacti_escapeshellarg($dbinfo['site_id']) . ($web ? ' --web' : '');
 
 		// print out the type, and device_id
 		$data['site_id'] = $site_id;
@@ -3190,7 +3191,8 @@ function mactrack_site_scan($web = false) {
 		$data['content'] = ob_get_clean();
 
 		if ($exit_code !== 0) {
-			$data['error'] = 'site_scan process exited with code ' . intval($exit_code);
+			$data['error']    = 'site_scan process exited with code ' . intval($exit_code);
+			$data['content'] .= '<p class="textError">' . html_escape('Subprocess error: exit code ' . intval($exit_code)) . '</p>';
 		}
 	}