From f051b51269b5abc5165c76c198fec5f7cdb11c57 Mon Sep 17 00:00:00 2001 From: Peter Feerick <5500713+pfeerick@users.noreply.github.com> Date: Tue, 4 Aug 2026 11:30:13 +1000 Subject: [PATCH] fix(ci): sync issue template tags/categories in script-submission.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The push job in validate-issue-templates.yml was supposed to self-heal bot-created branches, but script-submission.yml's branch-creating push uses the default GITHUB_TOKEN, and GitHub Actions suppresses new workflow- triggering events (including push) for GITHUB_TOKEN-authored pushes — the same rule that prevents the sync job's own corrective commits from causing an infinite loop also silently prevented it from ever running in the first place for these branches. Confirmed against two real submissions (#67, #68): both landed with a permanently-failing check and no auto-fix. Rather than fight the retrigger suppression, run the sync script directly in script-submission.yml before committing, so the schema/templates are already correct in the very first commit of every bot-generated PR. The push job in validate-issue-templates.yml remains as a backstop for genuine human-authored pushes (e.g. direct-edit PRs), which aren't subject to this suppression. Also fixes a stale error-comment string referencing the category enum check that was removed in #65. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/script-submission.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/script-submission.yml b/.github/workflows/script-submission.yml index e41240b..0660ac9 100644 --- a/.github/workflows/script-submission.yml +++ b/.github/workflows/script-submission.yml @@ -49,6 +49,9 @@ jobs: - name: Validate scripts.json run: uv run tools/validate_scripts.py --scripts-json scripts.json + - name: Sync issue template tags/categories + run: uv run tools/sync_issue_template_options.py --write + - name: Configure git identity run: | git config user.name "github-actions[bot]" @@ -63,7 +66,9 @@ jobs: run: | BRANCH="add-script/${ISSUE_NUMBER}" git checkout -b "$BRANCH" - git add scripts.json + git add scripts.json scripts.schema.json \ + .github/ISSUE_TEMPLATE/add-script.yml \ + .github/ISSUE_TEMPLATE/update-script.yml VERB="Add" if [ "$MODE" = "patch" ]; then VERB="Update"; fi git commit -m "feat(scripts): ${VERB} script from issue #${ISSUE_NUMBER} @@ -133,7 +138,7 @@ jobs: "- A script with this name already exists in `scripts.json` (insert mode)", "- The script name was not found in `scripts.json` (update mode)", "- A required field was left blank", - "- The selected Category does not match a known value", + "- No Category was selected and no New Category was provided", "- The Info URL is missing or does not start with `http://` or `https://`", "", "Please check the [workflow run](" +