Remove code that stoped parents from being selected. (#4949)

Fixes #4945

Author: frjo

hypha/apply/funds/forms.py

@@ -23,7 +23,7 @@
 from .models.co_applicants import CoApplicantProjectPermission, CoApplicantRole
 from .permissions import can_change_external_reviewers
 from .utils import model_form_initial, render_icon
-from .widgets import MetaTermWidget, MultiCheckboxesWidget
+from .widgets import MultiCheckboxesWidget
 
 
 class ApplicationSubmissionModelForm(forms.ModelForm):
@@ -382,19 +382,11 @@ def __init__(self, *args, choices_groupby, **kwargs):
         self.iterator = partial(GroupedModelChoiceIterator, groupby=choices_groupby)
         super().__init__(*args, **kwargs)
 
-    def label_from_instance(self, obj):
-        return {
-            "label": super().label_from_instance(obj),
-            "disabled": not obj.is_leaf(),
-        }
-
 
 class UpdateMetaTermsForm(ApplicationSubmissionModelForm):
     meta_terms = GroupedModelMultipleChoiceField(
         queryset=None,  # updated in init method
-        widget=MetaTermWidget(
-            attrs={"data-placeholder": _("Select..."), "data-js-choices": ""}
-        ),
+        widget=MultiCheckboxesWidget(attrs={"data-placeholder": _("Select...")}),
         label=_("Tags"),
         choices_groupby="get_parent",
         required=False,

hypha/apply/funds/widgets.py

@@ -13,21 +13,3 @@ def __init__(self, *args, **kwargs):
         attrs.setdefault("data-placeholder", "")
         kwargs["attrs"] = attrs
         super().__init__(*args, **kwargs)
-
-
-class MetaTermWidget(forms.SelectMultiple):
-    def create_option(
-        self, name, value, label, selected, index, subindex=None, attrs=None
-    ):
-        disabled = False
-
-        if isinstance(label, dict):
-            label, disabled = label.get("label"), label.get("disabled")
-
-        option_dict = super().create_option(
-            name, value, label, selected, index, subindex=subindex, attrs=attrs
-        )
-
-        if disabled:
-            option_dict["attrs"]["disabled"] = "disabled"
-        return option_dict