Add Ready for Review state.

Author: frjo

docs/references/workflows.md

@@ -128,7 +128,8 @@ Funding organization wants an advisory board or external partners to give their
 Once an application is submitted (`INITIAL_STATE`) — it can transition into the following:
 
 - A request for more information (`ext_int_more_info`) — opens editing permissions to applicant again to revise their application to provide the information requested by the screeners.
-- Open external review (`ext_int_external_review`) — can transition only between closing the review period (`ext_int_post_external_review_discussion`) and reverting back to the internal screening phase.
+- Ready for review (`ext_int_ready_for_review`) — a staff only holding phase between screening and the external review, where reviewers can be assigned before they are given access to the application. Can transition to opening the external review (`ext_int_external_review`), mark ready for determination (`ext_int_determination`), dismiss (`ext_int_rejected`) or revert back to screening (`INITIAL_STATE`). Reviewers can see the application in this phase but can not review it yet.
+- Open external review (`ext_int_external_review`) — can transition only between closing the review period (`ext_int_post_external_review_discussion`) and reverting back to ready for review (`ext_int_ready_for_review`).
   - `ext_int_post_external_review_discussion` — after the external review is closed, you can request more information (`ext_int_post_external_review_more_info`), open the internal review (`ext_int_internal_review`), mark ready for determination (`ext_int_determination`), revert back to opening the external review (`ext_int_external_review`), accept (`ext_int_accepted`), waitlist (`ext_int_waitlisted`) or dismiss (`ext_int_rejected`)
   - `ext_int_post_external_review_more_info` — opens editing permissions to applicant again to revise their application to provide the information requested by the external reviewers.
 - Open internal review (`ext_int_internal_review`) — can transition only between closing the review period (`ext_int_post_review_discussion`) and reverting back to discussion (`ext_int_post_external_review_discussion`)
@@ -137,13 +138,14 @@ Once an application is submitted (`INITIAL_STATE`) — it can transition into th
 - Ready for determination (`ext_int_determination`) — can revert back to discussion (“Ready for Discussion (revert)” — `ext_int_post_review_discussion`), accept (`ext_int_accepted`), waitlist (`ext_int_waitlisted`) or dismiss (`ext_int_rejected`)
 - Waitlisted (`ext_int_waitlisted`) — the application is kept in play without a decision. Can transition to accept (`ext_int_accepted`), dismiss (`ext_int_rejected`), or revert back to ready for determination (`ext_int_determination`). Staff can still edit this submission. Waitlisting is a plain status change — unlike Accept and Dismiss it does not open the determination form and does not create a determination record.
 - Accepted (`ext_int_accepted`) — application accepted. Staff can still edit this submission.
-- Dismissed (`ext_int_rejected`) — application rejected. Editing and reviewing permissions removed from all roles, the applicant can still view the submission.
+- Dismissed (`ext_int_rejected`) — application rejected, shown as "Not Accepted" to the applicant. Editing and reviewing permissions removed from all roles, the applicant can still view the submission.
 
 There is no "Accepted but additional info required" state in this workflow.
 
 If the `TRANSITION_AFTER_REVIEWS` setting is set to a number, submitting a review can move the application on automatically:
 
-- Need screening → External Review, as soon as the first review is submitted. The configured number is not taken into account for this step, and only staff can review during screening.
+- Need screening → Ready for Review, as soon as the first review is submitted. The configured number is not taken into account for this step, and only staff can review during screening.
+- Ready for Review → External Review, once that many reviews have been submitted in total. Only staff can review in this phase.
 - External Review → Ready for Discussion, once that many reviews have been submitted by users in the Reviewer group.
 - Internal Review → Ready for Discussion, once that many reviews have been submitted in total.
 
@@ -156,9 +158,9 @@ Everything from the first discussion onwards is hidden from the applicant. The s
 1. **Draft** (`draft`)
 2. **Application Received** (`INITIAL_STATE`, "Need screening" to staff)
 3. **Application Review** (`ext_int_external_review`, "External Review" to staff)
-4. **Application Outcome** — shown as Accepted (`ext_int_accepted`), Waitlisted (`ext_int_waitlisted`) or Dismissed (`ext_int_rejected`) once the application reaches that step
+4. **Application Outcome** — shown as Accepted (`ext_int_accepted`), Waitlisted (`ext_int_waitlisted`) or Not Accepted (`ext_int_rejected`, "Dismissed" to staff) once the application reaches that step
 
-The hidden phases (`ext_int_post_external_review_discussion`, `ext_int_internal_review`, `ext_int_post_review_discussion` and `ext_int_determination`) do not add a step of their own — to the applicant the application stays on "Application Review" until an outcome is reached. The three "More information required" states are visible to the applicant, since they need to edit and resubmit their application.
+The hidden phases (`ext_int_ready_for_review`, `ext_int_post_external_review_discussion`, `ext_int_internal_review`, `ext_int_post_review_discussion` and `ext_int_determination`) do not add a step of their own — to the applicant the application stays on "Application Review" until an outcome is reached. The three "More information required" states are visible to the applicant, since they need to edit and resubmit their application.
 
 ### 💡 Concept and Proposal
 

hypha/apply/funds/migrations/0137_alter_anonymizedsubmission_status_and_more.py

@@ -1,4 +1,4 @@
-# Generated by Django 5.2.17 on 2026-08-26 12:22
+# Generated by Django 5.2.17 on 2026-08-27 12:07
 
 from django.db import migrations, models
 
@@ -54,6 +54,7 @@ class Migration(migrations.Migration):
                     ),
                     ("ext_int_post_review_discussion", "Ready for Discussion"),
                     ("ext_int_post_review_more_info", "More information required"),
+                    ("ext_int_ready_for_review", "Ready for Review"),
                     ("ext_int_rejected", "Dismissed"),
                     ("ext_int_waitlisted", "Waitlisted"),
                     ("ext_internal_review", "Internal Review"),
@@ -140,6 +141,7 @@ class Migration(migrations.Migration):
                     ),
                     ("ext_int_post_review_discussion", "Ready for Discussion"),
                     ("ext_int_post_review_more_info", "More information required"),
+                    ("ext_int_ready_for_review", "Ready for Review"),
                     ("ext_int_rejected", "Dismissed"),
                     ("ext_int_waitlisted", "Waitlisted"),
                     ("ext_internal_review", "Internal Review"),

hypha/apply/funds/tests/test_workflows.py

@@ -1,12 +1,15 @@
 """Tests for the workflow registry, focused on the external-then-internal workflow."""
 
+from types import SimpleNamespace
+
 import pytest
 from django.test import SimpleTestCase
 
 from hypha.apply.users.tests.factories import StaffFactory
 
 from ..workflows import (
     DETERMINATION_OUTCOMES,
+    INITIAL_STATE,
     WORKFLOWS,
     ext_or_higher_statuses,
     ext_review_statuses,
@@ -33,21 +36,49 @@ def test_phases_and_steps(self):
             "draft": 0,
             "in_discussion": 1,
             "ext_int_more_info": 1,
-            "ext_int_external_review": 2,
-            "ext_int_post_external_review_discussion": 3,
-            "ext_int_post_external_review_more_info": 3,
-            "ext_int_internal_review": 4,
-            "ext_int_post_review_discussion": 5,
-            "ext_int_post_review_more_info": 5,
-            "ext_int_determination": 6,
-            "ext_int_accepted": 7,
-            "ext_int_waitlisted": 7,
-            "ext_int_rejected": 7,
+            "ext_int_ready_for_review": 2,
+            "ext_int_external_review": 3,
+            "ext_int_post_external_review_discussion": 4,
+            "ext_int_post_external_review_more_info": 4,
+            "ext_int_internal_review": 5,
+            "ext_int_post_review_discussion": 6,
+            "ext_int_post_review_more_info": 6,
+            "ext_int_determination": 7,
+            "ext_int_accepted": 8,
+            "ext_int_waitlisted": 8,
+            "ext_int_rejected": 8,
         }
         self.assertEqual(
             {name: phase.step for name, phase in self.workflow.items()}, expected
         )
 
+    def test_ready_for_review_comes_before_external_review(self):
+        self.assertLess(
+            self.workflow["ext_int_ready_for_review"].step,
+            self.workflow["ext_int_external_review"].step,
+        )
+        # Screening can only reach the external review through the new phase.
+        self.assertNotIn(
+            "ext_int_external_review", self.workflow[INITIAL_STATE].transitions
+        )
+        self.assertIn(
+            "ext_int_ready_for_review", self.workflow[INITIAL_STATE].transitions
+        )
+
+    def test_ready_for_review_is_hidden_from_the_applicant(self):
+        applicant = SimpleNamespace(
+            is_apply_staff=False, is_applicant=True, is_reviewer=False
+        )
+        reviewer = SimpleNamespace(
+            is_apply_staff=False, is_applicant=False, is_reviewer=True
+        )
+        phase = self.workflow["ext_int_ready_for_review"]
+        self.assertEqual(phase.display_name, "Ready for Review")
+        self.assertFalse(phase.permissions.can_view(applicant))
+        self.assertTrue(phase.permissions.can_view(reviewer))
+        # Reviewers only get to review once the external review is opened.
+        self.assertFalse(phase.permissions.can_review(reviewer))
+
     def test_external_review_comes_before_internal_review(self):
         self.assertLess(
             self.workflow["ext_int_external_review"].step,
@@ -78,13 +109,20 @@ def test_waitlist_offered_from_discussion_and_determination(self):
                     "ext_int_waitlisted", self.workflow[phase_name].transitions
                 )
 
+    def test_dismissed_is_softened_for_the_applicant(self):
+        rejected = self.workflow["ext_int_rejected"]
+        self.assertEqual(rejected.display_name, "Dismissed")
+        self.assertEqual(rejected.public_name, "Not Accepted")
+
     def test_outcome_phases_are_terminal(self):
         for phase_name in ["ext_int_accepted", "ext_int_rejected"]:
             with self.subTest(phase=phase_name):
                 self.assertEqual(self.workflow[phase_name].transitions, {})
 
     def test_picked_up_by_derived_status_sets(self):
         self.assertIn("ext_int_external_review", ext_review_statuses)
+        self.assertNotIn("ext_int_ready_for_review", ext_review_statuses)
+        self.assertNotIn("ext_int_ready_for_review", ext_or_higher_statuses)
         self.assertIn("ext_int_internal_review", ext_or_higher_statuses)
         self.assertIn("ext_int_post_review_discussion", DETERMINATION_RESPONSE_PHASES)
 
@@ -97,6 +135,7 @@ def test_walk_the_whole_workflow():
     assert submission.status == "in_discussion"
 
     chain = [
+        "ext_int_ready_for_review",
         "ext_int_external_review",
         "ext_int_post_external_review_discussion",
         "ext_int_internal_review",

hypha/apply/funds/workflows/constants.py

@@ -17,6 +17,7 @@
     "Need screening": "bg-cyan-200",
     "Ready for Determination": "bg-blue-200",
     "Ready for Discussion": "bg-blue-100",
+    "Ready for Review": "bg-yellow-100",
     "Invited for Proposal": "bg-green-100",
     "Internal Review": "bg-yellow-200",
     "External Review": "bg-yellow-200",

hypha/apply/funds/workflows/definitions/single_stage_ext_int.py

@@ -31,7 +31,7 @@
         INITIAL_STATE: {
             "transitions": {
                 "ext_int_more_info": _("Request More Information"),
-                "ext_int_external_review": _("Open External Review"),
+                "ext_int_ready_for_review": _("Ready for Review"),
                 "ext_int_determination": _("Ready for Determination"),
                 "ext_int_rejected": _("Dismiss"),
             },
@@ -59,11 +59,24 @@
             "permissions": applicant_edit_permissions,
         },
     },
+    {
+        "ext_int_ready_for_review": {
+            "transitions": {
+                "ext_int_external_review": _("Open External Review"),
+                "ext_int_determination": _("Ready for Determination"),
+                "ext_int_rejected": _("Dismiss"),
+                INITIAL_STATE: _("Need screening (revert)"),
+            },
+            "display": _("Ready for Review"),
+            "stage": RequestExtInt,
+            "permissions": hidden_from_applicant_permissions,
+        },
+    },
     {
         "ext_int_external_review": {
             "transitions": {
                 "ext_int_post_external_review_discussion": _("Close Review"),
-                INITIAL_STATE: _("Need screening (revert)"),
+                "ext_int_ready_for_review": _("Ready for Review (revert)"),
             },
             "display": _("External Review"),
             "public": _("Application Review"),
@@ -183,6 +196,7 @@
         },
         "ext_int_rejected": {
             "display": _("Dismissed"),
+            "public": _("Not Accepted"),
             "stage": RequestExtInt,
             "permissions": no_permissions,
         },