Skip to content

ArgumentOutOfRangeException: "No logic supported for op_Implicit" on Recommendation Analysis referrers endpoint #243

Description

@tuhincse24

Description

GET /umbraco/management/api/v1/UrlTracker/RecommendationAnalysis/{id}/referrers (the backoffice "Recommendation Analysis" screen) throws an unhandled ArgumentOutOfRangeException instead of returning the most-common-referrer data.

Steps to Reproduce

  1. Trigger a 404 on a URL that UrlTracker tracks as a client error (e.g. visit a non-existent page), so a ClientError row is created for that URL.
  2. Cause at least one referrer to be recorded against that client error (e.g. hit the 404 URL again with a Referer header set, or via a link from another tracked page), so a ClientError2Referrer row exists.
  3. In the Umbraco backoffice, open UrlTracker → Recommendations, select that recommendation, and open its Recommendation Analysis screen.
Image
  • Equivalently, call GET /umbraco/management/api/v1/UrlTracker/RecommendationAnalysis/{id}/referrers directly, where {id} is the recommendation's id.

Expected Behavior

The endpoint returns 200 OK with the list of most-common referrers for that client error (or an empty list if there are none / the error is ignored).

Actual Behavior

The request fails with an unhandled ArgumentOutOfRangeException, and the Recommendation Analysis screen fails to load referrer data.
umbraco/management/api/v1/UrlTracker/RecommendationAnalysis/13/referrers
/umbraco/management/api/v1/UrlTracker/RecommendationAnalysis/13/history

Suggested fix
Replace: ClientErrorRepository.cs:217
sql.Where<ClientError2ReferrerDto>(e => clientErrors.Contains(e.ClientError), _occurrancesTableAlias)
with:
sql.WhereIn<ClientError2ReferrerDto>(e => e.ClientError, clientErrors, _occurrancesTableAlias)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions