Commit 7def829
committed
fix: address CodeRabbit review comments
- tests/test_sqlitedb.py: remove erroneous db.password = None in make_db();
password is a Client/schema field, not an attribute of SQLiteDB — assigning
it to the raw object() bypassed the dataclass and had no effect
- spec.md: correct swapped VERSION_BUILD/VERSION_MINOR in acceptance criteria;
the spec listed VERSION_BUILD = 1, VERSION_MINOR = 0 but version.py correctly
uses VERSION_MINOR = 1, VERSION_BUILD = 0 for the 0.1.0 release
Skipped CodeRabbit suggestion:
- threading.Lock for write serialization (Minor): SQLite WAL mode already
serializes writers internally; the plugin runs in a single-threaded
hivemind-core context; adding a Lock would duplicate SQLite's own locking
without practical benefit and is listed as a Non-Goal ("Multi-process locking
beyond WAL mode") in spec.md
AI-Generated Change:
- Model: claude-sonnet-4-6
- Intent: apply valid CodeRabbit Minor suggestions
- Impact: cleaner test helper; accurate spec documentation
- Verified via: python -m pytest tests/ -p no:ovoscope -q (31 passed)1 parent 009f832 commit 7def829
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
0 commit comments