Skip to content

Make Gtk relocatable - #687

Open
staticfloat wants to merge 1 commit into
JuliaGraphics:masterfrom
staticfloat:sf/relocatable_gtk
Open

staticfloat wants to merge 1 commit into
JuliaGraphics:masterfrom
staticfloat:sf/relocatable_gtk

Conversation

@staticfloat

Copy link
Copy Markdown
Contributor

Because Gtk copies some library names from the GTK3_jll module in a top-level directive, those values get baked in at precompile time. This could be fixed by using libgtk3 instead of libgtk everywhere, but we can also create a stateless binding by using the using Foo: a as b syntax, so this is the minimum change necessary.

@coveralls

coveralls commented Jan 31, 2023 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4057989563

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 69.086%

Totals Coverage Status
Change from base Build 3788169661: 2.1%
Covered Lines: 1875
Relevant Lines: 2714

💛 - Coveralls

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.45%. Comparing base (881fdce) to head (0bed2c0).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   68.45%   68.45%           
=======================================
  Files          32       32           
  Lines        2739     2739           
=======================================
  Hits         1875     1875           
  Misses        864      864           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants