Skip to content

Commit 4dcf515

Browse files
committed
fix(ci): download rusty_v8 override artifacts for all release targets
The setup-rusty-v8 step was gated on `contains(matrix.target, 'unknown-linux-musl')` in build-unix and missing entirely from build-windows. After the v8 crate bumped 149.2.0 -> 150.4.0, the v8 build.rs default downloader requests `librusty_v8_ptrcomp_sandbox_release_*.a.gz` from denoland/rusty_v8, which never published that profile name, so the non-musl targets (macOS x86_64/aarch64, Windows x86_64) failed with 404. Remove the musl-only guard in build-unix and add the same step to build-windows so every target downloads the Codex-built `ptrcomp_sandbox_release` override artifacts from openai/codex rusty-v8-v150.4.0, matching upstream 0.148's unconditional setup-rusty-v8 invocation.
1 parent a1d0088 commit 4dcf515

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/rust-release.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ jobs:
165165
echo "CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_RUSTFLAGS=" >> "$GITHUB_ENV"
166166
echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_RUSTFLAGS=" >> "$GITHUB_ENV"
167167
168-
- name: Configure musl rusty_v8 artifact overrides
169-
if: ${{ contains(matrix.target, 'unknown-linux-musl') }}
168+
- name: Configure rusty_v8 artifact overrides and verify checksums
170169
uses: ./.github/actions/setup-rusty-v8
171170
with:
172171
target: ${{ matrix.target }}
@@ -251,6 +250,11 @@ jobs:
251250
restore-keys: |
252251
${{ runner.os }}-${{ matrix.target }}-cargo-
253252
253+
- name: Configure rusty_v8 artifact overrides and verify checksums
254+
uses: ./.github/actions/setup-rusty-v8
255+
with:
256+
target: ${{ matrix.target }}
257+
254258
- name: Cargo build
255259
shell: bash
256260
run: |

0 commit comments

Comments
 (0)