On a clean checkout with everything else green (golangci-lint 0 issues, all Go tests ok), ./scripts/check.sh still exits 1:
Running C linting...
compile_commands.json not found. Generate with: bear -- make dataplane c-test
The message names the fix but nothing runs it: compile_commands.json is not a prerequisite of any target, and bear is not in the documented toolchain. So the repo's own top-level check script cannot pass locally without an undocumented manual step.
Either make the C-lint step generate its own compile database (or depend on a target that does), or skip with a warning when bear/the database is absent so a missing optional tool doesn't fail the whole gate.
On a clean checkout with everything else green (golangci-lint
0 issues, all Go testsok),./scripts/check.shstill exits 1:The message names the fix but nothing runs it:
compile_commands.jsonis not a prerequisite of any target, andbearis not in the documented toolchain. So the repo's own top-level check script cannot pass locally without an undocumented manual step.Either make the C-lint step generate its own compile database (or depend on a target that does), or skip with a warning when
bear/the database is absent so a missing optional tool doesn't fail the whole gate.