[kvalliyurnatt]

Description

There are certain Node labels that are updated by multiple operands and the GPU operator, using a plain PATCH for these labels can overwrite the values incorrectly. We use a PATCH with optimistic locking for some of these operations

Checklist

• No secrets, sensitive information, or unrelated changes
• Lint checks passing (make lint)
• Generated assets in-sync (make validate-generated-assets)
• Go mod artifacts in-sync (make validate-modules)
• Test cases are added for new code paths

Testing

Added unit tests to cover the scenarios.

---

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: NVIDIA/gpu-operator
• Branch: main
• File: .coderabbit.yaml
• Commit: f05f4f7
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Enterprise
• Run ID: c92bd176-6382-4b21-b45d-8ed73231ed3b

📥 Commits

Reviewing files that changed from the base of the PR and between f05f4f7 and 755b5c3.

📒 Files selected for processing: 2

• controllers/nodelabeling_controller.go
• controllers/nodelabeling_controller_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The GPU-node and orphaned-driver-pod labeling paths now use optimistic-lock merge patches. New tests inject concurrent node updates before the first patch, verify that the patch conflicts, and check that a subsequent labeling attempt preserves the concurrent values.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 755b5

No merge-blocking issue is identified. The node-label patch change appears ready for normal validation before merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}