From 60070421a3aa6e946d47e3ec278eb90ecfe534e7 Mon Sep 17 00:00:00 2001
From: sr73318 <sr73318@netapp.com>
Date: Thu, 13 Aug 2026 11:45:55 +0530
Subject: [PATCH 1/2] CSTACKEX-246: setting volume format based on protocol

---
 .../cloudstack/storage/volume/VolumeServiceImpl.java  |  2 +-
 .../storage/driver/OntapPrimaryDatastoreDriver.java   | 11 ++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
index 00b5148a6e4d..f36fa0f1bbc1 100644
--- a/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
+++ b/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
@@ -737,7 +737,7 @@ protected Void managedCopyBaseImageCallback(AsyncCallbackDispatcher<VolumeServic
 
             volume.setPath(templateObjectTo.getPath());
 
-            if (templateObjectTo.getFormat() != null) {
+            if (templateObjectTo.getFormat() != null && volume.getFormat() != null) {
                 volume.setFormat(templateObjectTo.getFormat());
             }
 
diff --git a/plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java b/plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
index d6b7b089d6bf..0c7d07e8fed1 100644
--- a/plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
+++ b/plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
@@ -160,7 +160,7 @@ public void createAsync(DataStore dataStore, DataObject dataObject, AsyncComplet
 
                     volumeVO.setPoolType(storagePool.getPoolType());
                     volumeVO.setPoolId(storagePool.getId());
-                    volumeVO.setFormat(getImageFormatByHypervisor(storagePool.getHypervisor()));
+                    volumeVO.setFormat(getImageFormatByHypervisor(storagePool.getHypervisor(), details.get(OntapStorageConstants.PROTOCOL)));
                     logger.info("createAsync: Volume format set to [{}] for hypervisor [{}]", volumeVO.getFormat(), storagePool.getHypervisor());
 
                     if (ProtocolType.ISCSI.name().equalsIgnoreCase(details.get(OntapStorageConstants.PROTOCOL))) {
@@ -988,9 +988,14 @@ private String buildSnapshotName(String cloudStackSnapshotName, long snapshotId)
     }
 
 
-    private Storage.ImageFormat getImageFormatByHypervisor(HypervisorType hypervisorType) {
+    private Storage.ImageFormat getImageFormatByHypervisor(HypervisorType hypervisorType, String protocol) {
         if (HypervisorType.KVM.equals(hypervisorType)) {
-            return Storage.ImageFormat.QCOW2;
+            if (ProtocolType.NFS3.name().equalsIgnoreCase(protocol)) {
+                return Storage.ImageFormat.QCOW2;
+            } else if (ProtocolType.ISCSI.name().equalsIgnoreCase(protocol)) {
+                return Storage.ImageFormat.RAW;
+            }
+            throw new CloudRuntimeException("Unsupported protocol [" + protocol + "] for ONTAP image format resolution");
         }
         throw new CloudRuntimeException("Unsupported hypervisor [" + hypervisorType + "] for ONTAP image format resolution");
     }

From 403931694b5f3703f775cbbb37fe2ab3b871b991 Mon Sep 17 00:00:00 2001
From: sr73318 <sr73318@netapp.com>
Date: Thu, 13 Aug 2026 17:46:21 +0530
Subject: [PATCH 2/2] CSTACKEX-246: fixing a small error

---
 .../org/apache/cloudstack/storage/volume/VolumeServiceImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
index f36fa0f1bbc1..fc5dc6dcc9b9 100644
--- a/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
+++ b/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
@@ -737,7 +737,7 @@ protected Void managedCopyBaseImageCallback(AsyncCallbackDispatcher<VolumeServic
 
             volume.setPath(templateObjectTo.getPath());
 
-            if (templateObjectTo.getFormat() != null && volume.getFormat() != null) {
+            if (templateObjectTo.getFormat() != null && volume.getFormat() == null) {
                 volume.setFormat(templateObjectTo.getFormat());
             }