feat: propagate CancellationToken throughout the backend

Thread cancellation tokens from controllers, SignalR hubs, auth handlers,
the LiveControlGateway receive loop and cron jobs down into every service
and EF Core/HttpClient/HybridCache call that accepts one.

- Services (device, OTA, configuration, control sender, webhook, device
  update, account, API token, session create/logout) take a token.
- Hubs use Context.ConnectionAborted; auth handlers use RequestAborted.
- Cron jobs use the host's ApplicationStopping token; Execute() keeps no
  parameters so Hangfire job signatures are unchanged.
- Email outbox delivery stops on shutdown and always records a send's
  outcome once the email has gone out.
- Add .editorconfig disabling the primary-constructor suggestion.

Author: hhvrc

.editorconfig

@@ -0,0 +1,7 @@
+root = true
+
+[*.cs]
+# Do not suggest converting constructors into primary constructors
+csharp_style_prefer_primary_constructors = false
+dotnet_diagnostic.IDE0290.severity = none
+resharper_convert_to_primary_constructor_highlighting = none

API.IntegrationTests/Tests/AutomationTokenTests.cs

@@ -235,7 +235,7 @@ public async Task PasswordReset_ForNormalAccount_StartsResetAndAudits()
     // --- Admin endpoints ---
 
     [Test]
-    public async Task Create_ReturnsWorkingSecret()
+    public async Task Create_ReturnsWorkingSecret(CancellationToken cancellationToken)
     {
         using var client = await CreateAdminClient("autocreate");
 
@@ -252,14 +252,14 @@ public async Task Create_ReturnsWorkingSecret()
 
         await using var scope = WebApplicationFactory.Services.CreateAsyncScope();
         var service = scope.ServiceProvider.GetRequiredService<IAutomationTokenService>();
-        var resolved = await service.ResolveAsync(secret, CancellationToken.None);
+        var resolved = await service.ResolveAsync(secret, cancellationToken);
         await Assert.That(resolved).IsNotNull();
         await Assert.That(resolved!.Id).IsEqualTo(id);
         await Assert.That(resolved.Types).Contains(AutomationTokenType.Turnstile);
     }
 
     [Test]
-    public async Task Rotate_OldSecretStopsResolving()
+    public async Task Rotate_OldSecretStopsResolving(CancellationToken cancellationToken)
     {
         var (tokenId, oldSecret) = await CreateAutomationTokenInDb();
         using var client = await CreateAdminClient("autorotate");
@@ -271,8 +271,8 @@ public async Task Rotate_OldSecretStopsResolving()
 
         await using var scope = WebApplicationFactory.Services.CreateAsyncScope();
         var service = scope.ServiceProvider.GetRequiredService<IAutomationTokenService>();
-        await Assert.That(await service.ResolveAsync(oldSecret, CancellationToken.None)).IsNull();
-        await Assert.That((await service.ResolveAsync(newSecret, CancellationToken.None))?.Id).IsEqualTo(tokenId);
+        await Assert.That(await service.ResolveAsync(oldSecret, cancellationToken)).IsNull();
+        await Assert.That((await service.ResolveAsync(newSecret, cancellationToken))?.Id).IsEqualTo(tokenId);
     }
 
     [Test]

API/Controller/Account/Authenticated/ChangeEmail.cs

@@ -21,6 +21,7 @@ public sealed partial class AuthenticatedAccountController
     /// address; the change is not applied until that link is opened.
     /// </summary>
     /// <param name="body"></param>
+    /// <param name="cancellationToken"></param>
     [HttpPost("email-change")]
     [Consumes(MediaTypeNames.Application.Json)]
     [ProducesResponseType(StatusCodes.Status200OK)]
@@ -30,7 +31,7 @@ public sealed partial class AuthenticatedAccountController
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status409Conflict, MediaTypeNames.Application.ProblemJson)] // EmailChangeAlreadyInUse
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status429TooManyRequests, MediaTypeNames.Application.ProblemJson)] // EmailChangeTooMany
     // notActivated / deactivated / notFound are blocked by UserSessionAuthentication before reaching this controller.
-    public async Task<IActionResult> ChangeEmail([FromBody] ChangeEmailRequest body)
+    public async Task<IActionResult> ChangeEmail([FromBody] ChangeEmailRequest body, CancellationToken cancellationToken)
     {
         if (string.IsNullOrEmpty(CurrentUser.PasswordHash))
         {
@@ -42,7 +43,7 @@ public async Task<IActionResult> ChangeEmail([FromBody] ChangeEmailRequest body)
             return Problem(AccountError.PasswordChangeInvalidPassword);
         }
 
-        var result = await _accountService.CreateEmailChangeFlowAsync(CurrentUser.Id, body.Email, actorId: CurrentUser.Id);
+        var result = await _accountService.CreateEmailChangeFlowAsync(CurrentUser.Id, body.Email, actorId: CurrentUser.Id, cancellationToken: cancellationToken);
 
         return result switch
         {

API/Controller/Account/Authenticated/ChangePassword.cs

@@ -20,6 +20,7 @@ public sealed partial class AuthenticatedAccountController
     /// Change the password of the current user
     /// </summary>
     /// <param name="body"></param>
+    /// <param name="cancellationToken"></param>
     /// <returns></returns>
     /// <exception cref="Exception"></exception>
     [HttpPost("password")]
@@ -28,7 +29,7 @@ public sealed partial class AuthenticatedAccountController
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status403Forbidden, MediaTypeNames.Application.ProblemJson)] // PasswordChangeInvalidPassword
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status409Conflict, MediaTypeNames.Application.ProblemJson)] // PasswordNotSet
     // notActivated / deactivated / notFound are blocked by UserSessionAuthentication before reaching this controller.
-    public async Task<IActionResult> ChangePassword([FromBody] ChangePasswordRequest body)
+    public async Task<IActionResult> ChangePassword([FromBody] ChangePasswordRequest body, CancellationToken cancellationToken)
     {
         // OAuth-only accounts that have never set a password must go through the email-confirmed
         // /password/set flow rather than silently setting one through this endpoint.
@@ -42,7 +43,7 @@ public async Task<IActionResult> ChangePassword([FromBody] ChangePasswordRequest
             return Problem(AccountError.PasswordChangeInvalidPassword);
         }
 
-        var result = await _accountService.ChangePasswordAsync(CurrentUser.Id, body.NewPassword, actorId: CurrentUser.Id);
+        var result = await _accountService.ChangePasswordAsync(CurrentUser.Id, body.NewPassword, actorId: CurrentUser.Id, cancellationToken: cancellationToken);
 
         return result switch
         {

API/Controller/Account/Authenticated/ChangeUsername.cs

@@ -19,6 +19,7 @@ public sealed partial class AuthenticatedAccountController
     /// Change the username of the current user
     /// </summary>
     /// <param name="body"></param>
+    /// <param name="cancellationToken"></param>
     /// <returns></returns>
     /// <exception cref="Exception"></exception>
     [HttpPost("username")]
@@ -27,10 +28,11 @@ public sealed partial class AuthenticatedAccountController
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status409Conflict, MediaTypeNames.Application.ProblemJson)] // UsernameTaken
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status400BadRequest, MediaTypeNames.Application.ProblemJson)] // UsernameInvalid
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status403Forbidden, MediaTypeNames.Application.ProblemJson)] // UsernameRecentlyChanged
-    public async Task<IActionResult> ChangeUsername([FromBody] ChangeUsernameRequest body)
+    public async Task<IActionResult> ChangeUsername([FromBody] ChangeUsernameRequest body, CancellationToken cancellationToken)
     {
         var result = await _accountService.ChangeUsernameAsync(CurrentUser.Id, body.Username, actorId: CurrentUser.Id,
-            ignoreLimit: CurrentUser.Roles.Any(r => r is RoleType.Staff or RoleType.Admin or RoleType.System));
+            ignoreLimit: CurrentUser.Roles.Any(r => r is RoleType.Staff or RoleType.Admin or RoleType.System),
+            cancellationToken: cancellationToken);
 
         return result switch
         {

API/Controller/Account/Authenticated/Deactivate.cs

@@ -20,9 +20,9 @@ public sealed partial class AuthenticatedAccountController
     [HttpDelete]
     [ProducesResponseType(StatusCodes.Status204NoContent)]
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status403Forbidden, MediaTypeNames.Application.ProblemJson)] // CannotDeactivatePrivledgedAccount
-    public async Task<IActionResult> Deactivate()
+    public async Task<IActionResult> Deactivate(CancellationToken cancellationToken)
     {
-        var deactivationResult = await _accountService.DeactivateAccountAsync(CurrentUser.Id, CurrentUser.Id, deleteLater: true);
+        var deactivationResult = await _accountService.DeactivateAccountAsync(CurrentUser.Id, CurrentUser.Id, deleteLater: true, cancellationToken: cancellationToken);
         return deactivationResult switch
         {
             Results.Success => NoContent(),

API/Controller/Account/LoginV2.cs

@@ -65,7 +65,7 @@ public async Task<IActionResult> LoginV2(
         if (!await automationTokens.TryRecordUseAsync(account.Id, AutomationTokenFlow.Login, cancellationToken))
             return Problem(AutomationTokenError.NotAllowedForAccount);
 
-        await CreateSession(account.Id, cookieDomain);
+        await CreateSession(account.Id, cookieDomain, cancellationToken);
 
         return Ok(LoginV2OkResponse.FromUser(account));
     }

API/Controller/Account/Logout.cs

@@ -10,15 +10,15 @@ public sealed partial class AccountController
     [HttpPost("logout")]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [MapToApiVersion("1")]
-    public async Task<IActionResult> Logout([FromServices] ISessionService sessionService)
+    public async Task<IActionResult> Logout([FromServices] ISessionService sessionService, CancellationToken cancellationToken)
     {
         // Remove session if valid
         if (HttpContext.TryGetUserSessionToken(out var sessionToken))
         {
             var session = await sessionService.GetSessionByTokenAsync(sessionToken);
             if (session is not null)
             {
-                await sessionService.LogoutSessionAsync(session);
+                await sessionService.LogoutSessionAsync(session, cancellationToken);
             }
         }
 

API/Controller/Account/PasswordResetComplete.cs

@@ -34,6 +34,7 @@ public IActionResult PasswordResetCompleteLegacy([FromRoute] Guid passwordResetI
     /// <param name="passwordResetId">The id of the password reset</param>
     /// <param name="secret">The secret of the password reset</param>
     /// <param name="body"></param>
+    /// <param name="cancellationToken"></param>
     /// <response code="200">Password successfully changed</response>
     /// <response code="404">Password reset process not found</response>
     [HttpPost("password-reset/{passwordResetId}/{secret}/complete")]
@@ -43,9 +44,10 @@ public IActionResult PasswordResetCompleteLegacy([FromRoute] Guid passwordResetI
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status404NotFound, MediaTypeNames.Application.ProblemJson)] // PasswordResetNotFound
     [MapToApiVersion("1")]
     public async Task<IActionResult> PasswordResetComplete([FromRoute] Guid passwordResetId,
-        [FromRoute] string secret, [FromBody] PasswordResetProcessData body)
+        [FromRoute] string secret, [FromBody] PasswordResetProcessData body,
+        CancellationToken cancellationToken)
     {
-        var passwordResetComplete = await _accountService.CompletePasswordResetFlowAsync(passwordResetId, secret, body.Password);
+        var passwordResetComplete = await _accountService.CompletePasswordResetFlowAsync(passwordResetId, secret, body.Password, cancellationToken);
 
         return passwordResetComplete switch
         {

API/Controller/Account/PasswordResetInitiateV2.cs

@@ -48,7 +48,7 @@ public async Task<IActionResult> PasswordResetInitiateV2([FromBody] PasswordRese
             return Ok();
         }
 
-        await _accountService.CreatePasswordResetFlowAsync(body.Email);
+        await _accountService.CreatePasswordResetFlowAsync(body.Email, cancellationToken);
 
         return Ok();
     }