refactor(weighted-score): unify Edit Weights affordance via dropdown action entry

Replace per-surface Edit Weights buttons (TreeTab heatmap, ItemDB unique
sort) with a shared action entry appended to any sort/heatmap dropdown
that exposes Weighted Score. NotableDB anoint sort gains the same
affordance (no Edit Weights button before).

Why: the ItemDB pane is 360 px wide; the previous Edit Weights button
shared the same anchor as the League dropdown and forced a mutually
exclusive show/hide between League filter and Edit Weights. A user who
wanted to filter by League and sort by Weighted Score could not do both.

WeightedScore.appendEditWeightsAction(list, openEditor) sentinel-checks
for any entry with isWeightedScore and appends a single action entry.
Each consumer dropdown selFunc gates on value.isAction: invokes
value.action() then restores the prior selection via SelByValue.

Tests: 2 new specs in TestWeightedScore_spec (no-op without WS, append
plus invocable callback when WS present). Peer-reviewed by Codex
(approved, no blocking findings).

Author: mcagnion

spec/System/TestWeightedScore_spec.lua

@@ -379,4 +379,33 @@ describe("WeightedScore — tree integration", function()
 		assert.is_not_nil(found, "WeightedScore entry should appear in fallbackWeightsList candidates")
 		assert.is_function(found.getValue, "getValue must be propagated into the dropdown entry")
 	end)
+
+	-- appendEditWeightsAction -----------------------------------------------
+
+	it("appendEditWeightsAction is a no-op when the list has no WeightedScore entry", function()
+		local list = {
+			{ label = "Sort by Name", sortMode = "name" },
+			{ label = "Sort by Life", sortMode = "Life" },
+		}
+		local called = false
+		WeightedScore.appendEditWeightsAction(list, function() called = true end)
+		assert.are.equal(2, #list)
+		assert.is_false(called)
+	end)
+
+	it("appendEditWeightsAction appends an action entry when WeightedScore is present", function()
+		local list = {
+			{ label = "Sort by Name", sortMode = "name" },
+			{ label = "Sort by Weighted Score", sortMode = "WeightedScore", isWeightedScore = true },
+		}
+		local opened = false
+		WeightedScore.appendEditWeightsAction(list, function() opened = true end)
+		assert.are.equal(3, #list)
+		local entry = list[3]
+		assert.is_true(entry.isAction)
+		assert.is_function(entry.action)
+		assert.is_string(entry.label)
+		entry.action()
+		assert.is_true(opened, "calling entry.action must invoke the openEditor callback")
+	end)
 end)

src/Classes/ItemDBControl.lua

@@ -36,19 +36,16 @@ local ItemDBClass = newClass("ItemDBControl", "ListControl", function(self, anch
 	end)
 	if dbType == "UNIQUE" then
 		self.controls.sort = new("DropDownControl", {"BOTTOMLEFT",self,"TOPLEFT"}, {0, baseY + 20, 179, 18}, self.sortDropList, function(index, value)
-			self:SetSortMode(value.sortMode)
+			if value.isAction then
+				value.action()
+				self.controls.sort:SelByValue(self.sortMode, "sortMode")
+			else
+				self:SetSortMode(value.sortMode)
+			end
 		end)
 		self.controls.league = new("DropDownControl", {"LEFT",self.controls.sort,"RIGHT"}, {2, 0, 179, 18}, self.leagueList, function(index, value)
 			self.listBuildFlag = true
 		end)
-		self.controls.editWeights = new("ButtonControl", {"LEFT",self.controls.sort,"RIGHT"}, {2, 0, 179, 18}, "Edit Weights...", function()
-			local tq = self.itemsTab.tradeQuery
-			if tq then
-				tq:SetStatWeights(nil, function() self.listBuildFlag = true end)
-			end
-		end)
-		self.controls.league.shown = function() return self.sortMode ~= "WeightedScore" end
-		self.controls.editWeights.shown = function() return self.sortMode == "WeightedScore" end
 		self.controls.requirement = new("DropDownControl", {"LEFT",self.controls.sort,"BOTTOMLEFT"}, {0, 11, 179, 18}, { "Any requirements", "Current level", "Current attributes", "Current useable" }, function(index, value)
 			self.listBuildFlag = true
 		end)
@@ -210,6 +207,12 @@ function ItemDBClass:BuildSortOrder()
 			})
 		end
 	end
+	WeightedScore.appendEditWeightsAction(self.sortDropList, function()
+		local tq = self.itemsTab.tradeQuery
+		if tq then
+			tq:SetStatWeights(nil, function() self.listBuildFlag = true end)
+		end
+	end)
 	wipeTable(self.sortOrder)
 	if self.controls.sort then
 		self.controls.sort:CheckDroppedWidth(true)

src/Classes/NotableDBControl.lua

@@ -34,7 +34,12 @@ local NotableDBClass = newClass("NotableDBControl", "ListControl", function(self
 	self.sortOrder = { }
 	self.sortMode = "NAME"
 	self.controls.sort = new("DropDownControl", {"BOTTOMLEFT",self,"TOPLEFT"}, {0, -22, 360, 18}, self.sortDropList, function(index, value)
-		self:SetSortMode(value.sortMode)
+		if value.isAction then
+			value.action()
+			self.controls.sort:SelByValue(self.sortMode, "sortMode")
+		else
+			self:SetSortMode(value.sortMode)
+		end
 	end)
 	self.controls.search = new("EditControl", {"BOTTOMLEFT",self,"TOPLEFT"}, {0, -2, 258, 18}, "", "Search", "%c", 100, function()
 		self.listBuildFlag = true
@@ -100,6 +105,12 @@ function NotableDBClass:BuildSortOrder()
 			})
 		end
 	end
+	WeightedScore.appendEditWeightsAction(self.sortDropList, function()
+		local tq = self.itemsTab.tradeQuery
+		if tq then
+			tq:SetStatWeights(nil, function() self.listBuildFlag = true end)
+		end
+	end)
 	wipeTable(self.sortOrder)
 	if self.controls.sort then
 		self.controls.sort.selIndex = 1

src/Classes/TreeTab.lua

@@ -251,7 +251,14 @@ local TreeTabClass = newClass("TreeTab", "ControlHost", function(self, build)
 
 	-- Control for selecting the power stat to sort by (Defense, DPS, etc)
 	self.controls.treeHeatMapStatSelect = new("DropDownControl", { "LEFT", self.controls.nodePowerMaxDepthSelect, "RIGHT" }, { 8, 0, 150, 20 }, nil, function(index, value)
-		self:SetPowerCalc(value)
+		if value.isAction then
+			value.action()
+			if self.build.calcsTab.powerStat then
+				self.controls.treeHeatMapStatSelect:SelByValue(self.build.calcsTab.powerStat.stat, "stat")
+			end
+		else
+			self:SetPowerCalc(value)
+		end
 	end)
 	self.controls.treeHeatMap.tooltipText = function()
 		local offCol, defCol = main.nodePowerTheme:match("(%a+)/(%a+)")
@@ -264,26 +271,19 @@ local TreeTabClass = newClass("TreeTab", "ControlHost", function(self, build)
 			t_insert(self.powerStatList, stat)
 		end
 	end
+	WeightedScore.appendEditWeightsAction(self.powerStatList, function()
+		local tq = self.build.itemsTab.tradeQuery
+		if tq then
+			tq:SetStatWeights(nil, function() self:SetPowerCalc(self.build.calcsTab.powerStat) end)
+		end
+	end)
 
 	-- Show/Hide Power Report Button
 	self.controls.powerReport = new("ButtonControl", { "LEFT", self.controls.treeHeatMapStatSelect, "RIGHT" }, { 8, 0, 150, 20 },
 		function() return self.controls.powerReportList.shown and "Hide Power Report" or "Show Power Report" end, function()
 		self.controls.powerReportList.shown = not self.controls.powerReportList.shown
 	end)
 
-	-- Edit Weights button (only shown when Weighted Score heatmap mode is active)
-	self.controls.editWeights = new("ButtonControl",
-		{ "LEFT", self.controls.powerReport, "RIGHT" }, { 8, 0, 130, 20 },
-		"Edit Weights...",
-		function()
-			local tq = self.build.itemsTab.tradeQuery
-			if tq then
-				tq:SetStatWeights(nil, function() self:SetPowerCalc(self.build.calcsTab.powerStat) end)
-			end
-		end
-	)
-	self.controls.editWeights.shown = false
-
 	-- Power Report List
 	local yPos = self.controls.treeHeatMap.y == 0 and self.controls.specSelect.height + 4 or self.controls.specSelect.height * 2 + 8
 	self.controls.powerReportList = new("PowerReportListControl", { "TOPLEFT", self.controls.specSelect, "BOTTOMLEFT" }, { 0, yPos, 700, 170 }, function(selectedNode)
@@ -472,7 +472,6 @@ function TreeTabClass:Draw(viewPort, inputEvents)
 
 	self.controls.treeHeatMap.state = self.viewer.showHeatMap
 	self.controls.treeHeatMapStatSelect.shown = self.viewer.showHeatMap
-	self.controls.editWeights.shown = self.viewer.showHeatMap and self.build.calcsTab.powerStat and self.build.calcsTab.powerStat.isWeightedScore or false
 	self.controls.treeHeatMapStatSelect.list = self.powerStatList
 	self.controls.treeHeatMapStatSelect.selIndex = 1
 	self.controls.treeHeatMapStatSelect:CheckDroppedWidth(true)
@@ -1055,7 +1054,6 @@ function TreeTabClass:SetPowerCalc(powerStat)
 	self.build.buildFlag = true
 	self.build.calcsTab.powerBuildFlag = true
 	self.build.calcsTab.powerStat = powerStat
-	self.controls.editWeights.shown = powerStat and powerStat.isWeightedScore or false
 	self.controls.powerReportList:SetReport(powerStat, nil)
 	-- Remove old toast and clear dismissed state so toast can show for new power report
 	if self.powerBuilderToastId then

src/Modules/WeightedScore.lua

@@ -71,4 +71,23 @@ function WeightedScore.computeRatioScore(baseOutput, newOutput, weights)
 	return meanStatDiff
 end
 
+-- Append a contextual "Edit Weights..." action to a sort dropdown list when the
+-- list contains the WeightedScore entry. Lets every WS-aware sort surface share
+-- the same affordance without each one adding its own button.
+function WeightedScore.appendEditWeightsAction(sortDropList, openEditor)
+	local hasWeightedScore = false
+	for _, entry in ipairs(sortDropList) do
+		if entry.isWeightedScore then
+			hasWeightedScore = true
+			break
+		end
+	end
+	if not hasWeightedScore then return end
+	table.insert(sortDropList, {
+		label = colorCodes.TIP .. "Edit Weights...",
+		isAction = true,
+		action = openEditor,
+	})
+end
+
 return WeightedScore