Name the broken exhibit in the warning message

Author: rajeswari1301

docassemble/AssemblyLine/al_document.py

@@ -2211,18 +2211,24 @@ def has_broken_documents(self) -> bool:
         Returns:
             bool: True if any document or nested bundle has broken content.
         """
+        return len(self.broken_exhibit_titles()) > 0
+
+    def broken_exhibit_titles(self) -> List[str]:
+        """
+        Returns the titles of any broken exhibits in this bundle, including
+        ones inside nested bundles.
+
+        Returns:
+            List[str]: Titles of exhibits that will be skipped.
+        """
+        titles: List[str] = []
         for document in self.enabled_documents():
-            if (
-                hasattr(document, "has_broken_exhibits")
-                and document.has_broken_exhibits()
-            ):
-                return True
-            if (
-                isinstance(document, ALDocumentBundle)
-                and document.has_broken_documents()
-            ):
-                return True
-        return False
+            if hasattr(document, "broken_exhibits"):
+                for exhibit in document.broken_exhibits():
+                    titles.append(getattr(exhibit, "title", None) or "an exhibit")
+            if isinstance(document, ALDocumentBundle):
+                titles.extend(document.broken_exhibit_titles())
+        return titles
 
     def broken_documents_warning_html(self) -> str:
         """
@@ -2232,14 +2238,15 @@ def broken_documents_warning_html(self) -> str:
         Returns:
             str: The warning HTML, or an empty string if nothing is broken.
         """
-        if not self.has_broken_documents():
+        broken_titles = self.broken_exhibit_titles()
+        if not broken_titles:
             return ""
-        return (
-            '<div class="alert alert-warning" role="alert">'
-            "One of your files did not upload correctly and it will not be included. "
-            "Please try uploading it again before you continue."
-            "</div>"
-        )
+        quoted = [f'"{escape(title)}"' for title in broken_titles]
+        if len(quoted) == 1:
+            message = f"{quoted[0]} did not upload correctly and won't be included. Please try uploading it again before you continue."
+        else:
+            message = f"{', '.join(quoted[:-1])} and {quoted[-1]} didn't upload correctly and won't be included. Please try uploading them again before you continue."
+        return f'<div class="alert alert-warning" role="alert">{message}</div>'
 
     def download_list_html(
         self,

docassemble/AssemblyLine/test_al_document.py

@@ -98,16 +98,30 @@ def as_pdf(self, **kwargs):
         return self._pdf
 
 
+class FakeExhibit:
+    def __init__(self, title):
+        self.title = title
+
+
 class FakeDocWithBrokenExhibits:
-    def __init__(self, broken):
+    def __init__(self, broken, broken_titles=None):
         self._broken = broken
+        if broken_titles is not None:
+            self._broken_titles = broken_titles
+        elif broken:
+            self._broken_titles = ["Broken Exhibit"]
+        else:
+            self._broken_titles = []
 
     def is_enabled(self, refresh=True):
         return True
 
     def has_broken_exhibits(self):
         return self._broken
 
+    def broken_exhibits(self):
+        return [FakeExhibit(title) for title in self._broken_titles]
+
 
 class TestSingleDocumentBundleFilename(unittest.TestCase):
     def test_bundle_as_pdf_renames_single_document_to_bundle_filename(self):
@@ -307,6 +321,21 @@ def test_bundle_detects_broken_document_in_nested_bundle(self):
 
         self.assertTrue(outer_bundle.has_broken_documents())
 
+    def test_warning_names_the_broken_exhibit(self):
+        bundle = ALDocumentBundle(
+            "bundle",
+            elements=[
+                FakeDocWithBrokenExhibits(broken=True, broken_titles=["Pay Stub"])
+            ],
+            title="Bundle title",
+            filename="bundle-output.pdf",
+            enabled=True,
+        )
+
+        warning = bundle.broken_documents_warning_html()
+
+        self.assertIn("Pay Stub", warning)
+
 
 class test_aladdendum(unittest.TestCase):
     def test_safe_value(self):