Is your feature request related to a problem? Please describe:
The TADA Criteria and Methodologies template created by TADA_DefineCriteriaMethodology() includes a salt/freshwater indicator column, "SaltFresh". Ideally, we could fill this in automatically for users to reduce the burden of filling out this TADA Criteria and Methodologies template.
Describe the solution you'd like:
The "SaltFresh" column could be populated based on the WQP or ATTAINS water type (if that is already populated in the input data). TADA_CrosswalkATTAINSWaterTypes() could be leveraged to create the ATTAINS Water Type from the WQP Monitoring Location Type.
The next step would be to create a new helper function to assign a salt or freshwater indicator. Can this be accomplished by adding a salt/freshwater indicator column to the same crosswalk the TADA team is already maintaining for WQP and ATTAINS water types? This file is the ATTAINSWaterTypeToWQPMonLocType.csv found in extdata.
What should the output of this helper function look like? Should the new "SaltFresh" column be added to the input data frame or should the existing column in TADA_DefineCriteriaMethodology be updated (filled in) and that would be the output?
For example, a user could enter both a TADA data frame and TADA criteria and methodologies file into this helper function, and the output would be the TADA criteria and methodologies file with the "SaltFresh" column filled in (no other changes).
Is your feature request related to a problem? Please describe:
The TADA Criteria and Methodologies template created by TADA_DefineCriteriaMethodology() includes a salt/freshwater indicator column, "SaltFresh". Ideally, we could fill this in automatically for users to reduce the burden of filling out this TADA Criteria and Methodologies template.
Describe the solution you'd like:
The "SaltFresh" column could be populated based on the WQP or ATTAINS water type (if that is already populated in the input data). TADA_CrosswalkATTAINSWaterTypes() could be leveraged to create the ATTAINS Water Type from the WQP Monitoring Location Type.
The next step would be to create a new helper function to assign a salt or freshwater indicator. Can this be accomplished by adding a salt/freshwater indicator column to the same crosswalk the TADA team is already maintaining for WQP and ATTAINS water types? This file is the ATTAINSWaterTypeToWQPMonLocType.csv found in extdata.
What should the output of this helper function look like? Should the new "SaltFresh" column be added to the input data frame or should the existing column in TADA_DefineCriteriaMethodology be updated (filled in) and that would be the output?
For example, a user could enter both a TADA data frame and TADA criteria and methodologies file into this helper function, and the output would be the TADA criteria and methodologies file with the "SaltFresh" column filled in (no other changes).