fix: improve license detection details view to handle null file matches

Signed-off-by: berzz26 <aumtamboli2233@gmail.com>

Author: berzz26

scanpipe/tests/test_views.py

@@ -1437,6 +1437,135 @@ def test_scanpipe_views_license_detection_details_view_match_texts(self):
         self.assertContains(response, "Rule text")
         self.assertContains(response, "license: MIT")
 
+    def test_scanpipe_views_license_detection_details_view_match_texts_null_from_file(self):
+        matches = [
+            {
+                "score": 100.0,
+                "start_line": 1,
+                "end_line": 1,
+                "matched_length": 3,
+                "match_coverage": 100.0,
+                "matcher": "1-spdx-id",
+                "license_expression": "isc",
+                "rule_identifier": "isc_9931cb7ad33c2eb18f322c94660b670a84186baa.RULE",
+                "matched_text": "ISC",
+                "from_file": None,
+            }
+        ]
+        license_detection = DiscoveredLicense.objects.create(
+            project=self.project1,
+            license_expression="isc",
+            license_expression_spdx="ISC",
+            identifier="isc-null-from-file",
+            matches=matches,
+            detection_count=2,
+            file_regions=[
+                {"path": "a/package.json", "start_line": 1, "end_line": 1},
+                {"path": "b/package-lock.json", "start_line": 1, "end_line": 1},
+            ],
+        )
+
+        url = reverse(
+            "license_detail",
+            args=[self.project1.slug, license_detection.identifier],
+        )
+        response = self.client.get(url)
+
+        self.assertContains(response, "Matches by file")
+        self.assertContains(response, "a/package.json")
+        self.assertContains(response, "b/package-lock.json")
+        self.assertContains(response, "ISC")
+        self.assertNotContains(response, "No match text is available for this file region.")
+        self.assertNotContains(response, "No origin resource path")
+
+    def test_scanpipe_views_license_detection_details_view_match_texts_mixed_from_file(self):
+        matches = [
+            {
+                "score": 100.0,
+                "start_line": 1,
+                "end_line": 1,
+                "matched_length": 4,
+                "match_coverage": 100.0,
+                "matcher": "1-hash",
+                "license_expression": "mit",
+                "rule_identifier": "mit_1.RULE",
+                "matched_text": "License: MIT",
+                "from_file": "LICENSE",
+            },
+            {
+                "score": 100.0,
+                "start_line": 5,
+                "end_line": 5,
+                "matched_length": 3,
+                "match_coverage": 100.0,
+                "matcher": "1-spdx-id",
+                "license_expression": "apache-2.0",
+                "rule_identifier": "apache2_99.RULE",
+                "matched_text": "Apache-2.0",
+                "from_file": None,
+            },
+        ]
+        license_detection = DiscoveredLicense.objects.create(
+            project=self.project1,
+            license_expression="mit AND apache-2.0",
+            license_expression_spdx="MIT AND Apache-2.0",
+            identifier="mixed-from-file",
+            matches=matches,
+            detection_count=3,
+            file_regions=[
+                {"path": "LICENSE", "start_line": 1, "end_line": 1},
+                {"path": "setup.py", "start_line": 5, "end_line": 5},
+            ],
+        )
+
+        url = reverse(
+            "license_detail",
+            args=[self.project1.slug, license_detection.identifier],
+        )
+        response = self.client.get(url)
+
+        self.assertContains(response, "Matches by file")
+        self.assertContains(response, "LICENSE")
+        self.assertContains(response, "setup.py")
+        self.assertContains(response, "License: MIT")
+        self.assertContains(response, "Apache-2.0")
+        self.assertNotContains(response, "No match text is available for this file region.")
+
+    def test_scanpipe_views_license_detection_details_view_match_texts_no_file_regions(self):
+        matches = [
+            {
+                "score": 100.0,
+                "start_line": 1,
+                "end_line": 1,
+                "matched_length": 3,
+                "match_coverage": 100.0,
+                "matcher": "1-spdx-id",
+                "license_expression": "isc",
+                "rule_identifier": "isc_99.RULE",
+                "matched_text": "ISC",
+                "from_file": None,
+            }
+        ]
+        license_detection = DiscoveredLicense.objects.create(
+            project=self.project1,
+            license_expression="isc",
+            license_expression_spdx="ISC",
+            identifier="isc-no-regions",
+            matches=matches,
+            file_regions=[],
+        )
+
+        url = reverse(
+            "license_detail",
+            args=[self.project1.slug, license_detection.identifier],
+        )
+        response = self.client.get(url)
+
+        self.assertContains(response, "Matches by file")
+        self.assertContains(response, "ISC")
+        self.assertContains(response, "No origin resource path")
+        self.assertNotContains(response, "No match text is available for this file region.")
+
     def test_scanpipe_views_resource_details_view_inlines_detection_match_texts(self):
         license_detections = [
             {

scanpipe/views.py

@@ -2548,12 +2548,18 @@ def get_file_match_groups(self):
         matches_by_file = self.get_matches_by_file(self.object.matches)
         file_match_groups = []
 
+        null_from_file_matches = matches_by_file.pop("", [])
+
         for file_region in self.object.file_regions:
             path = file_region.get("path") or ""
+            matches = matches_by_file.pop(path, [])
+            if not matches and null_from_file_matches:
+                matches = null_from_file_matches
+
             file_match_groups.append(
                 {
                     "file_region": file_region,
-                    "matches": matches_by_file.pop(path, []),
+                    "matches": matches,
                 }
             )
 
@@ -2565,6 +2571,14 @@ def get_file_match_groups(self):
                 }
             )
 
+        if not file_match_groups and null_from_file_matches:
+            file_match_groups.append(
+                {
+                    "file_region": {},
+                    "matches": null_from_file_matches,
+                }
+            )
+
         return file_match_groups
 
     def get_context_data(self, **kwargs):