test(rest): assert scheme routing and widen the full-stack test's build coverage

Author: plusplusjiajia

src/iceberg/resolving_file_io.h

@@ -45,6 +45,11 @@ namespace iceberg {
 /// from FileIORegistry with this FileIO's properties and cached. Vended
 /// credentials are forwarded in full to every resolved FileIO that supports
 /// them; each applies the prefixes it understands and ignores the rest.
+///
+/// Lazy resolution is internally synchronized, so file operations may run
+/// concurrently. Credentials are not: install them before sharing the instance,
+/// since credentials() hands out a reference that SetStorageCredentials
+/// replaces.
 class ICEBERG_EXPORT ResolvingFileIO final : public FileIO,
                                              public SupportsStorageCredentials {
  public:

src/iceberg/test/CMakeLists.txt

@@ -297,7 +297,7 @@ if(ICEBERG_BUILD_REST)
     add_test(NAME ${test_name} COMMAND ${test_name})
   endfunction()
 
-  if(ICEBERG_S3 AND ICEBERG_BUILD_BUNDLE)
+  if(ICEBERG_BUILD_BUNDLE)
     add_rest_iceberg_test(rest_arrow_file_io_test USE_BUNDLE SOURCES
                           rest_arrow_file_io_test.cc)
   endif()

src/iceberg/test/rest_arrow_file_io_test.cc

@@ -71,8 +71,8 @@ TEST_F(RestArrowFileIOTest, ReadsBackWhatItWroteThroughRealLocalFileIO) {
   EXPECT_THAT(io.value()->DeleteFile(path), IsOk());
 }
 
-// A break anywhere in the chain (scheme routing, credential forwarding, or the
-// S3 delegate dropping the `oss://` prefix) shows up as the warning.
+#if ICEBERG_S3_ENABLED
+
 TEST_F(RestArrowFileIOTest, AppliesOssCredentialThroughRealArrowS3FileIO) {
   auto logger = std::make_shared<CapturingLogger>();
   ScopedDefaultLogger scoped(logger);
@@ -82,12 +82,16 @@ TEST_F(RestArrowFileIOTest, AppliesOssCredentialThroughRealArrowS3FileIO) {
                       {{.prefix = "oss://bucket/table", .config = {{"k", "v"}}}});
   ASSERT_THAT(io, IsOk());
 
-  // Opening builds the delegate and applies the credential; the open itself
-  // hits the network, so its result is irrelevant here.
-  std::ignore = io.value()->NewInputFile("oss://bucket/table/data/file.parquet");
+  // Opening builds the delegate and applies the credential. The open itself hits
+  // the network, so only the failure modes before that are asserted: a routing
+  // break surfaces as kNotSupported, and a dropped credential as the warning.
+  auto input = io.value()->NewInputFile("oss://bucket/table/data/file.parquet");
+  EXPECT_THAT(input, ::testing::Not(IsError(ErrorKind::kNotSupported)));
   EXPECT_FALSE(HasWarning(*logger));
 }
 
+#endif  // ICEBERG_S3_ENABLED
+
 }  // namespace
 
 }  // namespace iceberg::rest