HTML encode non-ASCII characters - #61
Merged
Merged
Conversation
Since we set `Content-Transfer-Encoding` to `7bit` for HTML messages, we need to ensure that the passed in HTML is 7 bit safe. This is done by replacing any character with higher bits with their HTML entity encoding. There may be more efficient ways to achieve this, but I've found that working on the string character by character results in the fewest allocations.
Collaborator
Author
|
Hi @aviks, any luck getting this in? |
Owner
|
Yeah, working on fixing the tests. |
Owner
|
Hi, would you be able to rebase this on top of master please? Tests should pass after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we set
Content-Transfer-Encodingto7bitfor HTML messages, we need to ensure that the passed in HTML is 7 bit safe. This is done by replacing any character with higher bits with their HTML entity encoding.There may be more efficient ways to achieve this, but I've found that working on the string character by character results in the fewest allocations.