Fix tests - #62
Merged
Merged
Fix tests#62
Conversation
aviks
changed the title
Owner
Author
|
OK, I've spent a full day on this, and all tests pass on Linux on 1.6. 1.10, 1.12 and nightly. Tests also pass on Windows (with one caveat). However, the mock server does not seem to start on the mac. I don't have easy access to a mac myself, and have really run out of time to spend on this. So unfortunately, I will have to disable testing on the mac for this package. If someone can fix the mac tests, it will be much appreciated. |
Owner
Author
🥳 |
Owner
Author
|
The mock server on linux is still a bit flakey, sometimes the client fails to connect to it. not sure why, but re-running the job seems to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 somewhat independent changes, which taken together should make the tests in this package run successfully to completion once again.
The mock smtp server used in the tests was build on a python standard library called
asynccore. This module was deprecated, and finally removed in python 3.12. This is now replaced by theasynciomodule, and theaiosmtpdpackage.The changes in Break attachments into smaller lines #55 broke the tests. Given the passage of time (and the fact that actions history does not go that far back) I'm not sure why we merged it without the tests passing. Maybe it was broken for some other reason? Anyways, another reason to not merge stuff without successful tests, however tempting that may be 😄