fix(test): isolate config discovery in server-spawning integration tests (#367)

* fix(test): isolate config discovery in server-spawning integration tests

json-rpc-integration and http-bind-host spawn the server with DSN set,
but the server discovers ./dbhub.toml relative to its own cwd and TOML
config outranks the DSN env var. Running from the repo root meant DSN was
silently ignored and the server tried to connect to whatever the local
dbhub.toml named, died, and never bound its port — surfacing as an opaque
"Server did not start within expected time".

Since dbhub.toml is gitignored, this reproduced only for developers who
have one, and never in CI.

Both tests now spawn from an empty temp directory. json-rpc also switches
from `pnpm dev` to invoking tsx directly, matching http-bind-host: `pnpm
dev` starts the Vite frontend alongside the backend under concurrently,
which was unnecessary and leaked a stray dev server on every run.

Also captures server output into the startup failure message, which
previously reported a bare timeout with no indication of the cause, and
adds a guard asserting the DSN config source was used.

json-rpc runtime drops from ~25s to ~1.1s.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(test): clear the SIGKILL timer on normal server exit

json-rpc's afterAll left the 5s kill timer pending when the server exited
cleanly. http-bind-host already clears it; this makes the two consistent
and removes a latent hazard if the pool ever stops force-exiting workers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: tianzhou

src/__tests__/http-bind-host.integration.test.ts

@@ -7,18 +7,27 @@ import os from 'os';
 describe('HTTP bind host integration', () => {
   let serverProcess: ChildProcess | null = null;
   let testDbPath: string;
+  let isolatedCwd: string;
   const testPort = 3002;
   const testHost = '127.0.0.1';
   const startupLogs: string[] = [];
 
   beforeAll(async () => {
     testDbPath = path.join(os.tmpdir(), `bind_host_test_${Date.now()}_${Math.random().toString(36).substr(2, 9)}.db`);
 
+    // The server discovers ./dbhub.toml relative to its own cwd, and TOML config
+    // outranks the DSN env var below. Running from the repo root would therefore
+    // silently ignore DSN and connect to whatever a developer's local (gitignored)
+    // dbhub.toml names, so the server would fail to start on any machine that has
+    // one. Spawn from an empty directory to isolate config discovery.
+    isolatedCwd = fs.mkdtempSync(path.join(os.tmpdir(), 'bind_host_cwd_'));
+
     // Invoke tsx directly via node to avoid pnpm.cmd resolution issues on Windows.
     const tsxCli = path.resolve(process.cwd(), 'node_modules', 'tsx', 'dist', 'cli.mjs');
     const entry = path.resolve(process.cwd(), 'src', 'index.ts');
 
     serverProcess = spawn(process.execPath, [tsxCli, entry, '--transport=http'], {
+      cwd: isolatedCwd,
       env: {
         ...process.env,
         DSN: `sqlite://${testDbPath}`,
@@ -76,13 +85,23 @@ describe('HTTP bind host integration', () => {
     if (testDbPath && fs.existsSync(testDbPath)) {
       fs.unlinkSync(testDbPath);
     }
+    if (isolatedCwd && fs.existsSync(isolatedCwd)) {
+      fs.rmSync(isolatedCwd, { recursive: true, force: true });
+    }
   });
 
   it('responds on the configured host', async () => {
     const res = await fetch(`http://${testHost}:${testPort}/healthz`);
     expect(res.status).toBe(200);
   });
 
+  it('uses the DSN env var, not an ambient dbhub.toml', () => {
+    // Guards the isolated cwd above: if the server is ever spawned from the repo
+    // root again, a developer's local dbhub.toml wins over DSN and this reports
+    // the cause directly instead of an opaque startup timeout.
+    expect(startupLogs.join('')).toContain('Configuration source: environment variable');
+  });
+
   it('logs the actual bound address at startup', () => {
     const allLogs = startupLogs.join('');
     expect(allLogs).toContain(`${testHost}:${testPort}`);

src/__tests__/json-rpc-integration.test.ts

@@ -8,17 +8,33 @@ describe('JSON RPC Integration Tests', () => {
   let serverProcess: ChildProcess | null = null;
   let testDbPath: string;
   let baseUrl: string;
+  let isolatedCwd: string;
   const testPort = 3001;
+  const startupLogs: string[] = [];
 
   beforeAll(async () => {
     // Create a temporary SQLite database file
     const tempDir = os.tmpdir();
     testDbPath = path.join(tempDir, `json_rpc_test_${Date.now()}_${Math.random().toString(36).substr(2, 9)}.db`);
-    
+
+    // The server discovers ./dbhub.toml relative to its own cwd, and TOML config
+    // outranks the DSN env var below. Running from the repo root would therefore
+    // silently ignore DSN and connect to whatever a developer's local (gitignored)
+    // dbhub.toml names, so the server would fail to start on any machine that has
+    // one. Spawn from an empty directory to isolate config discovery.
+    isolatedCwd = fs.mkdtempSync(path.join(tempDir, 'json_rpc_cwd_'));
+
     baseUrl = `http://localhost:${testPort}`;
-    
+
+    // Invoke tsx directly via node rather than `pnpm dev`: `pnpm dev` runs the
+    // backend and the Vite frontend under `concurrently`, and the frontend is both
+    // unnecessary here and leaked a stray dev server on every run.
+    const tsxCli = path.resolve(process.cwd(), 'node_modules', 'tsx', 'dist', 'cli.mjs');
+    const entry = path.resolve(process.cwd(), 'src', 'index.ts');
+
     // Start the server as a child process
-    serverProcess = spawn('pnpm', ['dev'], {
+    serverProcess = spawn(process.execPath, [tsxCli, entry, '--transport=http'], {
+      cwd: isolatedCwd,
       env: {
         ...process.env,
         DSN: `sqlite://${testDbPath}`,
@@ -29,13 +45,15 @@ describe('JSON RPC Integration Tests', () => {
       stdio: 'pipe'
     });
 
-    // Handle server output
+    // Handle server output. Retained for the failure message below: without the
+    // server's own logs, a startup failure surfaces only as a timeout with no
+    // indication of the cause.
     serverProcess.stdout?.on('data', (data) => {
-      console.log(`Server stdout: ${data}`);
+      startupLogs.push(data.toString());
     });
 
     serverProcess.stderr?.on('data', (data) => {
-      console.error(`Server stderr: ${data}`);
+      startupLogs.push(data.toString());
     });
 
     // Wait for server to start up
@@ -65,7 +83,7 @@ describe('JSON RPC Integration Tests', () => {
     }
 
     if (!serverReady) {
-      throw new Error('Server did not start within expected time');
+      throw new Error(`Server did not start within expected time. Logs:\n${startupLogs.join('')}`);
     }
 
     // Create test tables and data via HTTP request
@@ -104,17 +122,22 @@ describe('JSON RPC Integration Tests', () => {
       serverProcess.kill('SIGTERM');
 
       // Wait for process to exit
-      await new Promise((resolve) => {
+      await new Promise<void>((resolve) => {
         if (serverProcess) {
-          serverProcess.on('exit', resolve);
-          setTimeout(() => {
+          // Without clearing this on normal exit, the pending timer keeps
+          // the Vitest process alive until the 5s tail elapses.
+          const killTimeout = setTimeout(() => {
             if (serverProcess && !serverProcess.killed) {
               serverProcess.kill('SIGKILL');
             }
-            resolve(void 0);
+            resolve();
           }, 5000);
+          serverProcess.on('exit', () => {
+            clearTimeout(killTimeout);
+            resolve();
+          });
         } else {
-          resolve(void 0);
+          resolve();
         }
       });
     }
@@ -123,6 +146,11 @@ describe('JSON RPC Integration Tests', () => {
     if (testDbPath && fs.existsSync(testDbPath)) {
       fs.unlinkSync(testDbPath);
     }
+
+    // Clean up the isolated working directory
+    if (isolatedCwd && fs.existsSync(isolatedCwd)) {
+      fs.rmSync(isolatedCwd, { recursive: true, force: true });
+    }
   });
 
   async function makeJsonRpcCall(method: string, params: any): Promise<any> {
@@ -151,6 +179,13 @@ describe('JSON RPC Integration Tests', () => {
     return await response.json();
   }
 
+  it('uses the DSN env var, not an ambient dbhub.toml', () => {
+    // Guards the isolated cwd above: if the server is ever spawned from the repo
+    // root again, a developer's local dbhub.toml wins over DSN and this reports
+    // the cause directly instead of an opaque startup timeout.
+    expect(startupLogs.join('')).toContain('Configuration source: environment variable');
+  });
+
   describe('execute_sql JSON RPC calls', () => {
     it('should execute a simple SELECT query successfully', async () => {
       const response = await makeJsonRpcCall('execute_sql', {