Repository navigation
Commit 82d917b
authored
RFC0055 Identity-Aware Routing (#4910)
* Add allowed_sources support for mTLS app-to-app routing
- Add app_to_app_mtls_routing feature flag (default: false)
- Add allowed_sources to RouteOptionsMessage with validation
- Validate allowed_sources structure (apps/spaces/orgs arrays, any boolean)
- Validate that app/space/org GUIDs exist in database
- Enforce mutual exclusivity of 'any' with apps/spaces/orgs lists
* Add unit tests for allowed_sources validation
Tests cover:
- Feature flag disabled: allowed_sources rejected as unknown field
- Structure validation: object type, valid keys, array types, boolean any
- any exclusivity: cannot combine any:true with apps/spaces/orgs lists
- GUID existence validation: apps, spaces, orgs must exist in database
- Combined options: allowed_sources works with loadbalancing
* Fix allowed_sources validation to handle symbol keys
Rails parses JSON with symbol keys, but validation was comparing
against string keys. Add normalized_allowed_sources helper to
transform keys to strings for consistent comparison.
* Rename allowed_sources to mtls_allowed_sources for clarity
Rename the route options field from allowed_sources to
mtls_allowed_sources for better clarity about its purpose
in mTLS app-to-app routing.
Updates RouteOptionsMessage to use the new field name in:
- Allowed keys registration
- Feature flag gating
- Validation methods
- All related tests
* Refactor mTLS route options to RFC-0027 compliant flat format
Change from nested mtls_allowed_sources object to flat options:
- mtls_allowed_apps: comma-separated app GUIDs (string)
- mtls_allowed_spaces: comma-separated space GUIDs (string)
- mtls_allowed_orgs: comma-separated org GUIDs (string)
- mtls_allow_any: boolean (true/false)
This complies with RFC-0027 which requires route options to only use
numbers, strings, and boolean values (no nested objects or arrays).
* Implement RFC domain-scoped mTLS routing with /v3/access_rules API
Replace POC route-options-based mTLS implementation with RFC-compliant architecture:
Domain model changes:
- Add enforce_access_rules (boolean) and access_rules_scope (any/org/space) to domains
- Fields are immutable after domain creation
- Update DomainCreateMessage, DomainPresenter, and DomainCreate action
Access Rules resource:
- New /v3/access_rules API with full CRUD operations
- RouteAccessRule model with guid, name, selector, route_id
- Selector format: cf:app:<uuid>, cf:space:<uuid>, cf:org:<uuid>, or cf:any
- Enforce cf:any exclusivity and per-route name/selector uniqueness
- Space Developer can manage rules for routes in their space
Diego sync path:
- Inject access_scope and access_rules into route options for GoRouter
- Filter internal mTLS keys (access_scope, access_rules) from public /v3/routes API
- Add access_rules to eager load to avoid N+1 queries
Tests:
- Unit tests for AccessRuleCreateMessage (selector validation, cf:any rules)
- Request specs for /v3/access_rules CRUD (create, show, list, delete, metadata update)
- Updated domain_create_message_spec for enforce_access_rules validation
- Updated routing_info_spec to verify mTLS options injection
- Updated route_presenter_spec to verify internal keys are filtered
Remove POC artifacts:
- Remove app_to_app_mtls_routing feature flag
- Remove mtls_allowed_* keys from route_options_message
* Fix access_rules_controller permissions query
- Replace non-existent readable_space_scoped_space_guids_query with proper subquery
- Use readable_space_scoped_spaces_query for non-global readers
- Handle global readers separately with all routes
* Add automatic Diego sync callbacks to RouteAccessRule
- Add after_create and after_destroy callbacks to touch associated processes
- Updates process.updated_at to trigger Diego ProcessesSync immediately
- Eliminates 30-second wait for access rule changes to propagate to GoRouter
- Add comprehensive unit tests for callbacks and validations
- Ensure RouteAccessRule model is loaded in app/models.rb
This enables automatic synchronization of access rules to Diego/GoRouter
within seconds instead of requiring manual app restarts or waiting for
the next sync cycle.
* Implement include=selector_resource for /v3/access_rules endpoint
- Add include parameter support to AccessRulesListMessage
- Refactor IncludeAccessRuleSelectorResourceDecorator to match RFC format:
- Return separate arrays for apps, spaces, organizations instead of selector_resources
- Include full resource details using appropriate presenters
- Batch resource fetching by type with eager loading
- Auto-deduplicate resources
- Gracefully handle stale/missing resources
- Wire up decorator to AccessRulesController
- Add comprehensive request specs for include=selector_resource
Fixes: uninitialized constant error by adding proper require statement
* Add space_guids filtering to /v3/access_rules endpoint
Implement space-based filtering for access rules endpoint to enable
querying all access rules within a given space using ?space_guids=<guid>
query parameter.
Changes:
- Add space_guids to AccessRulesListMessage with array validation
- Implement space filtering in AccessRulesController#build_dataset
- Add comprehensive unit tests for AccessRulesListMessage
- Add request specs for single/multiple space filtering and combinations
- Follow existing CAPI patterns for space_guids filtering
The filter joins through the routes table to filter access rules by
the space_id of their associated routes.
* Implement include=route for /v3/access_rules endpoint
Add support for including route resources when listing access rules
via the ?include=route query parameter.
Changes:
- Create IncludeAccessRuleRouteDecorator to handle route inclusion
- Wire up decorator in AccessRulesController
- Add comprehensive request specs for include=route
- Test single/multiple routes, uniqueness, and combining with selector_resource
- Follow existing CAPI decorator patterns for resource inclusion
The decorator fetches and presents Route resources referenced by the
access rules, adding them to the 'included' section of the response.
* Remove name field from access rules, add read-only relationships per RFC updates
Update /v3/access_rules API to align with latest RFC changes:
- Remove 'name' field from RouteAccessRule model and API
- Add database migration to drop name column and unique index
- Use labels/annotations for metadata instead of name field
- Add read-only relationships (app, space, organization) to responses
extracted from selector (cf:app:X, cf:space:X, cf:org:X, cf:any)
- Replace 'names' filter with 'guids' filter
- Add 'selector_resource_guids' filter for text-match against selectors
- Update include support: add individual app, space, organization
(in addition to existing selector_resource and route)
- Remove name-based uniqueness validation (keep selector uniqueness)
- Update all tests to remove name references
Breaking changes:
- POST /v3/access_rules no longer accepts 'name' field
- GET /v3/access_rules responses no longer include 'name' field
- Filter parameter 'names' removed, use 'guids' instead
- Access rule responses now include app/space/organization relationships
* Add metadata support to RouteAccessRule model
- Create RouteAccessRuleLabelModel and RouteAccessRuleAnnotationModel
- Add one_to_many relationships for labels and annotations to RouteAccessRule
- Add database migrations for route_access_rule_labels and route_access_rule_annotations tables
- Fixes: undefined method 'labels' error in AccessRulePresenter
This enables metadata (labels/annotations) support for access rules,
required by the RFC changes that removed the 'name' field in favor
of using labels/annotations for metadata storage.
* Fix class loading for RouteAccessRule metadata models
Add require statements for RouteAccessRuleLabelModel and
RouteAccessRuleAnnotationModel to app/models.rb.
Rails autoloading is disabled for app/** so all models must be
explicitly required. This fixes the error:
uninitialized constant VCAP::CloudController::RouteAccessRuleLabelModel
* Add validation to prevent access rules on internal domains per RFC
Per RFC requirement (line 246-247):
Access rules cannot be created for routes on internal domains
(domains created with --internal). Internal routes use container-to-container
networking and bypass GoRouter entirely, so GoRouter cannot enforce
access rules.
Changes:
- Add validation in AccessRulesController#create to reject access rules
on internal domains with 422 status
- Add test coverage for internal domain validation
- Error message explains why: internal domains bypass GoRouter
* Consolidate access rules migrations, fix RuboCop offenses, and clean up tests
- Collapse 4 migrations into 1 consolidated migration (20260407100001) that
creates route_access_rules, route_access_rule_labels, and
route_access_rule_annotations tables
- Remove name field from access rules per RFC updates
- Fix all RuboCop offenses: Style/CollectionQuerying (.count > 0 -> .any?),
Migration/AddConstraintName (primary_key :id, name: :id),
Metrics/BlockLength, Metrics/CyclomaticComplexity, and others
- Add stale resource detection in presenter (null data for deleted resources)
- Extract controller methods to reduce complexity
- Use relative class names within VCAP::CloudController module
- Fix test shadowing of rack-test app method (let(:app) -> let(:frontend_app))
- Fix Sequel validation assertion style (.include(:presence) not strings)
* Fix race condition, double join, LIKE injection, N+1 queries, and domain API surface in access rules
- Wrap create action in transaction with FOR UPDATE lock to prevent
concurrent inserts from violating cf:any exclusivity constraints
- Rescue Sequel::UniqueConstraintViolation to return 422 instead of 500
- Join routes table at most once when both route_guids and space_guids
filters are requested, preventing ambiguous column references
- Escape LIKE metacharacters (% and _) in selector_resource_guids filter
- Replace deprecated routes__column syntax with Sequel[:routes][:column]
- Remove per-row DB existence checks in AccessRulePresenter to eliminate
N+1 queries; relationship GUIDs are now included directly from selector
- Only include enforce_access_rules and access_rules_scope in domain
responses when enforce_access_rules is true
* Fix incomplete LIKE metacharacter escaping (CodeQL rb/incomplete-sanitization)
Escape backslash characters before % and _ in selector_resource_guids
LIKE filtering to prevent backslash-based injection.
* Add tests for LIKE metacharacter escaping (backslash, underscore)
Expand selector_resource_guids filtering tests to cover all three
LIKE metacharacters: %, _, and backslash.
* Fix MySQL key length limit in metadata table migration
Annotations table used key VARCHAR(1000) with a unique index on
(resource_guid, key), totaling 5020 bytes in utf8mb4 — exceeding
MySQL's 3072-byte max key length.
Align with codebase convention established in migration
20240102150000: use key_name VARCHAR(63) with a three-column unique
index on (resource_guid, key_prefix, key_name). Also add NOT NULL
default '' to key_prefix on both labels and annotations tables.
* Fix routing_info_spec: remove nonexistent name field from RouteAccessRule
RouteAccessRule does not have a name column. The test was passing
name: to create(), triggering Sequel::MassAssignmentRestriction.
* Fix route presenter regression: include options: {} when empty
The INTERNAL_ROUTE_OPTIONS filtering change incorrectly suppressed
the options key entirely when public_options was empty. The original
behavior includes options whenever route.options is not nil, even
when the hash is empty.
* Fix CI failures: route presenter options logic and domain V2 serialization
Route presenter: preserve original behavior where options: {} is
included for routes with empty options, but omit options when all
keys are internal-only (access_scope, access_rules).
Domain model: remove enforce_access_rules and access_rules_scope
from V2 export/import_attributes — these are V3-only fields exposed
through the domain presenter, not the legacy V2 API.
* Rebrand: access rules → route policies, selector → source
Complete terminology shift for identity-aware routing RFC:
- Access Rules → Route Policies (API, models, tables)
- Selector → Source (field names, query params)
- Domain fields: enforce_access_rules → enforce_route_policies
- Domain fields: access_rules_scope → route_policies_scope
- Route options: access_scope → route_policy_scope
- Route options: access_rules → route_policy_sources
Aligns with existing CF 'network policies' terminology and C2C
network policy convention (source → destination).
Database migrations replaced (no production DBs affected).
67 files changed, 602 insertions(+), 600 deletions(-)
* Fix test failures: complete terminology rebrand in specs
- Fix require statement in route_policy_create_message_spec.rb
- Update all test references from old to new terminology:
* selectors → sources
* selector_resource_guids → source_guids
* selector_resource → source (in include parameters)
* enforce_access_rules → enforce_route_policies
* access_rules_scope → route_policies_scope
* route_access_rules → route_policies (table name)
- Fix Rubocop indentation in route_policies_list_message_spec.rb
Addresses CI/CD test failures in PR #4910.
* Fix routing_info_spec: use enforce_route_policies field names
* Fix domain_create_message_spec: use enforce_route_policies field names
* Fix route_policies_spec: use 'Source' terminology and 'sources' query param
- Line 206: expect error message to include 'Source' (not 'Selector')
- Line 292: use query param ?sources= (not ?selectors=)
- Line 344: use query param ?sources= in combined filter test
These complete the terminology rebrand from 'selector' to 'source' in
the route policies context per RFC be8d74c1.
* Revert: restore label_selector (was incorrectly renamed to label_source)
During the selector→source rebrand for route policies, we accidentally
renamed 'label_selector' to 'label_source' across the test suite.
This was WRONG because:
- label_selector is a standard Cloud Controller query parameter for
filtering resources by labels/annotations (e.g., ?label_selector=env=prod)
- It is used across many endpoints: apps, packages, orgs, buildpacks, etc.
- It has nothing to do with route policies or the terminology rebrand
- The overly broad sed command caught it by mistake
This commit restores label_selector to its correct name, fixing 13+ test
failures caused by the regression.
* Add API documentation for Route Policies
- Add comprehensive Route Policies API documentation
- Create, get, list, update, delete endpoints
- Complete filtering documentation (guids, route_guids, space_guids, sources, source_guids)
- Include parameter documentation (route, app, space, organization, source)
- Practical use case examples for common scenarios
- Validation rules and permission matrices
- Update Domains documentation
- Add enforce_route_policies and route_policies_scope fields
- Document immutability of enforcement settings
- Add example for creating identity-aware domain
- Update index.html.md to include route_policies resources
Route policies enable identity-aware routing by controlling which
Cloud Foundry apps, spaces, or organizations can access routes on
domains with enforce_route_policies enabled. GoRouter enforces these
access controls using mutual TLS (mTLS).
* Add include support to route policies show endpoint
Address review feedback: the show action now supports the same include
parameters (source, route) as the list endpoint, allowing clients to
sideload related resources in a single request.
* Remove devbox configuration files from branch
These files are for local development only and should not be
part of the upstream PR.
* Address philippthun's review feedback
- Remove unused BaseAccess subclass (no v2 endpoint)
- Remove without_guid_generation on association (int PK)
- Use ProcessRouteHandler.notify_backend_of_route_update in
db.after_commit instead of touching process updated_at
- Rewrite migration using VCAP::Migration.common for consistent
table layout (Timestamp with defaults, proper indexes)
- Extract RoutePolicyCreate action from controller
- Remove manual guid/created_at/updated_at assignment in create
- Reuse find_and_authorize_route in update/destroy
- Pass locked policies to validate_source_exclusivity
- Remove unnecessary 'source != cf:any' check
- Fix comment order to match code
* Rename add_mtls_options to add_route_policy_options and refactor structure
Adopt philippthun's suggested pattern: build a fresh hash and merge
at the end instead of duplicating info['options']. Also rename the
method and variable from mtls_ prefix to route_policy_ to align with
current terminology.
* Limit route policy includes to 'route' and 'source' only
Remove 'app', 'space', and 'organization' as separate include values.
The 'source' include already resolves the underlying app/space/org
from the source string (e.g. cf:app:<guid>), making the individual
keywords redundant and confusing — especially since space_guids
filters by route space while include=space would include the source
space.
* Prevent enforce_route_policies on internal and router_group domains
Internal domains bypass GoRouter entirely (using container-to-container
networking), so GoRouter cannot enforce route policies. Similarly, TCP
router groups do not support mTLS policy enforcement.
Add validation to DomainCreateMessage#mutually_exclusive_fields to
reject these invalid combinations at domain creation time.
* Fix RuboCop offenses in domain_create_message and route_policies_list_message_spec
* Add include=route_policies support on routes endpoints
Add IncludeRoutePoliciesDecorator to allow consumers to include
route_policies when fetching routes via GET /v3/routes and
GET /v3/routes/:guid with ?include=route_policies.
The decorator batch-loads all route policies for the routes in the
result set to avoid N+1 queries.
* Fix race condition in RoutePolicyCreate: lock parent route row
SELECT ... FOR UPDATE on an empty route_policies table acquires no row
locks. Two concurrent creates on the same route_id both read [] and
both pass cf:any exclusivity validation, leaving the route with cf:any
and cf:app:<guid> policies simultaneously.
Lock the parent Route row instead — it always exists, so concurrent
transactions serialize at the database level regardless of how many
policies currently exist.
Add spec/unit/actions/route_policy_create_spec.rb to cover the action
and document the locking behaviour.
* Fix missing permission filter in IncludeRoutePolicySourceDecorator
Without a permission check, a space developer could write a route policy
with a source GUID from another org and receive the full AppPresenter /
SpacePresenter / OrganizationPresenter payload via ?include=source.
Follow the IncludeSpaceDecorator pattern: build a Permissions queryer
from SecurityContext.current_user and gate each fetch on
readable_space_guids_query (for apps and spaces) and
readable_org_guids_query (for orgs). Global readers skip the filter.
Add spec/unit/decorators/include_route_policy_source_decorator_spec.rb.
* Enforce route_policies_scope boundary in RoutePolicyCreate
Reject cf:org:<guid> sources on domains with route_policies_scope: 'space'.
cf:any is allowed at all scopes — GoRouter contextualizes it to the domain
boundary at request time (e.g. 'any app in this space' on a space-scoped domain).
* Fix org manager visibility in route policies index
Switch readable_space_scoped_spaces_query to readable_spaces_query in
build_dataset. The former uses SPACE_ROLES which excludes ORG_MANAGER;
the latter uses ROLES_FOR_SPACE_READING which includes it, consistent
with how show gates access via can_read_from_space?.
Add permissions for list/show endpoint shared examples covering all
roles to spec/request/route_policies_spec.rb.
* Split route_policies.source into source_type + source_guid columns
Store source_type ('app'|'space'|'org'|'any') and source_guid (UUID
or '' for cf:any) as separate columns. Add virtual source getter/setter
on RoutePolicy so all existing callers remain unchanged. Use empty
string instead of NULL for source_guid to preserve DB unique constraint
on (route_id, source_type, source_guid).
* Guard RoutePolicy source= setter against nil and malformed input
Use source_guid.to_s.empty? in getter to avoid NoMethodError when
source_guid is nil in test contexts. Move describe 'columns' block
to top level.
* Add unit tests for RoutePolicy source virtual getter/setter
Covers all four source types for getter, all four types for setter,
plus nil-input guard and malformed-input guard.
* Add column-level assertions to RoutePolicyCreate spec
* Update route policy filters to use source_type/source_guid columns
sources filter: parse composite string and apply two-column WHERE.
source_guids filter: exact match on source_guid column (no more LIKE).
* Use source_type/source_guid directly in IncludeRoutePolicySourceDecorator
Eliminates the SOURCE_REGEX constant and match/parse pattern.
* Use source_type/source_guid directly in RoutePolicyPresenter
Remove regex match from build_relationships. Add presenter unit spec
covering all four source types (app, space, org, any).
* Fix RuboCop offenses
* Grant org auditors read access to route policies
Route policies are policies on routes; org auditors can already read
routes via ROLES_FOR_ROUTE_READING. Use the same role set for route
policy reads so the permission model is consistent. Org billing managers
remain unable to read route policies (consistent with routes).
Adds can_read_route_policy_from_space? and
readable_route_policies_spaces_query to Permissions.
* Restore .envrc to main branch version
* Add audit events for route policy create/update/delete
Records audit.route_policy.create, .update, and .delete events
via RoutePolicyEventRepository, consistent with the audit.route.*
pattern used by routes.
* Add label_selector support to route policies list
- RoutePoliciesListMessage now inherits from MetadataListMessage,
which auto-registers :label_selector and wires
LabelSelectorRequirementValidator
- build_dataset in RoutePoliciesController delegates to
LabelSelectorQueryGenerator when a selector is requested
* Fix RoutePolicy.create calls using non-hex fake GUIDs via virtual source= setter
The source= setter parses 'cf:app:GUID' using [0-9a-f-]+ regex (hex UUIDs
only). Fake GUIDs like 'app-guid-1' contain non-hex chars so the regex
fails to match, leaving source_type nil and failing the presence validation.
Fix by calling .create with source_type:/source_guid: directly, bypassing
the virtual setter in the 6 affected test fixtures.
* Register route_policy audit events in event_types_spec and docs
* Validate sources format in RoutePoliciesListMessage
Move SOURCE_REGEX to RoutePolicy model — natural home for a format
constant shared across messages. Update RoutePolicyCreateMessage to
reference RoutePolicy::SOURCE_REGEX.
Add sources_format_valid validator to RoutePoliciesListMessage that
checks each element against RoutePolicy::SOURCE_REGEX, along with
validates :sources, array: true, allow_nil: true.
Add tests covering nil, all four valid formats, fully invalid, and
mixed valid/invalid arrays.
* Guard against route deletion race in RoutePolicyCreate
If the route is deleted between the controller fetch and the
transaction lock, Route.for_update.first returns nil. Add an
explicit guard to raise Error with a clear message rather than
letting RoutePolicy.create fail with a foreign key violation.
Add a test covering the deleted-route scenario using the same
route-relation spy pattern as the concurrent-creates test.
* Drop empty source_not_cf_any_with_others method
Remove the registered validator and its empty method body.
Move the explanatory comment inline next to validate :source_format_valid.
* Fix source_guids filter description in route policies list docs
The old description referenced text-matching against the full source
string. Now that source is stored as separate source_type + source_guid
columns, source_guids filters by exact match on the GUID portion only.
* Fix destroy action: destroy before recording audit event
Swap order so route_policy.destroy is called before
record_route_policy_delete, ensuring no audit event is recorded
if the destroy fails.
Add request spec to verify no event is recorded when destroy raises.
* Use can_read_route_policy_from_space? in find_and_authorize_route_for_policy
Consistent with the show action (line 40) which already uses the
dedicated permission check rather than the generic can_read_from_space?.
* Use add_unique_constraint for labels/annotations unique indexes
Switch from inline index(..., unique: true) to alter_table +
add_unique_constraint following the convention established in
20240102150000_add_annotation_label_uniqueness, with names
route_policy_labels_unique and route_policy_annotations_unique.
* Mark route policies feature as experimental in docs1 parent da9ddd9 commit 82d917b
61 files changed
Lines changed: 3808 additions & 18 deletions
File tree
- app
- actions
- controllers/v3
- decorators
- messages
- models/runtime
- presenters/v3
- repositories
- config
- db/migrations
- docs/v3/source
- includes
- api_resources
- resources
- audit_events
- domains
- route_policies
- routes
- lib/cloud_controller
- diego/protocol
- spec
- request
- unit
- actions
- decorators
- lib/cloud_controller
- diego/protocol
- messages
- models/runtime
- presenters/v3
- repositories
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
| 68 | + | |
66 | 69 | | |
67 | 70 | | |
68 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
0 commit comments