Skip to content

Commit 9d2993a

Browse files
committed
iop/watermark: skip invalidation when disabled
The watermark module receives metadata and tag change signals in every darkroom session, even when it is disabled. Refreshing its pixelpipe cache and clearing mipmap_hash then causes unnecessary work and repeated thumbnail generation. Ignore both signals while the module is disabled. This keeps enabled watermark text responsive to metadata changes while avoiding invalidation for other images. Regression from #22103, unreleased.
1 parent ab5f4c6 commit 9d2993a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/iop/watermark.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,13 +1405,13 @@ static void _metadata_changed(gpointer instance,
14051405
const int type,
14061406
dt_iop_module_t *self)
14071407
{
1408-
if(self) _invalidate_tag_meta(self);
1408+
if(self && self->enabled) _invalidate_tag_meta(self);
14091409
}
14101410

14111411
static void _tag_changed(gpointer instance,
14121412
dt_iop_module_t *self)
14131413
{
1414-
if(self) _invalidate_tag_meta(self);
1414+
if(self && self->enabled) _invalidate_tag_meta(self);
14151415
}
14161416

14171417
void gui_init(dt_iop_module_t *self)

0 commit comments

Comments
 (0)