Skip to content

Commit fc422b1

Browse files
committed
FX: install pnpm and test xdebug/pcov extensions
- Install pnpm globally via npm in the fx image - Add Makefile test cases for pnpm and the xdebug/pcov PHP extensions to the fx test suite
1 parent 6d8e1fe commit fc422b1

3 files changed

Lines changed: 13 additions & 2 deletions

File tree

Makefile

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ test-all:
3535

3636
.PHONY: test-fx
3737
test-fx: DOCKER_TAG=fx
38-
test-fx: _testcase-node _testcase-deno _testcase-bun _testcase-php _testcase-python _testcase-golang _testcase-common
38+
test-fx: _testcase-node _testcase-pnpm _testcase-deno _testcase-bun _testcase-php _testcase-php-coverage _testcase-python _testcase-golang _testcase-common
3939

4040
.PHONY: test-php
4141
test-php: DOCKER_TAG=php
@@ -67,11 +67,20 @@ _testcase-deno:
6767
_testcase-bun:
6868
$(TEST_RUN) bun --version
6969

70+
.PHONY: _testcase-pnpm
71+
_testcase-pnpm:
72+
$(TEST_RUN) pnpm --version
73+
7074
.PHONY: _testcase-php
7175
_testcase-php:
7276
$(TEST_RUN) php --version
7377
$(TEST_RUN) composer --version
7478

79+
.PHONY: _testcase-php-coverage
80+
_testcase-php-coverage:
81+
$(TEST_RUN) php -r "exit(extension_loaded('xdebug') ? 0 : 1);"
82+
$(TEST_RUN) php -r "exit(extension_loaded('pcov') ? 0 : 1);"
83+
7584
.PHONY: _testcase-python
7685
_testcase-python:
7786
$(TEST_RUN) python3 --version

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ So you’re replacing the plain enterprise base with the same foundation plus ou
3939

4040
**Base:** `codercom/enterprise-base:ubuntu` (Ubuntu, `coder` user, usual Coder expectations).
4141

42-
- **Node.js** (includes **npm**) via Nodesource (**Node 22** in this image).
42+
- **Node.js** (includes **npm**) via Nodesource (**Node 22** in this image), plus **pnpm**.
4343
- **Shell:** `mc`, `nano`, `tmux`.
4444
- **PHP 8.5** (Ondrej PPA): CLI + common extensions (curl, intl, mbstring, mysql, pgsql, redis, xml, zip, imagick, etc.).
4545
- **Composer**, **GitHub CLI (`gh`)**, **GitLab CLI (`glab`)**.

fx/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ RUN \
9090
chmod 0755 /usr/local/bin/opencode && \
9191
# NPM: CODEX, COPILOT #######################################################
9292
npm install -g @openai/codex @github/copilot && \
93+
# PNPM ######################################################################
94+
npm install -g pnpm && \
9395
# AGENT-BROWSER ##############################################################
9496
npm install -g agent-browser && \
9597
runuser -u coder -- agent-browser install && \

0 commit comments

Comments
 (0)