Skip to content

Commit 024f958

Browse files
Reverseanclaude
andcommitted
feat: add @editorjs/header as a git submodule
Submodule keeps header in its own repo while letting it pull model/sdk/dom-adapters as workspace:^ deps during development, without needing them published first. CI now checks out submodules on every job that runs yarn install, since it needs packages/tools/header populated to resolve the workspace. The base-coverage action re-checks out the PR's base ref mid-job to compare coverage; git leaves an already-initialized submodule's working directory in place when switching to a ref that doesn't have that path, and the packages/tools/* workspace glob then treats the orphaned header directory as a workspace against a lockfile that has none of its dependencies, so yarn's immutable install fails. Deinit submodules before that checkout so the base-ref install only sees what's actually on that ref. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149uKB589N5qx9zXYLPVSQw
1 parent 80a29ed commit 024f958

12 files changed

Lines changed: 969 additions & 13 deletions

File tree

.github/actions/base-coverage/action.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ inputs:
1111
runs:
1212
using: "composite"
1313
steps:
14+
- name: Deinit submodules before comparing against base ref
15+
shell: bash
16+
run: git submodule deinit --all -f
17+
1418
- name: Checkout base ref
1519
uses: actions/checkout@v6
1620
with:

.github/workflows/bold.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
with:
16+
submodules: true
1517
- name: Run ESLint check
1618
uses: ./.github/actions/lint
1719
with:
@@ -21,6 +23,8 @@ jobs:
2123
runs-on: ubuntu-latest
2224
steps:
2325
- uses: actions/checkout@v6
26+
with:
27+
submodules: true
2428
- name: Build the package
2529
uses: ./.github/actions/build
2630
with:

.github/workflows/italic.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
with:
16+
submodules: true
1517
- name: Run ESLint check
1618
uses: ./.github/actions/lint
1719
with:
@@ -21,6 +23,8 @@ jobs:
2123
runs-on: ubuntu-latest
2224
steps:
2325
- uses: actions/checkout@v6
26+
with:
27+
submodules: true
2428
- name: Build the package
2529
uses: ./.github/actions/build
2630
with:

.github/workflows/link.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
with:
16+
submodules: true
1517
- name: Run ESLint check
1618
uses: ./.github/actions/lint
1719
with:
@@ -21,6 +23,8 @@ jobs:
2123
runs-on: ubuntu-latest
2224
steps:
2325
- uses: actions/checkout@v6
26+
with:
27+
submodules: true
2428
- name: Build the package
2529
uses: ./.github/actions/build
2630
with:

.github/workflows/npm-publish.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ jobs:
2121
runs-on: ubuntu-latest
2222
steps:
2323
- uses: actions/checkout@v6
24+
with:
25+
submodules: true
2426

2527
- uses: actions/setup-node@v6
2628
with:

.github/workflows/package-check.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
- uses: actions/checkout@v6
3535
with:
3636
fetch-depth: 0
37+
submodules: true
3738

3839
- name: Determine if CI should run
3940
id: check
@@ -57,6 +58,8 @@ jobs:
5758
runs-on: ubuntu-latest
5859
steps:
5960
- uses: actions/checkout@v6
61+
with:
62+
submodules: true
6063
- name: Run ESLint check
6164
uses: ./.github/actions/lint
6265
with:
@@ -68,6 +71,8 @@ jobs:
6871
runs-on: ubuntu-latest
6972
steps:
7073
- uses: actions/checkout@v6
74+
with:
75+
submodules: true
7176

7277
- name: Run unit tests
7378
uses: ./.github/actions/unit-tests
@@ -81,6 +86,8 @@ jobs:
8186
runs-on: ubuntu-latest
8287
steps:
8388
- uses: actions/checkout@v6
89+
with:
90+
submodules: true
8491
- name: Build the package
8592
uses: ./.github/actions/build
8693
with:
@@ -92,6 +99,8 @@ jobs:
9299
runs-on: ubuntu-latest
93100
steps:
94101
- uses: actions/checkout@v6
102+
with:
103+
submodules: true
95104

96105
- name: Run mutation tests for changed files
97106
if: ${{ github.event_name == 'pull_request' }}

.github/workflows/paragraph.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
with:
16+
submodules: true
1517
- name: Run ESLint check
1618
uses: ./.github/actions/lint
1719
with:
@@ -21,6 +23,8 @@ jobs:
2123
runs-on: ubuntu-latest
2224
steps:
2325
- uses: actions/checkout@v6
26+
with:
27+
submodules: true
2428
- name: Build the package
2529
uses: ./.github/actions/build
2630
with:

.github/workflows/playground.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
with:
16+
submodules: true
1517
- name: Run ESLint check
1618
uses: ./.github/actions/lint
1719
with:
@@ -21,6 +23,8 @@ jobs:
2123
runs-on: ubuntu-latest
2224
steps:
2325
- uses: actions/checkout@v6
26+
with:
27+
submodules: true
2428
- name: Build the package
2529
uses: ./.github/actions/build
2630
with:

.github/workflows/sdk.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@v6
14+
with:
15+
submodules: true
1416
- name: Run ESLint check
1517
uses: ./.github/actions/lint
1618
with:
@@ -20,6 +22,8 @@ jobs:
2022
runs-on: ubuntu-latest
2123
steps:
2224
- uses: actions/checkout@v6
25+
with:
26+
submodules: true
2327
- name: Build the package
2428
uses: ./.github/actions/build
2529
with:

.gitmodules

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[submodule "packages/tools/header"]
2+
path = packages/tools/header
3+
url = https://github.com/editor-js/header.git
4+
branch = feat/sdk-v3-migration

0 commit comments

Comments
 (0)