You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LocalExtensions.cs:53-54 maps generic "Shift" to "LShift", silently resolving side ambiguity by picking left. Worse: the manifest (SendUser32KeyboardKey.json) has no left/right variants for Control or Alt at all (only generic "Control"/"Ctrl" line 646/652, "Alt" line 598) — side identity can't even be expressed for those two modifiers today.
Proposed change
Stop silently resolving generic "Shift" to "LShift" (require the caller to specify a side, or track side from the actual captured event upstream), and add LControl/RControl/LAlt/RAlt to the manifest's key vocabulary so side identity can be expressed and preserved end-to-end.
Problem
LocalExtensions.cs:53-54maps generic"Shift"to"LShift", silently resolving side ambiguity by picking left. Worse: the manifest (SendUser32KeyboardKey.json) has no left/right variants for Control or Alt at all (only generic"Control"/"Ctrl"line 646/652,"Alt"line 598) — side identity can't even be expressed for those two modifiers today.Proposed change
Stop silently resolving generic
"Shift"to"LShift"(require the caller to specify a side, or track side from the actual captured event upstream), and addLControl/RControl/LAlt/RAltto the manifest's key vocabulary so side identity can be expressed and preserved end-to-end.Compatibility requirements
Acceptance criteria