Skip to content

contributing.rst

Latest commit

 

History

History
136 lines (84 loc) · 3.63 KB

contributing.rst

File metadata and controls

136 lines (84 loc) · 3.63 KB
Raw
github_url:https://github.com/gopro/OpenGoPro/tree/main/demos/python/sdk_wireless_camera_control

Contributing

Contributions are welcome, are greatly appreciated, and credit will always be given.

Types of Contributions

Report Bugs

Report bugs at https://github.com/gopro/OpenGoPro/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

Open GoPro could always use more documentation, whether as part of the official Open GoPro docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/gopro/OpenGoPro/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.

Get Started!

Ready to contribute? Here's how to set up Open GoPro for local development.

Minimal Requirements

  • Python (>= 3.11, < 3.15)
  • Poetry : Needed to install dependencies / development tasks

Additional Optional Requirements:

  • protoc to build protobuf python files from .proto's
  • graphviz to build diagrams in sphinx

Steps

  1. Fork the Open GoPro repo on GitHub.

  2. Clone your fork locally:

    $ git clone git@github.com:your_name_here/OpenGoPro.git

  3. Enter the sdk_wireless_camera_control directory:

    $ cd OpenGoPro/demos/python/sdk_wireless_camera_control

  4. Create a branch for local development, originating from the main branch:

    $ git checkout -b name-of-your-bugfix-or-feature main

  5. Install your local copy into a virtual environment.

    $ poetry install --all-extras

  6. Make your changes locally. When you're done making changes, check that your changes are:

    • formatted
    • pass type checking
    • pass linting
    • pass unit tests
    • pass docstring tests
    $ poetry run poe all

    Note that each of these checks can be run individually. For more information, see:

    $ poetry run poe --help

  7. Commit your changes, push your branch to GitHub, and submit a pull request into main. Once the Pull Request is made, Github Actions will test the changes across multiple OS's and Python versions.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. If the pull request adds functionality, the docs should be updated. The docs can be build locally via:

    $ poetry run poe docs

  2. Modify the CHANGELOG.rst.

  3. The pull request should work for Python 3.11 - 3.14 on the following platforms:

    • Windows 10, version 16299 (Fall Creators Update) and greater
    • Linux distributions with BlueZ >= 5.43
    • OS X / macOS >= 10.11

  4. Feel free to add your name as a contributor to the AUTHORS.rst file!