conflict when used in multiplayer but only on client

[gisanka]

Would like to use OCDheim while playing multiplayer on a vanilla (but client-side-mod-friendly) server but it gives an error on connect:

[BRTPOB]

Came here to open a report for the same thing.

[java-devil]

Relevant context:
https://www.reddit.com/r/valheim/comments/1tycj8s/comment/oqahsy3/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

I am not saying "no" as this was already often asked in the past, but for the time being work on core functionalities seems to have a higher return on effort ;)

[gisanka]

It sounds like it would make things easier (like in removing complication) if you carve out things like the additional build pieces (and other things which might not be vanilla compatible) into another mod.

That way you gain a vanilla compatible client side mod with I guess most of the functionality and a little add-on mod which is only useable in servers with it (which could depend on the main mod if you need stuff from there so you don't need to maintain things twice).

And enabling/disabling parts of the functionality, making keybinds configureable, ..., would a be a nice thing anyway...

[java-devil]

Yes and no ;)

Config Files and Feature Flags are probably coming in the next non-bugfix release (v0.3.0).

The problem is that unlike what you would probably assume there is quite a bit happening back and forth between the server and the client while terraforming and that's basically half of the mod's functionality (snap pointing on the other hand is implemented entirely client-side and this could be released relatively easily).

The real effort wouldn't then be the code structure. That's easy. The real effort would be testing and thinking which subset of the terraforming functionality:

• works out of the box
• can be replaced with a client-side only implementation
• needs to be blocked entirely if the mod is not present on the server-side

If I could outsource the testing by releasing a beta version then we are home. But I don't think that OCDheim has the audience anymore ;)

[java-devil]

https://drive.google.com/file/d/1DPDsL0v8_2xJ4F9zczOOoK07lSjTZMiM/view?usp=sharing

@ZeroxAsuka this is a much bigger ask if you (or anybody else) were interested Man. Professional QA grade stuff.

The attached mod has the client side safe guards removed. Stuff WILL surely break and WILL surely misbehave. What I could use is somebody going over all the functionalities of the mod on a server with OCDheim NOT installed and writing down all the discrepancies in expected behavior compared to a situation were the mod is installed on both sides.

[BRTPOB]

I have no problem spinning up a different server without it installed and doing that, it'll just have to wait until Friday, if you're ok with that.

[ZeroxAsuka]

https://drive.google.com/file/d/1DPDsL0v8_2xJ4F9zczOOoK07lSjTZMiM/view?usp=sharing

@ZeroxAsuka this is a much bigger ask if you (or anybody else) were interested Man. Professional QA grade stuff.

The attached mod has the client side safe guards removed. Stuff WILL surely break and WILL surely misbehave. What I could use is somebody going over all the functionalities of the mod on a server with OCDheim NOT installed and writing down all the discrepancies in expected behavior compared to a situation were the mod is installed on both sides.

Got a chance to mess around with this on my server.
Since I have not had much time to play or play with the mod I do not think I was able to test everything but here is what I have so far.
Server does not have Jotunn or OCDheim loaded, I am running OCDheim/Jotunn on my PC, and third PC is running vanilla.

• Grid Mode seems to work as intended, no issues that I could see
• Precision Mode throws Unity log error IF Grid Mode is not Enabled, otherwise seems to function properly (First error message posted below. They are all different but all follow the same structure as this one.)
• Additional Build Pieces can be built but nothing shows up for unmodded client, as expected. Can also be crafted directly on top of unmodded client character with no pieces highlighted red or warning messages. Unmodded client can walk through them as if nothing was there.
• Hoe's Grid Mode, Raise, Level, Undo Terrain Modifications, Paths, and Stone Paths all seem to work as intended, did not get any errors while using any of the features.
• Cultivator's Grid Mode, Cultivate, Grass, and Precision Seed Mode all seem to work as intended. As far as precision mode on the cultivator goes, I did not see any errors, granted I did not spend as much time on this as I did on the Hammer's precision mode.
• Vertical Stacking seems to work, no issues popped up for me

[Error  : Unity Log] InvalidOperationException:   Collection was modified; enumeration operation may not execute.
Stack trace:
System.Collections.Generic.List`1+Enumerator[T].MoveNextRare   () (at <73ac12a12f9a4ebca156b41ddce95fbe>:0)
System.Collections.Generic.List`1+Enumerator[T].MoveNext   () (at <73ac12a12f9a4ebca156b41ddce95fbe>:0)
OCDheim.SnapTree.FindNearestSnapNodeTo   (System.Collections.Generic.List`1[T] buildPieceSnapNodes,   System.Collections.Generic.List`1[T] neighborPieces, System.Func`2[T,TResult]   isDesired) (at <22edda11e78342c6996d9c46ee2a2e79>:0)
OCDheim.SnapTree.FindNearestSuperiorPrecisionSnapNodeCombinationOf   (Piece buildPiece, System.Collections.Generic.List`1[T] neighbourPieces) (at   <22edda11e78342c6996d9c46ee2a2e79>:0)
OCDheim.PrecisePieceSnapper.SnapInternally   (Piece buildPiece, System.Collections.Generic.List`1[T] neighbourPieces) (at   <22edda11e78342c6996d9c46ee2a2e79>:0)
OCDheim.PrecisePieceSnapper.SnapToNeighbourPiece   (Piece buildPiece) (at <22edda11e78342c6996d9c46ee2a2e79>:0)
OCDheim.PrecisePieceSnapper.SnapBuildPiece   () (at <22edda11e78342c6996d9c46ee2a2e79>:0)
(wrapper dynamic-method)   Player.DMD<Player::UpdatePlacementGhost>(Player,bool)
(wrapper dynamic-method)   Player.DMD<Player::LateUpdate>(Player)

On another note, these style messages popped up fairly frequently while playing.
Not too sure of the relevance, but I was not interacting with any of the items when these messages would pop up.

[Warning:OCDheim.Logger]   EXPECTED SIDES on Piece '$piece_hearth' (871.58, 31.72, 95.69): 6, ACTUAL   SIDES: 11
[Warning:OCDheim.Logger]   EXPECTED SIDES on Piece '$piece_darkwoodroofocorner' (880.08, 40.72, 107.69):   1, ACTUAL SIDES: 0
[Warning:OCDheim.Logger]   EXPECTED SIDES on Piece '$piece_oven' (-1289.29, 35.64, 229.04): 6, ACTUAL   SIDES: 8

Edit: If I may ask, what exactly was expected to break with server not running mod and client running it??

[java-devil]

This is actually very suprising as you can imagine.

I would mostly expect Terraforming to fall apart entirely for one reason or another.

I still suspect that the result is not entirely the same under closer scrutiny. Could you check if:

• You able to Raise Ground by +0.25 (or anything < 1.0) using the mouse scroll?
• The severity of the Hoe/Cultivator drops off to the edges as opposed to the server-side mod?
• Road / Pave / Cultivate / Grass effects are quite a bit off from the GUI indication of the effect?
• Are you sure Remove Terrain Modifications work at all? I seem to remember considerable server-side logic went into this.

The Precision Mode error is equally unexpected, but something I am very likely able to fix.

The EXPECTED SIDES warnings are irrelevant in this context. This is something I "should" eventually resolve to improve how additional Snap Points are derived.

All in all this is surprisingly good news. Much better than expected. Are you sure you didn't load the mod server-side by accident? xD

By the looks of things it seems we should be able to have a client-side only mod with only slightly limited functionality.

[ZeroxAsuka]

I have a thing for making island bases, the one I made on this current world I miscalculated how far I could actually go after hitting the 8 unit raise limit with water during storms still able to cover the ground so I had to shift/downsize the project.
That left a huge amount of terraforming beneath the sea that I could not pickaxe down enough for boats to go through without taking damage.
Also have a dock on the island that is below sea level but is raised enough to where we can recover items when disassembling boat but again ground level is right at that spot where it is too deep to use any tools most of the time because of the water. I had attempted to make it deeper with the pickaxe and wait for the sea to go down but all that ended up doing was me making a couple low/high spots that the vanilla hoe could not quite level out.

Any way with all that said, I "extensively" tested the hoe's functionailtiy by FINALLY being able to fix the above issues.

• For the dock I was using the Hoe's raise ground with mouth wheel and was finally able to fill in those stupid low spots that I could not get just right before. I also used this function on other areas on the island to fix low spots and level out bumps.
• Forgive me here, but what do you mean by this, "The severity of the Hoe/Cultivator drops off to the edges as opposed to the server-side mod?" ?? Like give me an instance where I would see this happening if you could.
• The Road and Pave functions worked for me just like they looked in the propaganda video. For the Cultivate and Grass functions, other than the yellow square not seeming to center onto the world grid but centered around the world grid, they also worked just like the Road and Pave functions, nice clean lines aligned to the yellow square.
• I went HAM on removing a huge amount of terrain modifications I had made below sea level around the island. Again, nice clean sharp lines between where I removed terrain modification and where I had raised the ground to initially build the island.

Lol I am sure I had the mod removed from the server. I went back after all this and read the server logs to be sure and neither Jotunn or OCDheim were loaded.
Which is why I asked at the end what exactly was supposed to break since other than the additional build pieces I saw no issues.

If I have some time today, I'll wipe Valheim entirely from the server and reinstall completely vanilla then try all this again. I do not think the other mods I run would interfere but hey maybe.
Those mods being:

• FiresGhettoNetworking
• AzumattsLogKeeper
• ServersideQOL

[gisanka]

I hope I have a chance over the weekend to test the version. I was using https://thunderstore.io/c/valheim/p/Searica/AdvancedTerrainModifiers/ before but some functionality felt quite cheesy/overpowered to me so I would prefer to ditch it for something which "just" adds more precision.
And as that other mod is working on a vanilla server I was hoping that most precision-tooling things from OCDheim will work, too.

[java-devil]

@gisanka that mod actually seems to be originally based on the code of OCDheim xDDD

Which also increases the probability that we should be home. Yes.