Skip to content

Commit cc37e88

Browse files
authored
Allow setting Temporal's targetQueueSize to 0. (#7113)
* Allow setting targetQueueSize to 0. 0 is a valid setting, no need to require >= 1. Signed-off-by: Rob Holland <rob@temporal.io> * Revert accidental whitespace change. Signed-off-by: Rob Holland <rob@temporal.io> --------- Signed-off-by: Rob Holland <rob@temporal.io>
1 parent c38fe48 commit cc37e88

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
110110
- **Kafka Scaler**: Fix throwing error when using sasl=none ([#7061](https://github.com/kedacore/keda/issues/7061))
111111
- **Pulsar Scaler**: Resolve nil pointer dereference in Pulsar scaler redirect handling ([#7024](https://github.com/kedacore/keda/issues/7024))
112112
- **RabbitMQ Scaler**: Fix incorrect URL encoding in RabbitMQ vhosts containing %2f ([#6963](https://github.com/kedacore/keda/issues/6963))
113+
- **Temporal Scaler**: Allow setting 0 for targetQueueSize ([#7113](https://github.com/kedacore/keda/pull/7113))
113114

114115
### Deprecations
115116

‎pkg/scalers/temporal_scaler.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ type temporalMetadata struct {
5858
}
5959

6060
func (a *temporalMetadata) Validate() error {
61-
if a.TargetQueueSize <= 0 {
61+
if a.TargetQueueSize < 0 {
6262
return fmt.Errorf("targetQueueSize must be a positive number")
6363
}
6464
if a.ActivationTargetQueueSize < 0 {

0 commit comments

Comments
 (0)