Skip to content

Commit cf508d7

Browse files
authored
feat: bump controller-runtime version (#7081)
* feat: update controller-runtime dep to v0.20.0 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: bump controller-runtime version Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: add changelog Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: update gengo dependency Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: update clientset Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: update clientset Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: bump golang to 1.24 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: bump golangci-lint to 1.64.8 in order to support golang 1.24 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: clientset code generator Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: remove not needed files Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * fix: lints Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * fix: lints Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * fix: permissions Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> * feat: bump prometheus version Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com> --------- Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>
1 parent 37b966a commit cf508d7

2,729 files changed

Lines changed: 158320 additions & 75989 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ New deprecation(s):
125125

126126
### Other
127127

128+
- **General**: Bump Controller Runtime version to v0.20.4 ([#7081](https://github.com/kedacore/keda/pull/7081))
128129
- **General**: Fix several typos ([#6909](https://github.com/kedacore/keda/pull/6909))
129130
- **General**: Replace deprecated webhook.Validator with webhook.CustomValidator ([#6660](https://github.com/kedacore/keda/issues/6660))
130131
- **MSSQL Scaler**: Refactor MS SQL e2e test ([#3401](https://github.com/kedacore/keda/issues/3401))

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ COSIGN_FLAGS ?= -y -a GIT_HASH=${GIT_COMMIT} -a GIT_VERSION=${VERSION} -a BUILD_
4747
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
4848
ENVTEST_K8S_VERSION = 1.32
4949

50-
GOLANGCI_VERSION:=1.63.4
50+
GOLANGCI_VERSION:=1.64.8
5151

5252
# Setting SHELL to bash allows bash commands to be executed by recipes.
5353
# This is a requirement for 'setup-envtest.sh' in the test target.

‎config/crd/bases/keda.sh_scaledjobs.yaml‎

Lines changed: 276 additions & 163 deletions
Large diffs are not rendered by default.

‎config/crd/bases/keda.sh_scaledobjects.yaml‎

Lines changed: 42 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ spec:
9797
policies:
9898
description: |-
9999
policies is a list of potential scaling polices which can be used during scaling.
100-
At least one policy must be specified, otherwise the HPAScalingRules will be discarded as invalid
100+
If not set, use the default values:
101+
- For scale up: allow doubling the number of pods, or an absolute change of 4 pods in a 15s window.
102+
- For scale down: allow all pods to be removed in a 15s window.
101103
items:
102104
description: HPAScalingPolicy is a single policy
103105
which must hold true for a specified past interval.
@@ -140,6 +142,24 @@ spec:
140142
- For scale down: 300 (i.e. the stabilization window is 300 seconds long).
141143
format: int32
142144
type: integer
145+
tolerance:
146+
anyOf:
147+
- type: integer
148+
- type: string
149+
description: |-
150+
tolerance is the tolerance on the ratio between the current and desired
151+
metric value under which no updates are made to the desired number of
152+
replicas (e.g. 0.01 for 1%). Must be greater than or equal to zero. If not
153+
set, the default cluster-wide tolerance is applied (by default 10%).
154+
155+
For example, if autoscaling is configured with a memory consumption target of 100Mi,
156+
and scale-down and scale-up tolerances of 5% and 1% respectively, scaling will be
157+
triggered when the actual consumption falls below 95Mi or exceeds 101Mi.
158+
159+
This is an alpha field and requires enabling the HPAConfigurableTolerance
160+
feature gate.
161+
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
162+
x-kubernetes-int-or-string: true
143163
type: object
144164
scaleUp:
145165
description: |-
@@ -152,7 +172,9 @@ spec:
152172
policies:
153173
description: |-
154174
policies is a list of potential scaling polices which can be used during scaling.
155-
At least one policy must be specified, otherwise the HPAScalingRules will be discarded as invalid
175+
If not set, use the default values:
176+
- For scale up: allow doubling the number of pods, or an absolute change of 4 pods in a 15s window.
177+
- For scale down: allow all pods to be removed in a 15s window.
156178
items:
157179
description: HPAScalingPolicy is a single policy
158180
which must hold true for a specified past interval.
@@ -195,6 +217,24 @@ spec:
195217
- For scale down: 300 (i.e. the stabilization window is 300 seconds long).
196218
format: int32
197219
type: integer
220+
tolerance:
221+
anyOf:
222+
- type: integer
223+
- type: string
224+
description: |-
225+
tolerance is the tolerance on the ratio between the current and desired
226+
metric value under which no updates are made to the desired number of
227+
replicas (e.g. 0.01 for 1%). Must be greater than or equal to zero. If not
228+
set, the default cluster-wide tolerance is applied (by default 10%).
229+
230+
For example, if autoscaling is configured with a memory consumption target of 100Mi,
231+
and scale-down and scale-up tolerances of 5% and 1% respectively, scaling will be
232+
triggered when the actual consumption falls below 95Mi or exceeds 101Mi.
233+
234+
This is an alpha field and requires enabling the HPAConfigurableTolerance
235+
feature gate.
236+
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
237+
x-kubernetes-int-or-string: true
198238
type: object
199239
type: object
200240
name:

‎controllers/keda/scaledobject_controller_test.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,8 @@ var _ = Describe("ScaledObjectController", func() {
394394
err = k8sClient.Get(context.Background(), types.NamespacedName{Name: soName, Namespace: "default"}, so)
395395
Expect(err).ToNot(HaveOccurred())
396396
so.Status.HpaName = ""
397-
return k8sClient.Status().Update(context.Background(), so)
397+
so.Generation++ // since the reconcile ignores status update we force generation change to trigger reconcile
398+
return k8sClient.Update(context.Background(), so)
398399
}).ShouldNot(HaveOccurred())
399400

400401
// Wait until the hpaName is updated in the scaled object.

0 commit comments

Comments
 (0)