GCP Pub/Sub: remove the deprecated subscriptionSize setting (#8266)

* GCP Pub/Sub: remove the deprecated subscriptionSize setting

The setting has been rejected at parse time since v2.20 and is scheduled
for code cleanup in v2.22 (#7720). Drop the field and regenerate the
scalers schema. A trigger that still sets subscriptionSize is now treated
like any other unknown key, so the unit case that expected an error now
expects it to be ignored. The SubscriptionSize default for mode stays.

Signed-off-by: Sai Ram <4089996+vjsairam@users.noreply.github.com>

* GCP Pub/Sub: drop the subscriptionSize test case

Removing the row shifts the test table, so the two FromEnv resource-name
cases now point at indices 23 and 24.

Signed-off-by: Sai Ram <4089996+vjsairam@users.noreply.github.com>

---------

Signed-off-by: Sai Ram <4089996+vjsairam@users.noreply.github.com>
Co-authored-by: Sai Ram <4089996+vjsairam@users.noreply.github.com>

Author: vjsairam

pkg/scalers/gcp_pubsub_scaler.go

@@ -37,7 +37,6 @@ type pubsubScaler struct {
 }
 
 type pubsubMetadata struct {
-	SubscriptionSize int           `keda:"name=subscriptionSize, order=triggerMetadata, optional, deprecated=The 'subscriptionSize' setting is DEPRECATED and is removed in v2.20 - Use 'mode' and 'value' instead"`
 	Mode             string        `keda:"name=mode, order=triggerMetadata, default=SubscriptionSize"`
 	Value            float64       `keda:"name=value, order=triggerMetadata, default=10, deprecatedAnnounce=This scaler is deprecated. More info -> 'https://keda.sh/blog/2025-09-15-gcp-deprecations'"`
 	ActivationValue  float64       `keda:"name=activationValue, order=triggerMetadata, default=0"`

pkg/scalers/gcp_pubsub_scaler_test.go

@@ -77,8 +77,6 @@ var testPubSubMetadata = []parsePubSubMetadataTestData{
 	{"both subscriptionName and topicName present", nil, map[string]string{"subscriptionName": "mysubscription", "topicName": "mytopic", "value": "7", "credentialsFromEnv": "SAMPLE_CREDS"}, true},
 	// both subscriptionName and topicName missing
 	{"both subscriptionName and topicName missing", nil, map[string]string{"value": "7", "credentialsFromEnv": "SAMPLE_CREDS"}, true},
-	// deprecated subscriptionSize errors
-	{"deprecated subscriptionSize errors", nil, map[string]string{"subscriptionName": "mysubscription", "subscriptionSize": "7", "credentialsFromEnv": "SAMPLE_CREDS"}, true},
 	// both subscriptionName and subscriptionNameFromEnv present
 	{"both subscriptionName and subscriptionNameFromEnv present", nil, map[string]string{"subscriptionName": "mysubscription", "subscriptionNameFromEnv": "MY_ENV_SUBSCRIPTION", "value": "7", "credentialsFromEnv": "SAMPLE_CREDS"}, false},
 	// both topicName and topicNameFromEnv present
@@ -101,8 +99,8 @@ var gcpResourceNameTests = []gcpPubSubSubscription{
 	{&testPubSubMetadata[12], 1, "projects/myproject/mysubscription", ""},
 	{&testPubSubMetadata[17], 1, "mytopic", "myproject"},
 	{&testPubSubMetadata[18], 1, "projects/myproject/mytopic", ""},
-	{&testPubSubMetadata[24], 1, "myEnvSubscription", ""},
-	{&testPubSubMetadata[25], 1, "myEnvTopic", ""},
+	{&testPubSubMetadata[23], 1, "myEnvSubscription", ""},
+	{&testPubSubMetadata[24], 1, "myEnvTopic", ""},
 }
 
 var gcpSubscriptionDefaults = []gcpPubSubSubscription{

schema/generated/scalers-schema.json

@@ -5549,13 +5549,6 @@
         {
             "type": "gcp-pubsub",
             "parameters": [
-                {
-                    "name": "subscriptionSize",
-                    "type": "string",
-                    "optional": true,
-                    "deprecated": "The 'subscriptionSize' setting is DEPRECATED and is removed in v2.20 - Use 'mode' and 'value' instead",
-                    "metadataVariableReadable": true
-                },
                 {
                     "name": "mode",
                     "type": "string",

schema/generated/scalers-schema.yaml

@@ -3707,11 +3707,6 @@ scalers:
           metadataVariableReadable: true
     - type: gcp-pubsub
       parameters:
-        - name: subscriptionSize
-          type: string
-          optional: true
-          deprecated: The 'subscriptionSize' setting is DEPRECATED and is removed in v2.20 - Use 'mode' and 'value' instead
-          metadataVariableReadable: true
         - name: mode
           type: string
           default: SubscriptionSize