Commit 545459d
deps: bump macula-go to v0.7.1 for the client_stream/bidi reply-loss fix
v0.6.2 -> v0.7.1. Verified against macula-go's own commits before taking
it. The one that matters here is dcaddff: RecvFrame's read loop appended
Stream.Read's returned bytes to its buffer, then returned any
accompanying error without re-checking whether those bytes now completed
a frame. io.Reader's contract permits a Read call to return its final
chunk together with io.EOF in the same call (quic-go's Stream.Read does
this in practice), so a cleanly-completed reply with FIN on the last
STREAM frame got its fully-delivered bytes thrown away instead of
decoded, surfacing as a bogus "read stream: EOF" instead of the reply.
Live-verified upstream against production: 6/20 -> 30/30, then a clean
20/20. Bundled in the same commit: Handle.CloseSend now also closes the
underlying QUIC stream's send side (previously only sent the app-level
STREAM_END frame), and FrameStream.stream is now a narrow interface
instead of the concrete *quic.Stream, enabling a real regression test.
v0.7.0 (folded into this bump) added opt-in station discovery via
hecate_stations and a doc fix; neither touches this SDK.
macula-php was checked for whether this is actually reachable: cabi/
stream.go exposes stream.Open (frame.Bidi included) and Handle.SendData/
Recv/CloseSend directly across the C ABI to PHP callers, exactly the
client_stream/bidi path dcaddff fixes. Every PHP-side stream call was
exposed to the intermittent reply-loss bug.
No transitive dependency changes -- the fix is internal to macula-go
(connection/frame_stream.go, stream/stream.go). go vet clean, the
native libmacula.so rebuilds clean with -buildmode=c-shared, composer
validate clean, 24/24 offline PHPUnit tests green, and the live suite
(composer test:live, against station-de-frankfurt) passes clean too --
no flakiness hit this time, so nothing to bisect.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QmtYoyo1AgfjvV4EnEfuFB1 parent 05a7f67 commit 545459d
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments