Skip to content

Commit 5638972

Browse files
bmehta001Copilot
andcommitted
Keep TPM cancellation comment wording
Restore the existing Issue 388 wording in the remaining cancellation comment while keeping the duplicated helper comment removed. Files changed: - lib/tpm/TransmissionPolicyManager.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 4a8cc9d commit 5638972

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

lib/tpm/TransmissionPolicyManager.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,8 +513,9 @@ namespace MAT_NS_BEGIN {
513513
}
514514
bool result = m_scheduledUpload.Cancel(waitTime.count());
515515

516-
// Cancel may still fail if the task runs past the wait timeout;
517-
// stronger task lifetime guarantees are tracked by Issue 388.
516+
// TODO: There is a potential for upload tasks to not be canceled, especially if they aren't waited for.
517+
// We either need a stronger guarantee here (could impact SDK performance), or a mechanism to
518+
// ensure those tasks are canceled when the log manager is destroyed. Issue 388
518519
if (result)
519520
{
520521
LOCKGUARD(m_scheduledUploadMutex);

0 commit comments

Comments
 (0)