fix(bulkcopy): correct Arrow-steering message (tuples/Row, add __arrow_c_array__); use non-localhost host in unit-test conn strings

Author: gargsaumya

mssql_python/cursor.py

@@ -3026,9 +3026,10 @@ def bulkcopy(
         # silently re-routing or failing deep inside the tuple validator.
         if self._looks_like_arrow_source(data):
             raise TypeError(
-                "bulkcopy() expects an iterable of row tuples/lists. "
+                "bulkcopy() expects an iterable of row tuples or Row objects. "
                 "For pyarrow.Table / RecordBatch / RecordBatchReader / objects "
-                "implementing __arrow_c_stream__, call cursor.bulkcopy_arrow() instead."
+                "implementing __arrow_c_stream__/__arrow_c_array__, call "
+                "cursor.bulkcopy_arrow() instead."
             )
 
         try:

tests/test_024_bulkcopy_arrow.py

@@ -226,7 +226,7 @@ def test_missing_server_raises(self):
 
     def test_sql_auth_keeps_credentials(self):
         cur = _cursor_with_conn(
-            "Server=localhost;Database=testdb;UID=sa;PWD=mypwd", auth_type=None
+            "Server=testhost;Database=testdb;UID=sa;PWD=mypwd", auth_type=None
         )
         ctx = cur._build_pycore_context()
         assert ctx.get("user_name") == "sa"
@@ -352,7 +352,7 @@ class TestBulkcopyArrowDispatch:
     @patch("mssql_python.cursor.logger")
     def test_success_returns_result_and_forwards_args(self, mock_logger):
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=p")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=p")
         module, pyc_cursor, _, _ = _mock_pycore()
         src = pa.table({"a": [1, 2]})
 
@@ -374,7 +374,7 @@ def test_success_returns_result_and_forwards_args(self, mock_logger):
     def test_batch_size_timeout_accept_positional(self, mock_logger):
         """D13: batch_size/timeout are positional-or-keyword (parity with bulkcopy)."""
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=p")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=p")
         module, pyc_cursor, _, _ = _mock_pycore()
         src = pa.table({"a": [1, 2]})
 
@@ -389,7 +389,7 @@ def test_batch_size_timeout_accept_positional(self, mock_logger):
     @patch("mssql_python.cursor.logger")
     def test_sensitive_fields_cleared_after_success(self, mock_logger):
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=secret")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=secret")
         module, _, _, captured = _mock_pycore()
 
         with patch.dict("sys.modules", {"mssql_py_core": module}):
@@ -402,7 +402,7 @@ def test_sensitive_fields_cleared_after_success(self, mock_logger):
     @patch("mssql_python.cursor.logger")
     def test_resources_closed_on_success(self, mock_logger):
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=p")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=p")
         module, pyc_cursor, pyc_conn, _ = _mock_pycore()
 
         with patch.dict("sys.modules", {"mssql_py_core": module}):
@@ -414,7 +414,7 @@ def test_resources_closed_on_success(self, mock_logger):
     @patch("mssql_python.cursor.logger")
     def test_core_exception_is_reraised_and_cleaned_up(self, mock_logger):
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=p")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=p")
         module, pyc_cursor, pyc_conn, captured = _mock_pycore(
             raise_exc=ValueError("boom")
         )
@@ -432,7 +432,7 @@ def test_core_exception_is_reraised_and_cleaned_up(self, mock_logger):
     def test_cleanup_swallows_close_errors(self, mock_logger):
         """A failing resource.close() during teardown must not mask the result."""
         mock_logger.is_debug_enabled = False
-        cur = _cursor_with_conn("Server=localhost;Database=d;UID=sa;PWD=p")
+        cur = _cursor_with_conn("Server=testhost;Database=d;UID=sa;PWD=p")
         module, pyc_cursor, pyc_conn, _ = _mock_pycore()
         pyc_cursor.close.side_effect = RuntimeError("close failed")