Skip to content

Commit 3b97fa7

Browse files
committed
Fix settings & diagnose with embedded distrib
Signed-off-by: sim <git@sgougeon.fr>
1 parent c64faf5 commit 3b97fa7

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

app/src/main/java/com/nextcloud/talk/diagnosis/DiagnosisActivity.kt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ class DiagnosisActivity : BaseActivity() {
8080
lateinit var platformPermissionUtil: PlatformPermissionUtil
8181

8282
private var isGooglePlayServicesAvailable: Boolean = false
83+
private var useEmbeddedDistrib: Boolean = false
8384

8485
private var nUnifiedPushServices = 0
8586
private var offerUnifiedPush: Boolean = false
@@ -108,6 +109,7 @@ class DiagnosisActivity : BaseActivity() {
108109
offerUnifiedPush = nUnifiedPushServices > 0 &&
109110
userManager.users.blockingGet().all { it.hasWebPushCapability }
110111
useUnifiedPush = appPreferences.useUnifiedPush
112+
useEmbeddedDistrib = UnifiedPushUtils.hasEmbeddedDistributor(context) && !useUnifiedPush
111113
unifiedPushService = UnifiedPush.getAckDistributor(this) ?: "N/A"
112114

113115
setContent {
@@ -161,7 +163,9 @@ class DiagnosisActivity : BaseActivity() {
161163
viewState = viewState,
162164
onTestPushClick = { diagnosisViewModel.fetchTestPushResult() },
163165
onDismissDialog = { diagnosisViewModel.dismissDialog() },
164-
showTestPushButton = isGooglePlayServicesAvailable || useUnifiedPush,
166+
showTestPushButton = isGooglePlayServicesAvailable ||
167+
useUnifiedPush ||
168+
useEmbeddedDistrib,
165169
isOnline = isOnline
166170
)
167171
}
@@ -255,7 +259,7 @@ class DiagnosisActivity : BaseActivity() {
255259
value = Build.VERSION.SDK_INT.toString()
256260
)
257261

258-
if (isGooglePlayServicesAvailable) {
262+
if (isGooglePlayServicesAvailable || useEmbeddedDistrib) {
259263
addDiagnosisEntry(
260264
key = context.resources.getString(R.string.nc_diagnosis_gplay_available_title),
261265
value = context.resources.getString(R.string.nc_diagnosis_gplay_available_yes)
@@ -302,7 +306,7 @@ class DiagnosisActivity : BaseActivity() {
302306
value = getStringForBoolean(useUnifiedPush)
303307
)
304308

305-
if (useUnifiedPush) {
309+
if (useUnifiedPush || useEmbeddedDistrib) {
306310
setupAppValuesForPush()
307311
setupAppValuesForUnifiedPush()
308312
} else if (isGooglePlayServicesAvailable) {

app/src/main/java/com/nextcloud/talk/settings/SettingsActivity.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,9 @@ class SettingsActivity :
387387
@SuppressLint("StringFormatInvalid")
388388
@Suppress("LongMethod")
389389
private fun setupNotificationPermissionSettings() {
390-
if (ClosedInterfaceImpl().isGooglePlayServicesAvailable || appPreferences.useUnifiedPush) {
390+
if (ClosedInterfaceImpl().isGooglePlayServicesAvailable ||
391+
appPreferences.useUnifiedPush ||
392+
UnifiedPushUtils.hasEmbeddedDistributor(context)) {
391393
binding.settingsPushOnlyWrapper.visibility = View.VISIBLE
392394
binding.settingsGplayNotAvailable.visibility = View.GONE
393395
binding.settingsPushNotAvailable.visibility = View.GONE

0 commit comments

Comments
 (0)