Skip to content

Commit 518698c

Browse files
committed
src: require watchdog status pointers
Remove the nullptr defaults from Watchdog and SigintWatchdog result parameters. Both watchdogs unconditionally dereference these pointers, so callers must explicitly provide valid status storage. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
1 parent 4a5eb1c commit 518698c

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

‎src/node_watchdog.h‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ enum class SignalPropagation {
4444

4545
class Watchdog {
4646
public:
47-
explicit Watchdog(v8::Isolate* isolate,
48-
uint64_t ms,
49-
bool* timed_out = nullptr);
47+
explicit Watchdog(v8::Isolate* isolate, uint64_t ms, bool* timed_out);
5048
~Watchdog();
5149
v8::Isolate* isolate() { return isolate_; }
5250

@@ -75,8 +73,7 @@ class SigintWatchdogBase {
7573

7674
class SigintWatchdog : public SigintWatchdogBase {
7775
public:
78-
explicit SigintWatchdog(v8::Isolate* isolate,
79-
bool* received_signal = nullptr);
76+
explicit SigintWatchdog(v8::Isolate* isolate, bool* received_signal);
8077
~SigintWatchdog();
8178
v8::Isolate* isolate() { return isolate_; }
8279
SignalPropagation HandleSigint() override;

0 commit comments

Comments
 (0)