fix: re-initialize provider when re-registered on the same domain

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>

Author: jonathannorris

openfeature/provider/_registry.py

@@ -77,14 +77,10 @@ def set_provider(
         with self._lock:
             self._reject_domain_scoped_rebind(provider, domain)
             old_provider = self._providers.get(domain)
-            was_bound_elsewhere = provider is self._default_provider or any(
+            already_bound = provider is self._default_provider or any(
                 p is provider for d, p in self._providers.items() if d != domain
             )
-            was_bound_here = (
-                domain in self._providers and self._providers[domain] is provider
-            )
             self._providers[domain] = provider
-            already_bound = was_bound_elsewhere or was_bound_here
             if not already_bound:
                 needs_init = True
                 self._provider_status[provider] = ProviderStatus.NOT_READY

tests/provider/test_registry.py

@@ -594,6 +594,47 @@ def domain_scoped(self) -> bool:
     )
 
 
+def test_reregistering_same_provider_on_same_domain_reinitializes():
+    registry = ProviderRegistry()
+    provider = Mock()
+    init_count = 0
+
+    def counting_initialize(evaluation_context, domain=None):
+        nonlocal init_count
+        init_count += 1
+
+    provider.initialize.side_effect = counting_initialize
+
+    registry.set_provider("domain", provider, wait_for_init=True)
+    registry.set_provider("domain", provider, wait_for_init=True)
+
+    assert init_count == 2
+
+
+def test_reregistering_same_provider_after_failed_init_retries():
+    registry = ProviderRegistry()
+    provider = Mock()
+    attempts = 0
+
+    def flaky_initialize(evaluation_context, domain=None):
+        nonlocal attempts
+        attempts += 1
+        if attempts == 1:
+            raise ProviderFatalError()
+
+    provider.initialize.side_effect = flaky_initialize
+
+    with pytest.raises(ProviderFatalError):
+        registry.set_provider("domain", provider, wait_for_init=True)
+
+    assert registry.get_provider_status(provider) == ProviderStatus.FATAL
+
+    registry.set_provider("domain", provider, wait_for_init=True)
+
+    assert attempts == 2
+    assert registry.get_provider_status(provider) == ProviderStatus.READY
+
+
 def test_callable_accepts_domain_returns_false_for_uninspectable_callable():
     assert _callable_accepts_domain(object()) is False  # type: ignore[arg-type]