feat: Implement API to GDPR delete users #7447
Janis4411Annotations
6 errors and 2 warnings
|
test
Process completed with exit code 1.
|
|
test:
spec/request/api/internal/users/destroy_spec.rb#L24
DELETE Users API DELETE /api/internal/users with valid token and signature anonymizes the user name to "Deleted User"
Failure/Error:
expect { delete "/api/internal/users/#{user_id}", headers: headers }
.to change { user.reload.name }.to('Deleted User').and change { user.reload.email }.to(nil)
expected result to have changed to "Deleted User", but did not change
...and:
expected result to have changed to nil, but did not change
|
|
test:
spec/request/api/internal/users/destroy_spec.rb#L29
DELETE Users API DELETE /api/internal/users with valid token and signature returns 200 OK
Failure/Error: expect(response).to have_http_status(:ok)
expected the response to have status code :ok (200) but it was :unauthorized (401)
|
|
test:
spec/controllers/api/internal/users_controller_spec.rb#L28
Api::Internal::UsersController authorization before_action :verify_token! returns 401 when Authorization header is missing
Failure/Error: delete :delete, params: {user_id: '123456'}
ActionController::UrlGenerationError:
No route matches {action: "delete", controller: "api/internal/users", host: "www.example.com", user_id: "123456"}
|
|
test:
spec/controllers/api/internal/users_controller_spec.rb#L8
Api::Internal::UsersController authorization before_action :verify_token! calls verify_token! before each action
Failure/Error: delete :delete, params: {user_id: '123456'}
ActionController::UrlGenerationError:
No route matches {action: "delete", controller: "api/internal/users", host: "www.example.com", user_id: "123456"}
|
|
test:
spec/controllers/api/internal/users_controller_spec.rb#L19
Api::Internal::UsersController authorization before_action :verify_token! returns 401 when authorization fails
Failure/Error: delete :delete, params: {user_id: '123456'}
ActionController::UrlGenerationError:
No route matches {action: "delete", controller: "api/internal/users", host: "www.example.com", user_id: "123456"}
|
|
slim-lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lcollins/checkstyle-github-action@v3.1.0. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea, actions/setup-node@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|