Commit efcd23d
committed
Address review: spell out the accepted start_time and end_time literals
@penghuo on #5766: what are the supported literals -- the doc should be clear on it.
Replaced the prose list with a table, one row per form, each with examples. Testing every
candidate against a cluster rather than reading it off the format string turned up two
things the prose had wrong.
`yyyy-MM-dd HH:mm:ss` without milliseconds did not parse, only the `.SSS` form did. PPL
accepts that exact literal in a `where` clause, so a client mirroring its own filter into
these parameters would have got silent non-pruning. Added to the accepted formats, with
the date-only form pinned in TimeBoundsTest alongside it.
Epoch seconds are not accepted and cannot be: a ten-digit number parses as milliseconds,
so it means January 1970 rather than failing. Nothing is pruned, since no index matches
that window, but the doc now says so instead of leaving it to be discovered.
Verified after the change: every listed form prunes, epoch seconds and malformed values
decline.
Signed-off-by: Kai Huang <ahkcs@amazon.com>1 parent 9a5849c commit efcd23d
3 files changed
Lines changed: 23 additions & 2 deletions
File tree
- core/src/test/java/org/opensearch/sql/executor
- docs/user/admin
- opensearch/src/main/java/org/opensearch/sql/opensearch/request
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
239 | 258 | | |
240 | 259 | | |
241 | 260 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
0 commit comments