Skip to content

Commit 625dab7

Browse files
vmorpsclaude
vmorps
and
claude
committed
fix: address PR review feedback — SDK links, Java coordinate, TDF diagram
- Change "JS Quickstart" button to "Quickstart" - Fix Java SDK coordinate to io.opentdf.platform:sdk:<version> - Point SDK card links to package registries (npm, pkg.go.dev, Maven Central) - Update CLI card href to https://opentdf.io/components/cli - Add target="_blank" rel="noopener noreferrer" to external SDK links - Correct TDF diagram nesting per spec (encryptionInformation children, assertions placement) - Add pl12 indent class for deeper diagram nesting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
1 parent 2b54bb9 commit 625dab7

3 files changed

Lines changed: 30 additions & 15 deletions

File tree

‎src/components/landing/DeveloperFirst.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const sdks = [
88
install: "npm install @opentdf/sdk",
99
colorClass: "sdk-js",
1010
icon: "TS",
11-
href: "/sdks",
11+
href: "https://www.npmjs.com/package/@opentdf/sdk",
1212
recommended: true,
1313
},
1414
{
@@ -17,16 +17,16 @@ const sdks = [
1717
install: "go get github.com/opentdf/platform/sdk",
1818
colorClass: "sdk-go",
1919
icon: "Go",
20-
href: "/sdks",
20+
href: "https://pkg.go.dev/github.com/opentdf/platform/sdk",
2121
recommended: false,
2222
},
2323
{
2424
name: "Java SDK",
2525
lang: "Java",
26-
install: "implementation 'io.opentdf:sdk:latest'",
26+
install: "implementation 'io.opentdf.platform:sdk:<version>'",
2727
colorClass: "sdk-java",
2828
icon: "Jv",
29-
href: "/sdks",
29+
href: "https://central.sonatype.com/artifact/io.opentdf.platform/sdk-pom",
3030
recommended: false,
3131
},
3232
{
@@ -36,7 +36,7 @@ const sdks = [
3636
releaseUrl: "https://github.com/opentdf/otdfctl/releases/latest",
3737
colorClass: "sdk-cli",
3838
icon: ">_",
39-
href: "/sdks",
39+
href: "https://opentdf.io/components/cli",
4040
recommended: false,
4141
},
4242
];
@@ -100,7 +100,7 @@ export default function DeveloperFirst() {
100100
{sdk.icon}
101101
</div>
102102
<div>
103-
<a href={sdk.href} className={styles.sdkName}>
103+
<a href={sdk.href} className={styles.sdkName} target="_blank" rel="noopener noreferrer">
104104
{sdk.name}
105105
</a>
106106
<div className={styles.sdkLang}>{sdk.lang}</div>
@@ -143,7 +143,7 @@ export default function DeveloperFirst() {
143143

144144
<div className={styles.ctas}>
145145
<a href="/quickstart" className={`${styles.btn} ${styles.btnPrimary}`}>
146-
JS Quickstart
146+
Quickstart
147147
</a>
148148
<a href="/sdks" className={`${styles.btn} ${styles.btnSecondary}`}>
149149
All SDKs

‎src/components/landing/Standards.module.css‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858

5959
.pl4 { padding-left: 1rem; }
6060
.pl8 { padding-left: 2rem; }
61+
.pl12 { padding-left: 3rem; }
6162

6263
.cFaint { color: #4b5563; font-size: 0.75rem; margin-left: 0.5rem; }
6364
.cFaint2 { color: #4b5563; }

‎src/components/landing/Standards.tsx‎

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,36 +26,50 @@ export default function Standards() {
2626
<div className={styles.diagramBody}>
2727
<div className={styles.diagramRow}>
2828
<span className={styles.cCyan}>┌</span>
29-
<span className={styles.cLight}>TDF Object</span>
29+
<span className={styles.cLight}>TDF</span>
30+
<span className={styles.cFaint}>.tdf zip archive</span>
3031
</div>
3132
<div className={`${styles.diagramRow} ${styles.pl4}`}>
3233
<span className={styles.cCyan}>├─</span>
3334
<span className={styles.cGreen}>manifest.json</span>
34-
<span className={styles.cFaint}>policy + key access</span>
3535
</div>
3636
<div className={`${styles.diagramRow} ${styles.pl8}`}>
3737
<span className={styles.cFaint2}>├─</span>
38-
<span className={styles.cAmber}>encryptionMethod</span>
39-
<span className={styles.cFaint}>AES-256-GCM</span>
38+
<span className={styles.cAmber}>payload</span>
39+
<span className={styles.cFaint}>reference to payload file</span>
4040
</div>
4141
<div className={`${styles.diagramRow} ${styles.pl8}`}>
42+
<span className={styles.cFaint2}>├─</span>
43+
<span className={styles.cAmber}>encryptionInformation</span>
44+
</div>
45+
<div className={`${styles.diagramRow} ${styles.pl12}`}>
4246
<span className={styles.cFaint2}>├─</span>
4347
<span className={styles.cAmber}>keyAccess[]</span>
4448
<span className={styles.cFaint}>wrapped DEK + KAS URL</span>
4549
</div>
46-
<div className={`${styles.diagramRow} ${styles.pl8}`}>
50+
<div className={`${styles.diagramRow} ${styles.pl12}`}>
4751
<span className={styles.cFaint2}>├─</span>
52+
<span className={styles.cAmber}>method</span>
53+
<span className={styles.cFaint}>AES-256-GCM</span>
54+
</div>
55+
<div className={`${styles.diagramRow} ${styles.pl12}`}>
56+
<span className={styles.cFaint2}>├─</span>
57+
<span className={styles.cAmber}>integrityInformation</span>
58+
<span className={styles.cFaint}>hashes / signatures</span>
59+
</div>
60+
<div className={`${styles.diagramRow} ${styles.pl12}`}>
61+
<span className={styles.cFaint2}>└─</span>
4862
<span className={styles.cAmber}>policy</span>
49-
<span className={styles.cFaint}>ABAC attributes</span>
63+
<span className={styles.cFaint}>ABAC attributes (Base64)</span>
5064
</div>
5165
<div className={`${styles.diagramRow} ${styles.pl8}`}>
5266
<span className={styles.cFaint2}>└─</span>
5367
<span className={styles.cAmber}>assertions[]</span>
54-
<span className={styles.cFaint}>signed bindings</span>
68+
<span className={styles.cFaint}>optional signed statements</span>
5569
</div>
5670
<div className={`${styles.diagramRow} ${styles.pl4}`}>
5771
<span className={styles.cCyan}>└─</span>
58-
<span className={styles.cPurple}>payload</span>
72+
<span className={styles.cPurple}>0.payload</span>
5973
<span className={styles.cFaint}>encrypted content</span>
6074
</div>
6175
<div className={styles.diagramRow}>

0 commit comments

Comments
 (0)