[AI-FSSDK] [FSSDK-12735] Fix holdout impression event tracking and decision reason

Author: esrakartalOpt

core-api/src/main/java/com/optimizely/ab/Optimizely.java

@@ -1357,7 +1357,7 @@ private OptimizelyDecision createOptimizelyDecision(
         }
 
         if (flagDecision.holdoutDecision != null && !allOptions.contains(OptimizelyDecideOption.DISABLE_DECISION_EVENT)) {
-            sendImpression(
+            decisionEventDispatched = sendImpression(
                 projectConfig,
                 flagDecision.holdoutDecision.experiment,
                 userId,
@@ -1366,7 +1366,7 @@ private OptimizelyDecision createOptimizelyDecision(
                 flagKey,
                 flagDecision.holdoutDecision.decisionSource != null ? flagDecision.holdoutDecision.decisionSource.toString() : FeatureDecision.DecisionSource.HOLDOUT.toString(),
                 flagDecision.holdoutDecision.variation != null && flagDecision.holdoutDecision.variation.getFeatureEnabled(),
-                null);
+                null) || decisionEventDispatched;
         }
 
         DecisionNotification decisionNotification = DecisionNotification.newFlagDecisionNotificationBuilder()

core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java

@@ -347,6 +347,10 @@ public  List<DecisionResponse<FeatureDecision>> getVariationsForFeatureList(@Non
                 continue flagLoop;
             }
 
+            if (globalHoldoutDecision != null && excludeTargetedDeliveries) {
+                reasons.addInfo("Holdout '%s' has excludeTargetedDeliveries enabled, continuing to rollout evaluation.", globalHoldoutDecision.experiment.getKey());
+            }
+
             if (globalHoldoutDecision == null) {
                 DecisionResponse<FeatureDecision> decisionVariationResponse = getVariationFromExperiment(projectConfig, featureFlag, user, options, userProfileTracker, decisionPath);
                 reasons.merge(decisionVariationResponse.getReasons());

core-api/src/test/java/com/optimizely/ab/bucketing/DecisionServiceTest.java

@@ -2168,6 +2168,28 @@ public void globalHoldout_excludeTD_holdoutDecisionAttached() {
         assertEquals(HOLDOUT_GLOBAL_EXCLUDE_TARGETED_DELIVERIES, decision.holdoutDecision.experiment);
     }
 
+    @Test
+    public void globalHoldout_excludeTD_addsDecisionReason() {
+        ProjectConfig config = ValidProjectConfigV4.generateValidProjectConfigV4_globalHoldoutExcludeTargetedDeliveries();
+
+        Bucketer bucketer = new Bucketer();
+        DecisionService ds = new DecisionService(bucketer, mockErrorHandler, null, mockCmabService);
+
+        DecisionResponse<FeatureDecision> response = ds.getVariationForFeature(
+            FEATURE_FLAG_SINGLE_VARIABLE_INTEGER,
+            optimizely.createUserContext("any_user", Collections.<String, Object>emptyMap()),
+            config
+        );
+
+        List<String> reasons = response.getReasons().toReport();
+        String expectedReason = String.format(
+            "Holdout '%s' has excludeTargetedDeliveries enabled, continuing to rollout evaluation.",
+            HOLDOUT_GLOBAL_EXCLUDE_TARGETED_DELIVERIES.getKey()
+        );
+        assertTrue("Reasons should contain excludeTargetedDeliveries bypass message",
+            reasons.contains(expectedReason));
+    }
+
     private Experiment createMockCmabExperiment() {
         List<Variation> variations = Arrays.asList(
             new Variation("111151", "variation_1"),