Skip to content

Commit 887328c

Browse files
fain182claude
andcommitted
refactor: drop final from the test classes too
Same habit as in src, same absence of a reason: nobody extends a test case. The classes the tests analyse keep theirs — there final is a property of the specimen, not a design choice, and one may well need to be final some day. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 0381a21 commit 887328c

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

tests/Integration/AndThatFilterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use org\bovigo\vfs\vfsStream;
1515
use PHPUnit\Framework\TestCase;
1616

17-
final class AndThatFilterTest extends TestCase
17+
class AndThatFilterTest extends TestCase
1818
{
1919
public function test_only_classes_matching_both_namespace_and_naming_are_checked(): void
2020
{

tests/Integration/CheckClassHaveAttributeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use org\bovigo\vfs\vfsStream;
1313
use PHPUnit\Framework\TestCase;
1414

15-
final class CheckClassHaveAttributeTest extends TestCase
15+
class CheckClassHaveAttributeTest extends TestCase
1616
{
1717
public function test_models_should_reside_in_app_model(): void
1818
{

tests/Integration/CheckClassHaveTraitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use org\bovigo\vfs\vfsStream;
1313
use PHPUnit\Framework\TestCase;
1414

15-
final class CheckClassHaveTraitTest extends TestCase
15+
class CheckClassHaveTraitTest extends TestCase
1616
{
1717
public function test_feature_tests_should_use_database_transactions_trait(): void
1818
{

tests/Integration/CheckClassNotHaveAttributeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use org\bovigo\vfs\vfsStream;
1313
use PHPUnit\Framework\TestCase;
1414

15-
final class CheckClassNotHaveAttributeTest extends TestCase
15+
class CheckClassNotHaveAttributeTest extends TestCase
1616
{
1717
public function test_controllers_should_not_have_deprecated_attribute(): void
1818
{

tests/Unit/Expressions/ForClasses/IsATest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Arkitect\Tests\Unit\Expressions\ForClasses\IsATest\Fruit\FruitInterface;
1515
use PHPUnit\Framework\TestCase;
1616

17-
final class IsATest extends TestCase
17+
class IsATest extends TestCase
1818
{
1919
public function test_it_should_have_no_violation_when_it_implements(): void
2020
{

tests/Unit/Expressions/ForClasses/IsNotATest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Arkitect\Tests\Unit\Expressions\ForClasses\IsNotA\Fruit\FruitInterface;
1515
use PHPUnit\Framework\TestCase;
1616

17-
final class IsNotATest extends TestCase
17+
class IsNotATest extends TestCase
1818
{
1919
public function test_it_should_have_no_violation_when_it_doesnt_extend(): void
2020
{

0 commit comments

Comments
 (0)