VisibilityCheck: walk the dep tree instead of its CNF form

process_depset() enumerated edepset.iter_cnf_solutions() and then walked
the resulting clause list once per profile. pkgcore's OrRestriction
converts to CNF by distributing, so an any-of block of N all-of branches
of M atoms each yields M^N clauses. That shape is exactly what
python_gen_any_dep emits, one branch per implementation, so
dev-python/click with distutils_enable_sphinx (6 impls, 7 atoms per
branch) produced 117,649 clauses, and every further implementation
multiplied the runtime by 7:

    impls    clauses    enumeration
        6    117,649         0.023s
        7    823,543         0.294s
        8  5,764,801         3.040s
        9 40,353,607        22.294s

Hence the CI timeout on the reverted commit adding python3_15, and the
distutils_enable_sphinx calls commented out in click and cython.

Evaluate the node tree directly instead: an atom is solvable per the
existing per-profile caches, an all-of block needs every child, an any-of
block needs one. This is equivalent to requiring every CNF clause to
hold, blockers included -- a clause containing a blocker was dropped,
which matches treating a blocker as solvable -- but linear in the size of
the depset rather than exponential. The only divergence is that the CNF
form also collected atoms reached solely through redundant superset
clauses, so the reported solutions list is now tighter; that case doesn't
occur anywhere in ::gentoo.

While here, honor the insoluble cache. "if node in insoluble: pass" was a
no-op, so a known-unsolvable atom was re-queried on every clause it
appeared in.

Scanning the two packages from the report with their sphinx deps restored,
-j10: click 21.2s real / 56.0s CPU -> 5.9s / 5.1s, cython 5.9s / 14.8s ->
2.9s / 3.7s.

Resolves: #782
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

Author: arthurzam

NEWS.rst

@@ -31,6 +31,13 @@ pkgcheck 0.10.42 (unreleased)
 - RepoProfilesCheck: don't flag a directory-form ``package.use`` and similar as
   an unused profile directory (Arthur Zamarin, #560)
 
+- VisibilityCheck: walk the dep tree instead of enumerating its CNF form, which
+  was exponential in the number of all-of blocks nested inside an any-of block.
+  Scanning a package using ``python_gen_any_dep`` with a handful of
+  implementations, e.g. ``dev-python/click`` with ``distutils_enable_sphinx``,
+  drops from 21s to 4s, and each further implementation no longer multiplies the
+  runtime by the size of the any-of block (Arthur Zamarin, #782)
+
 -----------------------------
 pkgcheck 0.10.41 (2026-07-24)
 -----------------------------

src/pkgcheck/checks/visibility.py

@@ -486,51 +486,60 @@ def check_optfeature(self, pkg):
             if not self.query_cache[search]:
                 yield OptfeatureNonexistentAtom(str(search), line=line, lineno=lineno + 1, pkg=pkg)
 
-    def process_depset(self, pkg, attr, depset, edepset, profiles):
-        get_cached_query = self.query_cache.get
+    def _solvable(self, profile, node):
+        # is it visible?  ie, is it masked?
+        # if so, skip it.
+        # long term, probably should do testing in the same respect we do
+        # for other visibility tiers
+        if node in profile.cache or profile.provides_has_match(node):
+            return True
+        if node in profile.insoluble:
+            return False
 
-        csolutions = []
-        for required in edepset.iter_cnf_solutions():
-            for node in required:
-                if node.blocks:
-                    break
-            else:
-                csolutions.append(required)
+        # get is required since there is an intermix between old style
+        # virtuals and new style- thus the cache priming doesn't get
+        # all of it.
+        src = self.query_cache.get(node.no_usedeps, ())
+        if node.use:
+            src = (FakeConfigurable(pkg, profile) for pkg in src)
+            src = (pkg for pkg in src if node.force_True(pkg))
+        if any(map(profile.visible, src)):
+            profile.cache.add(node)
+            return True
+        profile.insoluble.add(node)
+        return False
+
+    def _solve_depset(self, profile, node, failures):
+        if isinstance(node, atom):
+            # blockers are handled by other checks
+            if node.blocks or self._solvable(profile, node):
+                return True
+            failures.add(node)
+            return False
+
+        if isinstance(node, boolean.OrRestriction):
+            if not node.restrictions:
+                return True
+            # an any-of block is solvable if any of its children is, so the
+            # failures of its children only matter if all of them fail
+            nested = set()
+            for child in node.restrictions:
+                if self._solve_depset(profile, child, nested):
+                    return True
+            failures.update(nested)
+            return False
+
+        # everything else is an all-of block, the depset itself included
+        solvable = True
+        for child in node.restrictions:
+            # every child is walked, so that all failures get collected
+            if not self._solve_depset(profile, child, failures):
+                solvable = False
+        return solvable
 
+    def process_depset(self, pkg, attr, depset, edepset, profiles):
         for profile in profiles:
             failures = set()
-            # is it visible?  ie, is it masked?
-            # if so, skip it.
-            # long term, probably should do testing in the same respect we do
-            # for other visibility tiers
-            cache = profile.cache
-            provided = profile.provides_has_match
-            insoluble = profile.insoluble
-            visible = profile.visible
-            for required in csolutions:
-                # scan all of the quickies, the caches...
-                for node in required:
-                    if node in cache or provided(node):
-                        break
-                else:
-                    for node in required:
-                        if node in insoluble:
-                            pass
-
-                        # get is required since there is an intermix between old style
-                        # virtuals and new style- thus the cache priming doesn't get
-                        # all of it.
-                        src = get_cached_query(node.no_usedeps, ())
-                        if node.use:
-                            src = (FakeConfigurable(pkg, profile) for pkg in src)
-                            src = (pkg for pkg in src if node.force_True(pkg))
-                        if any(visible(pkg) for pkg in src):
-                            cache.add(node)
-                            break
-                        else:
-                            insoluble.add(node)
-                    else:
-                        # no matches. not great, should collect them all
-                        failures.update(required)
+            self._solve_depset(profile, edepset, failures)
             if failures:
                 yield profile, failures

testdata/data/repos/visibility/VisibilityCheck/NonsolvableDepsInStable/expected-verbose.json

@@ -1,3 +1,4 @@
 {"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "masked", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/masked"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": null}
 {"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "masked", "version": "0", "attr": "depend", "keyword": "~amd64", "profile": "visibility/amd64/stable", "deps": ["stub/masked"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": null}
 {"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "unstable", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/unstable"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": null}
+{"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "any-of", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/masked", "stub/unstable"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": null}

testdata/data/repos/visibility/VisibilityCheck/NonsolvableDepsInStable/expected.json

@@ -1,2 +1,3 @@
 {"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "masked", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/masked"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": 2}
 {"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "unstable", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/unstable"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": 1}
+{"__class__": "NonsolvableDepsInStable", "category": "NonsolvableDepsInStable", "package": "any-of", "version": "0", "attr": "depend", "keyword": "amd64", "profile": "visibility/amd64/stable", "deps": ["stub/masked", "stub/unstable"], "profile_status": "stable", "profile_deprecated": false, "num_profiles": 1}

testdata/data/repos/visibility/VisibilityCheck/NonsolvableDepsInStable/fix.patch

@@ -16,3 +16,13 @@ diff -Naur visibility/NonsolvableDepsInStable/unstable/unstable-0.ebuild fixed/N
  KEYWORDS="amd64"
 -DEPEND="stub/unstable"
 +DEPEND="stub/stable"
+diff -Naur visibility/NonsolvableDepsInStable/any-of/any-of-0.ebuild fixed/NonsolvableDepsInStable/any-of/any-of-0.ebuild
+--- visibility/NonsolvableDepsInStable/any-of/any-of-0.ebuild	2026-07-31 22:22:33.351689541 +0300
++++ fixed/NonsolvableDepsInStable/any-of/any-of-0.ebuild	2026-07-31 22:22:33.355676005 +0300
+@@ -7,5 +7,5 @@
+ DEPEND="
+ 	|| (
+ 		( stub/stable stub/unstable )
+-		( stub/stable stub/masked )
++		( stub/stable stub/deprecated )
+ 	)"

testdata/repos/visibility/NonsolvableDepsInStable/any-of-solvable/any-of-solvable-0.ebuild

@@ -0,0 +1,11 @@
+EAPI=7
+DESCRIPTION="Ebuild with an any-of dep where one all-of branch is solvable"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+LICENSE="BSD"
+SLOT="0"
+KEYWORDS="amd64"
+DEPEND="
+	|| (
+		( stub/stable stub/masked )
+		( stub/stable stub/deprecated )
+	)"

testdata/repos/visibility/NonsolvableDepsInStable/any-of/any-of-0.ebuild

@@ -0,0 +1,11 @@
+EAPI=7
+DESCRIPTION="Ebuild with an any-of dep where every all-of branch is nonsolvable"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+LICENSE="BSD"
+SLOT="0"
+KEYWORDS="amd64"
+DEPEND="
+	|| (
+		( stub/stable stub/unstable )
+		( stub/stable stub/masked )
+	)"

testdata/repos/visibility/profiles/visibility/amd64/dev/package.mask

@@ -1,3 +1,4 @@
 NonsolvableDepsInExp/masked
+NonsolvableDepsInStable/any-of
 NonsolvableDepsInStable/masked
 NonsolvableDepsInStable/unstable

testdata/repos/visibility/profiles/visibility/amd64/exp/package.mask

@@ -1,3 +1,4 @@
 NonsolvableDepsInDev/masked
+NonsolvableDepsInStable/any-of
 NonsolvableDepsInStable/masked
 NonsolvableDepsInStable/unstable