fix: declare the statuses() error key as present and nullable (#24)

refactor: drop the redundant Status assertion in Manager::statuses()
ci: run psalm on pushes to 2.x

statuses() has always returned 'error' => null for a process without an error, while the docblock declared an optional key. ClassMustBeFinal is suppressed instead of making Exception\ServiceException final, which would break users extending it.

Assisted-By: Claude Opus 5.5

Author: roxblnfk

.gitattributes

@@ -7,3 +7,4 @@
 testo.php export-ignore
 monorepo-builder.php export-ignore
 infection.json5 export-ignore
+psalm.xml export-ignore

.github/workflows/psalm.yml

@@ -1,11 +1,14 @@
 on:
   push:
     branches:
-      - '*.*'
+      - 2.x
   pull_request: null
 
 name: static analysis
 
+permissions:
+  contents: read
+
 jobs:
   psalm:
     uses: spiral/gh-actions/.github/workflows/psalm.yml@master

psalm.xml

@@ -9,6 +9,8 @@
     findUnusedCode="false"
 >
     <issueHandlers>
+        <!-- Making public classes final would break BC for users who extend them -->
+        <ClassMustBeFinal errorLevel="suppress" />
     </issueHandlers>
     <projectFiles>
         <directory name="src" />

src/Manager.php

@@ -9,7 +9,6 @@
 use RoadRunner\Service\DTO\V1\PBList;
 use RoadRunner\Service\DTO\V1\Response;
 use RoadRunner\Service\DTO\V1\Service;
-use RoadRunner\Service\DTO\V1\Status;
 use RoadRunner\Service\DTO\V1\Statuses;
 use Spiral\Goridge\RPC\Codec\ProtobufCodec;
 use Spiral\Goridge\RPC\Exception\ServiceException;
@@ -154,7 +153,7 @@ public function terminate(string $name): bool
      *     cpu_percent: float,
      *     memory_usage: positive-int,
      *     pid: positive-int,
-     *     error?: array{
+     *     error: null|array{
      *        code: int,
      *        message: non-empty-string,
      *        details: array{message: string, type_url: string}[]
@@ -172,11 +171,8 @@ public function statuses(string $name): array
             \assert($response instanceof Statuses);
 
             foreach ($response->getStatus() as $status) {
-                \assert($status instanceof Status);
-
                 $error = null;
                 $statusError = $status->getStatus();
-                /** @psalm-suppress RedundantConditionGivenDocblockType */
                 if ($statusError !== null) {
                     $error = [
                         'code' => $statusError->getCode(),