SK-3061: catch generic Exception in all 4 sync bulk methods

bulkInsert/bulkDetokenize/bulkDeleteTokens/bulkTokenize (sync) only
caught ApiClientApiException/InterruptedException/ExecutionException,
unlike their *Async twins which also catch a generic Exception. This
mattered concretely for bulkInsert: its private helper
(processBulkInsertSync) calls insertBatchFutures - which synchronously
invokes the caller's RequestInterceptor - before entering its own try
block, so a throwing interceptor escaped bulkInsert() as a raw,
undeclared exception instead of the documented SkyflowException.

The other three sync helpers already shield their own interceptor call
inside their own try/catch(Exception), so they were not exploitable the
same way, but their public methods had the identical outer-catch gap -
this is the uniform fix flagged as pending when #412's narrower
bulkInsert-only version was reverted (65179ed).

Added one regression test per sync method asserting a throwing
interceptor surfaces as SkyflowException. Confirmed via TDD: the new
bulkInsert test failed before this change (raw IllegalStateException)
and passes after; the other three already passed before and continue
to pass after.

mvn -pl common,flowvault -am test -> 712 (flowvault) + 106
(common/ValidationsTests) tests, 0 failures, BUILD SUCCESS.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: Devesh-Skyflow

flowvault/src/main/java/com/skyflow/vault/controller/VaultController.java

@@ -121,6 +121,9 @@ public BulkInsertResponse bulkInsert(BulkInsertRequest insertRequest, BulkInsert
             LogUtil.printErrorLog(ErrorLogs.INSERT_RECORDS_REJECTED.getLog());
             Throwable cause = e.getCause();
             throw new SkyflowException(cause != null && cause.getMessage() != null ? cause.getMessage() : e.getMessage());
+        } catch (Exception e) {
+            LogUtil.printErrorLog(ErrorLogs.INSERT_RECORDS_REJECTED.getLog());
+            throw new SkyflowException(e.getMessage());
         }
     }
 
@@ -192,6 +195,9 @@ public BulkDetokenizeResponse bulkDetokenize(BulkDetokenizeRequest detokenizeReq
             throw new SkyflowException(e.getMessage());
         } catch (ExecutionException e) {
             throw new SkyflowException(e.getMessage());
+        } catch (Exception e) {
+            LogUtil.printErrorLog(ErrorLogs.DETOKENIZE_REQUEST_REJECTED.getLog());
+            throw new SkyflowException(e.getMessage());
         }
     }
 
@@ -270,6 +276,9 @@ public BulkDeleteTokensResponse bulkDeleteTokens(BulkDeleteTokensRequest deleteT
         } catch (ExecutionException | InterruptedException e) {
             LogUtil.printErrorLog(ErrorLogs.DELETE_REQUEST_REJECTED.getLog());
             throw new SkyflowException(e.getMessage());
+        } catch (Exception e) {
+            LogUtil.printErrorLog(ErrorLogs.DELETE_REQUEST_REJECTED.getLog());
+            throw new SkyflowException(e.getMessage());
         }
     }
 
@@ -352,6 +361,9 @@ public BulkTokenizeResponse bulkTokenize(BulkTokenizeRequest tokenizeRequest, Bu
         } catch (ExecutionException | InterruptedException e) {
             LogUtil.printErrorLog(ErrorLogs.TOKENIZE_REQUEST_REJECTED.getLog());
             throw new SkyflowException(e.getMessage());
+        } catch (Exception e) {
+            LogUtil.printErrorLog(ErrorLogs.TOKENIZE_REQUEST_REJECTED.getLog());
+            throw new SkyflowException(e.getMessage());
         }
     }
 

flowvault/src/test/java/com/skyflow/vault/controller/VaultControllerTests.java

@@ -1164,4 +1164,102 @@ public void testBulkTokenize_interceptorInvokedOncePerBatchWithDistinctContext()
         Mockito.verify(mockRaw, Mockito.times(EXPECTED_BATCH_COUNT)).tokenize(any(), captor.capture());
         assertInterceptorRanOncePerBatch(interceptor, captor.getAllValues());
     }
+
+    @Test
+    public void testBulkInsert_throwingInterceptorWrappedAsSkyflowException() throws Exception {
+        ApiClient mockApi = Mockito.mock(ApiClient.class);
+        RawFlowserviceClient mockRaw = mockRawFlowservice(mockApi);
+        stubInsertEcho(mockRaw);
+        VaultController controller = createControllerWithMock(mockApi);
+
+        Map<String, Object> data = new HashMap<>();
+        data.put("name", "john");
+        ArrayList<InsertRequestRecord> records = new ArrayList<>();
+        records.add(BulkInsertRequestRecord.builder().tableName("table1").data(data).build());
+        BulkInsertRequest request = BulkInsertRequest.builder().records(records).build();
+
+        RequestInterceptor interceptor = ctx -> {
+            throw new IllegalStateException("sync insert interceptor blew up");
+        };
+        BulkInsertOptions options = BulkInsertOptions.builder().interceptor(interceptor).build();
+
+        try {
+            controller.bulkInsert(request, options);
+            Assert.fail(EXCEPTION_NOT_THROWN);
+        } catch (SkyflowException e) {
+            Assert.assertEquals("sync insert interceptor blew up", e.getMessage());
+        }
+    }
+
+    @Test
+    public void testBulkDetokenize_throwingInterceptorWrappedAsSkyflowException() throws Exception {
+        ApiClient mockApi = Mockito.mock(ApiClient.class);
+        RawFlowserviceClient mockRaw = mockRawFlowservice(mockApi);
+        stubDetokenizeEcho(mockRaw);
+        VaultController controller = createControllerWithMock(mockApi);
+
+        BulkDetokenizeRequest request = BulkDetokenizeRequest.builder()
+                .tokens(Collections.singletonList("token-0"))
+                .build();
+
+        RequestInterceptor interceptor = ctx -> {
+            throw new IllegalStateException("sync detokenize interceptor blew up");
+        };
+        BulkDetokenizeOptions options = BulkDetokenizeOptions.builder().interceptor(interceptor).build();
+
+        try {
+            controller.bulkDetokenize(request, options);
+            Assert.fail(EXCEPTION_NOT_THROWN);
+        } catch (SkyflowException e) {
+            Assert.assertEquals("sync detokenize interceptor blew up", e.getMessage());
+        }
+    }
+
+    @Test
+    public void testBulkDeleteTokens_throwingInterceptorWrappedAsSkyflowException() throws Exception {
+        ApiClient mockApi = Mockito.mock(ApiClient.class);
+        RawFlowserviceClient mockRaw = mockRawFlowservice(mockApi);
+        stubDeleteTokensEcho(mockRaw);
+        VaultController controller = createControllerWithMock(mockApi);
+
+        BulkDeleteTokensRequest request = BulkDeleteTokensRequest.builder()
+                .tokens(Collections.singletonList("token-0"))
+                .build();
+
+        RequestInterceptor interceptor = ctx -> {
+            throw new IllegalStateException("sync delete-tokens interceptor blew up");
+        };
+        BulkDeleteTokensOptions options = BulkDeleteTokensOptions.builder().interceptor(interceptor).build();
+
+        try {
+            controller.bulkDeleteTokens(request, options);
+            Assert.fail(EXCEPTION_NOT_THROWN);
+        } catch (SkyflowException e) {
+            Assert.assertEquals("sync delete-tokens interceptor blew up", e.getMessage());
+        }
+    }
+
+    @Test
+    public void testBulkTokenize_throwingInterceptorWrappedAsSkyflowException() throws Exception {
+        ApiClient mockApi = Mockito.mock(ApiClient.class);
+        RawFlowserviceClient mockRaw = mockRawFlowservice(mockApi);
+        stubTokenizeEcho(mockRaw);
+        VaultController controller = createControllerWithMock(mockApi);
+
+        ArrayList<BulkTokenizeRequestRecord> records = new ArrayList<>();
+        records.add(BulkTokenizeRequestRecord.builder().value("value-0").build());
+        BulkTokenizeRequest request = BulkTokenizeRequest.builder().records(records).build();
+
+        RequestInterceptor interceptor = ctx -> {
+            throw new IllegalStateException("sync tokenize interceptor blew up");
+        };
+        BulkTokenizeOptions options = BulkTokenizeOptions.builder().interceptor(interceptor).build();
+
+        try {
+            controller.bulkTokenize(request, options);
+            Assert.fail(EXCEPTION_NOT_THROWN);
+        } catch (SkyflowException e) {
+            Assert.assertEquals("sync tokenize interceptor blew up", e.getMessage());
+        }
+    }
 }