Exception, using reqif dump

[MarcoNovaro]

I'm using reqif version 0.0.48
Using a specific ReqIF file, exported with Visure, I have the following exception, trying to use reqif dump MyFile.reqif

Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "C:\Python3\Scripts\reqif.exe\__main__.py", line 7, in <module> File "C:\Python3\Lib\site-packages\reqif\cli\main.py", line 38, in main DumpCommand.execute(parser.get_dump_config()) File "C:\Python3\Lib\site-packages\reqif\commands\dump\dump.py", line 18, in execute reqif_bundle = ReqIFParser.parse(config.input_file) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python3\Lib\site-packages\reqif\parser.py", line 72, in parse return ReqIFParser.parse_from_string(content) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python3\Lib\site-packages\reqif\parser.py", line 91, in parse_from_string reqif_bundle = ReqIFParser._parse_reqif(xml_reqif_root) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python3\Lib\site-packages\reqif\parser.py", line 204, in _parse_reqif ) = ReqIFParser._parse_reqif_content(xml_req_if_content) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python3\Lib\site-packages\reqif\parser.py", line 315, in _parse_reqif_content spec_object = SpecObjectParser.parse(xml_spec_object) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python3\Lib\site-packages\reqif\parsers\spec_object_parser.py", line 36, in parse AttributeValueParser.parse_attribute_values(xml_spec_values) File "C:\Python3\Lib\site-packages\reqif\parsers\attribute_value_parser.py", line 118, in parse_attribute_values assert attribute_xml_values is not None AssertionError

[stanislaw]

Hey @MarcoNovaro, there is something in your ReqIF that is not like expected by the attribute_value_parser.py (Attribute Value Parser).

Is there a chance, you could send an anonymized and minimized ReqIF file that reproduces this issue? I could understand this better and work on a fix then.

Thank you.

[MarcoNovaro]

Hi @stanislaw: anonymized reqIF sent via email. Thank you.

[stanislaw]

Hey @MarcoNovaro, this is an interesting edge case, and I am not sure yet which behavior we would want to implement.

Issue 1

The assert is not very descriptive but it is hinting at a real issue in your anonymized file: At least one of your attribute value (it is the second on the screenshot) enumeration tags is missing its <VALUES> tag. Compare it with the first attribute value that does have its <VALUES> tag correctly.

You can reproduce this by running it with reqif validate command as follows:

reqif validate TSC_anonymized.reqif --use-reqif-schema

I think I could replace the assert with printing the warning and ignore the attribute value without THE-VALUES. This would make the library read your file but I believe you still need to fix the underlying issue that is produced by the tool that you are using.

I could implement the assert -> print warning over the weekend but it would be great if you shared which tool produces such a ReqIF schema.

Issue 2

There is at least one more issue with your file, and that is that some of your XHTML attribute values are not correctly namespaced into the tags.

For example, this value <THE-VALUE>...Anonymized-6193634913...</THE-VALUE> should actually be formed as

<THE-VALUE><xhtml:div>...Anonymized-6193634913...<xhtml:div></THE-VALUE>

Otherwise the ReqIF schema validator will not be happy.

[MarcoNovaro]

Hello, thanks for the detailed analysis.

Issue 1

I can't tell the exact problem, because I'm not that expert in ReqIF syntax, but I noticed that:

• I have the exact same rows on the original (non-anonimized) ReqIF
• This ReqIF file was created with Visure (from our customer)
• reqif validate is actually finding the same issue (as you described), but running the same command on the original (non-anonymized) ReqIF is actually causing a different trap:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Python3\Scripts\reqif.exe\__main__.py", line 7, in <module>
  File "C:\Python3\Lib\site-packages\reqif\cli\main.py", line 42, in main
    ValidateCommand.execute(parser.get_validate_config())
  File "C:\Python3\Lib\site-packages\reqif\commands\validate\validate.py", line 54, in execute
    error_bundle = ValidateCommand._validate(config)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\commands\validate\validate.py", line 120, in _validate
    reqif_bundle = ReqIFParser.parse(input_file)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\parser.py", line 72, in parse
    return ReqIFParser.parse_from_string(content)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\parser.py", line 91, in parse_from_string
    reqif_bundle = ReqIFParser._parse_reqif(xml_reqif_root)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\parser.py", line 204, in _parse_reqif
    ) = ReqIFParser._parse_reqif_content(xml_req_if_content)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\parser.py", line 315, in _parse_reqif_content
    spec_object = SpecObjectParser.parse(xml_spec_object)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python3\Lib\site-packages\reqif\parsers\spec_object_parser.py", line 36, in parse
    AttributeValueParser.parse_attribute_values(xml_spec_values)
  File "C:\Python3\Lib\site-packages\reqif\parsers\attribute_value_parser.py", line 118, in parse_attribute_values
    assert attribute_xml_values is not None

Issue 2

In this case, it seems like something was removed / changed by the anonymization process.
In fact, this is the portion of the same file (original version):

<ATTRIBUTE-VALUE-XHTML>
  <DEFINITION>
    <ATTRIBUTE-DEFINITION-XHTML-REF>vr-att-def-description-obj</ATTRIBUTE-DEFINITION-XHTML-REF>
  </DEFINITION>
  <THE-VALUE><xhtml:div><xhtml:div style="min-height: 9pt; "><xhtml:span style="font-family:Verdana; font-size:8.0pt; "><xhtml:b>Front Matter</xhtml:b></xhtml:span></xhtml:div></xhtml:div></THE-VALUE>            </ATTRIBUTE-VALUE-XHTML>
<ATTRIBUTE-VALUE-STRING THE-VALUE="1">

and in here the <xhtml:div> tag is actually there.
In fact, I also have some issues in importing back the anonymized version of the ReqIF file, but I guess it's best to open a different issue for this topic.

Thank you.