Address dynamic workflow review feedback

Author: datashaman

src/Workflow/WorkflowMethod.php

@@ -38,10 +38,7 @@ final class WorkflowMethod
     /**
      * Marks this as a dynamic (catch-all) workflow: it is invoked when the
      * worker receives a workflow whose type name is not statically registered.
-     * At most one dynamic workflow may be registered per worker. The handler
-     * reads the actual type name via {@see \Temporal\Workflow::getInfo()} and
-     * receives the raw arguments (declare a {@see \Temporal\DataConverter\ValuesInterface}
-     * parameter to access them).
+     * At most one dynamic workflow may be registered per worker.
      */
     #[Immutable]
     public bool $dynamic = false;

tests/Unit/Declaration/Fixture/WorkflowWithAnotherDynamic.php

@@ -14,11 +14,9 @@
 use Temporal\Workflow\WorkflowInterface;
 use Temporal\Workflow\WorkflowMethod;
 
-/** @WorkflowInterface */
 #[WorkflowInterface]
 class WorkflowWithAnotherDynamic
 {
-    /** @WorkflowMethod(dynamic=true) */
     #[WorkflowMethod(dynamic: true)]
     public function handler(): void
     {

tests/Unit/Declaration/Fixture/WorkflowWithDynamic.php

@@ -14,11 +14,9 @@
 use Temporal\Workflow\WorkflowInterface;
 use Temporal\Workflow\WorkflowMethod;
 
-/** @WorkflowInterface */
 #[WorkflowInterface]
 class WorkflowWithDynamic
 {
-    /** @WorkflowMethod(dynamic=true) */
     #[WorkflowMethod(dynamic: true)]
     public function handler(): void
     {

tests/Unit/Declaration/WorkflowDeclarationTestCase.php

@@ -54,26 +54,21 @@ public function testWorkflowWithoutHandler(WorkflowReader $reader): void
         $this->assertNull($prototype->getHandler());
     }
 
-    /**
-     * @param WorkflowReader $reader
-     * @throws \ReflectionException
-     */
+    /** @throws \ReflectionException */
     #[TestDox("Reading a dynamic (catch-all) workflow sets the dynamic flag")]
-    #[DataProvider('workflowReaderDataProvider')]
-    public function testDynamicWorkflow(WorkflowReader $reader): void
+    public function testDynamicWorkflow(): void
     {
+        $reader = new WorkflowReader(new AttributeReader());
+
         $this->assertTrue($reader->fromClass(WorkflowWithDynamic::class)->isDynamic());
         $this->assertFalse($reader->fromClass(SimpleWorkflow::class)->isDynamic());
     }
 
-    /**
-     * @param WorkflowReader $reader
-     * @throws \ReflectionException
-     */
+    /** @throws \ReflectionException */
     #[TestDox("At most one dynamic workflow may be registered per worker")]
-    #[DataProvider('workflowReaderDataProvider')]
-    public function testMultipleDynamicWorkflowsAreRejected(WorkflowReader $reader): void
+    public function testMultipleDynamicWorkflowsAreRejected(): void
     {
+        $reader = new WorkflowReader(new AttributeReader());
         $collection = new WorkflowCollection();
         $collection->add($reader->fromClass(WorkflowWithDynamic::class));