Skip to content

Commit 93486ed

Browse files
kv2019ikv2019i
committed
boards: intel_adsp: enable coredump for all Intel targets
CONFIG_DEBUG_COREDUMP was only enabled on a subset of Intel build targets (ace15_mtpm/mtl and the cavs25 boards), and otherwise only came in through the debug overlay (-d / app/debug_overlay.conf). This left normal builds of lnl, ptl, wcl, nvl and nvls without a core dump, so field crashes on those platforms could not be analysed offline. Enable it once for every Intel ADSP target in the shared boards/intel_adsp/Kconfig.defconfig. DEBUG_COREDUMP has no in-tree default, so configdefault turns it on without weakening its "depends on ARCH_SUPPORTS_COREDUMP" dependency (SOC_FAMILY_INTEL_ADSP selects ARCH_SUPPORTS_COREDUMP). The backend and memory-dump amount are Kconfig 'choice' symbols with an in-tree default. Because this SOF defconfig is sourced after the Zephyr tree (unlike upstream board Kconfig.defconfig files, which are sourced first), choice defaults cannot be overridden from it. The ADSP memory-window backend and minimal dump are therefore selected in each Intel board .conf instead; the boards that already enabled coredump keep those two lines and just drop the now-redundant CONFIG_DEBUG_COREDUMP=y. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent a3a1ee3 commit 93486ed

9 files changed

Lines changed: 52 additions & 3 deletions

‎app/boards/intel_adsp/Kconfig.defconfig‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,24 @@ config LOG_TIMESTAMP_64BIT
174174
config ZTEST
175175
default SOF_BOOT_TEST_SUPPORTED && SOF_BOOT_TEST_ALLOWED
176176

177+
# Zephyr / core dump
178+
# ----------------------------------------
179+
# Enable core dump on all Intel ADSP targets, not just the debug (-d) build,
180+
# so that firmware crashes can always be analysed offline.
181+
#
182+
# DEBUG_COREDUMP has no in-tree default, so configdefault is used to force it
183+
# on without weakening its "depends on ARCH_SUPPORTS_COREDUMP" dependency
184+
# (SOC_FAMILY_INTEL_ADSP selects ARCH_SUPPORTS_COREDUMP).
185+
#
186+
# The coredump backend and memory-dump amount are Kconfig 'choice' symbols
187+
# with an in-tree default. As noted above, this defconfig is sourced after the
188+
# Zephyr tree, so choice defaults cannot be overridden from here; the ADSP
189+
# memory-window backend and minimal dump are therefore selected in each Intel
190+
# board .conf file instead.
191+
192+
configdefault DEBUG_COREDUMP
193+
default y
194+
177195
# Zephyr / debug slot manager
178196
# ----------------------------------------
179197

‎app/boards/intel_adsp_ace15_mtpm.conf‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ CONFIG_LIBRARY_BUILD_LIB=y
4949
CONFIG_SOF_LOG_LEVEL_INF=y
5050

5151
# Zephyr / OS features
52-
CONFIG_DEBUG_COREDUMP=y
52+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
53+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
54+
# choices have to be selected per board.
5355
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
5456
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
5557
CONFIG_HEAP_MEM_POOL_SIZE=8192

‎app/boards/intel_adsp_ace20_lnl.conf‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ CONFIG_LIBRARY_MANAGER=y
3434
CONFIG_SOF_LOG_LEVEL_INF=y
3535

3636
# Zephyr / OS features
37+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
38+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
39+
# choices have to be selected per board.
40+
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
41+
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
3742
CONFIG_COUNTER=y
3843
CONFIG_HEAP_MEM_POOL_SIZE=8192
3944
CONFIG_LLEXT=y

‎app/boards/intel_adsp_ace30_ptl.conf‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ CONFIG_LIBRARY_DEFAULT_MODULAR=y
3737
CONFIG_SOF_LOG_LEVEL_INF=y
3838

3939
# Zephyr / OS features
40+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
41+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
42+
# choices have to be selected per board.
43+
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
44+
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
4045
CONFIG_COUNTER=y
4146
CONFIG_HEAP_MEM_POOL_SIZE=8192
4247
CONFIG_LLEXT=y

‎app/boards/intel_adsp_ace30_wcl.conf‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ CONFIG_LIBRARY_DEFAULT_MODULAR=y
3737
CONFIG_SOF_LOG_LEVEL_INF=y
3838

3939
# Zephyr / OS features
40+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
41+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
42+
# choices have to be selected per board.
43+
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
44+
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
4045
CONFIG_HEAP_MEM_POOL_SIZE=8192
4146
CONFIG_LLEXT=y
4247
CONFIG_LLEXT_STORAGE_WRITABLE=y

‎app/boards/intel_adsp_ace40_nvl.conf‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ CONFIG_TRACE=n
3535
CONFIG_SOF_LOG_LEVEL_INF=y
3636

3737
# Zephyr / OS features
38+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
39+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
40+
# choices have to be selected per board.
41+
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
42+
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
3843
CONFIG_HEAP_MEM_POOL_SIZE=8192
3944
CONFIG_LLEXT=y
4045
CONFIG_LLEXT_STORAGE_WRITABLE=y

‎app/boards/intel_adsp_ace40_nvls.conf‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ CONFIG_TRACE=n
3535
CONFIG_SOF_LOG_LEVEL_INF=y
3636

3737
# Zephyr / OS features
38+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
39+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
40+
# choices have to be selected per board.
41+
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
42+
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
3843
CONFIG_HEAP_MEM_POOL_SIZE=8192
3944
CONFIG_LLEXT=y
4045
CONFIG_LLEXT_STORAGE_WRITABLE=y

‎app/boards/intel_adsp_cavs25.conf‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ CONFIG_LIBRARY_MANAGER=n
3030
CONFIG_SOF_LOG_LEVEL_INF=y
3131

3232
# Zephyr / OS features
33-
CONFIG_DEBUG_COREDUMP=y
33+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
34+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
35+
# choices have to be selected per board.
3436
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
3537
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
3638
CONFIG_HEAP_MEM_POOL_SIZE=8192

‎app/boards/intel_adsp_cavs25_tgph.conf‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ CONFIG_LIBRARY_MANAGER=n
2929
CONFIG_SOF_LOG_LEVEL_INF=y
3030

3131
# Zephyr / OS features
32-
CONFIG_DEBUG_COREDUMP=y
32+
# note: CONFIG_DEBUG_COREDUMP is enabled for all Intel targets in
33+
# boards/intel_adsp/Kconfig.defconfig; only the backend and dump-amount
34+
# choices have to be selected per board.
3335
CONFIG_DEBUG_COREDUMP_BACKEND_INTEL_ADSP_MEM_WINDOW=y
3436
CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
3537
CONFIG_HEAP_MEM_POOL_SIZE=8192

0 commit comments

Comments
 (0)