Repository navigation
Deploy updated metadata after successful sync - #166
Merged
Merged
Conversation
|
Deploy preview for cms ready!
Deployed with vercel-action |
Collaborator
Author
|
/review |
matheus1lva
force-pushed
the
codex/deploy-synced-metadata
branch
from
September 30, 2026 13:45
773960f to
1e4d366
Compare
matheus1lva
marked this pull request as ready for review
September 30, 2026 13:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync commits use
GITHUB_TOKEN, so their pushes do not trigger the deployment workflow added in #164. Explicitly request a deployment after a successful metadata push on the default branch, keeping the production site’s commit-pinned metadata current.How to review
Review the final step in
.github/workflows/sync.yml: it dispatches only when metadata changed and the sync ran on the default branch..github/workflows/vercel-deploy.ymladds the matching manual trigger.Draft — do not merge yet: The pinned
yearn/yearn-ghaworkflow rejectsworkflow_dispatchfor production. A companion change must allow that event only on the default branch, and this PR must then pin the approved shared-workflow commit. Verify/update the CMS Doppler OIDC policy as well: the shared-workflow documentation specifies anevent_name: pushrestriction and a pinnedjob_workflow_ref.Test plan
git diff --check.Risk / impact
Adds
actions: writeto the sync job so it can explicitly dispatch the deployment workflow. Dispatch happens after the push succeeds and only on the default branch. No secrets or metadata formats change. A dispatch request confirms acceptance, not deployment completion. Reverting this change restores the previous sync-only behavior.