Merge pull request #27 from zelentsov-dev/bugs/review-submissions-item-limit

fix(review-submissions): send limit[items] only when items are included

Author: zelentsov-dev

CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [4.1.6] - 2026-08-22
+
+### Fixed
+
+- Send `limit[items]` on review submission reads only when `items` is part of `include`. Apple ignores the nested item limit for other includes and omits it from `links.next`, so `review_submissions_list` with an explicit `include` that excluded `items` rejected Apple's own next page with `does not preserve required query parameter 'limit[items]'` whenever the collection exceeded the page limit. `item_limit` is now applied only together with `items`, and continuation links are validated against the parameters that were actually sent.
+
+### Compatibility
+
+- The public catalog remains at 502 tools with no renamed inputs or removed response fields. `item_limit` passed with an `include` that lacks `items` is no longer forwarded to Apple; continuation calls repeat the same arguments as before.
+
 ## [4.1.5] - 2026-08-22
 
 ### Fixed

README.md

@@ -58,7 +58,7 @@ The recommended setup stores App Store Connect credentials once in a private loc
 
 ```bash
 brew install mint
-mint install zelentsov-dev/asc-mcp@v4.1.5
+mint install zelentsov-dev/asc-mcp@v4.1.6
 ~/.mint/bin/asc-mcp --version
 ```
 
@@ -149,13 +149,13 @@ If the connection or request fails, see [Troubleshooting](#troubleshooting).
 
 ```bash
 brew install mint
-mint install zelentsov-dev/asc-mcp@v4.1.5
+mint install zelentsov-dev/asc-mcp@v4.1.6
 ```
 
 Update or reinstall the pinned release:
 
 ```bash
-mint install zelentsov-dev/asc-mcp@v4.1.5 --force
+mint install zelentsov-dev/asc-mcp@v4.1.6 --force
 ```
 
 Stable users should install a version tag. Installing `main` or `develop` is intended only for maintainers and pre-release testing.

Sources/asc-mcp/Core/ServerVersion.swift

@@ -1,5 +1,5 @@
 import Foundation
 
 enum ServerVersion {
-    static let current = "4.1.5"
+    static let current = "4.1.6"
 }

Sources/asc-mcp/Workers/ReviewSubmissionsWorker/ReviewSubmissionsWorker+Handlers.swift

@@ -819,15 +819,18 @@ extension ReviewSubmissionsWorker {
     }
 
     private func submissionQuery(includes: [String], itemLimit: Int) -> [String: String] {
-        [
+        var query = [
             "fields[reviewSubmissions]": Self.submissionFields,
             "fields[apps]": Self.appFields,
             "fields[reviewSubmissionItems]": Self.itemIdentityFields,
             "fields[appStoreVersions]": Self.appStoreVersionFields,
             "fields[actors]": Self.actorFields,
-            "include": includes.joined(separator: ","),
-            "limit[items]": String(itemLimit)
+            "include": includes.joined(separator: ",")
         ]
+        if includes.contains("items") {
+            query["limit[items]"] = String(itemLimit)
+        }
+        return query
     }
 
     private func itemListQuery() -> [String: String] {

Sources/asc-mcp/Workers/ReviewSubmissionsWorker/ReviewSubmissionsWorker+ToolDefinitions.swift

@@ -24,7 +24,7 @@ extension ReviewSubmissionsWorker {
                         values: Self.submissionIncludes
                     ),
                     "item_limit": integerSchema(
-                        description: "Maximum included review items (default: 50, max: 50)",
+                        description: "Maximum included review items; applies only when include contains items (default: 50, max: 50)",
                         maximum: 50,
                         defaultValue: 50
                     ),
@@ -59,7 +59,7 @@ extension ReviewSubmissionsWorker {
                         values: Self.submissionIncludes
                     ),
                     "item_limit": integerSchema(
-                        description: "Maximum included review items (default: 50, max: 50)",
+                        description: "Maximum included review items; applies only when include contains items (default: 50, max: 50)",
                         maximum: 50,
                         defaultValue: 50
                     )

Tests/ASCMCPTests/Workers/ReviewSubmissionsWorkerContractTests.swift

@@ -1304,6 +1304,64 @@ struct ReviewSubmissionsWorkerContractTests {
         #expect(forwarded == reorderedQuery)
     }
 
+    @Test("item_limit is sent only with items and Apple's next link without it is accepted")
+    func itemLimitFollowsItemsInclude() async throws {
+        var query = reviewSubmissionListQuery(appID: "app-1", includes: "app,submittedByActor", itemLimit: nil)
+        query["cursor"] = "page-2"
+        let next = reviewSubmissionURL(path: "/v1/reviewSubmissions", query: query)
+        let arguments: [String: Value] = [
+            "app_id": .string("app-1"),
+            "include": .string("app,submittedByActor"),
+            "item_limit": .int(3)
+        ]
+
+        let firstPageTransport = TestHTTPTransport(responses: [
+            .init(statusCode: 200, body: reviewSubmissionsListBody(nextURL: next, limit: 25))
+        ])
+        let firstPageWorker = try await makeReviewSubmissionsWorker(transport: firstPageTransport)
+        let firstPage = try await firstPageWorker.handleTool(.init(name: "review_submissions_list", arguments: arguments))
+        #expect(firstPage.isError != true)
+        let sentQuery = try reviewSubmissionQuery(try #require(await firstPageTransport.recordedRequests().first))
+        #expect(sentQuery["include"] == "app,submittedByActor")
+        #expect(sentQuery["limit[items]"] == nil)
+        #expect(try reviewSubmissionObject(firstPage.structuredContent)["next_url"] == .string(next))
+
+        let continuationTransport = TestHTTPTransport(responses: [
+            .init(statusCode: 200, body: #"{"data":[],"links":{"self":"https://api.example.test/v1/reviewSubmissions"}}"#)
+        ])
+        let continuationWorker = try await makeReviewSubmissionsWorker(transport: continuationTransport)
+        var continuationArguments = arguments
+        continuationArguments["next_url"] = .string(next)
+        let continuation = try await continuationWorker.handleTool(.init(
+            name: "review_submissions_list",
+            arguments: continuationArguments
+        ))
+        #expect(continuation.isError != true)
+        #expect(try reviewSubmissionQuery(try #require(await continuationTransport.recordedRequests().first)) == query)
+
+        var missingItemLimit = reviewSubmissionListQuery(appID: "app-1", includes: "app,items", itemLimit: nil)
+        missingItemLimit["cursor"] = "page-2"
+        try await expectRejectedReviewSubmissionContinuation(
+            tool: "review_submissions_list",
+            arguments: ["app_id": .string("app-1"), "include": .string("app,items"), "item_limit": .int(3)],
+            path: "/v1/reviewSubmissions",
+            query: missingItemLimit
+        )
+
+        let getTransport = TestHTTPTransport(responses: [
+            .init(statusCode: 200, body: reviewSubmissionBody(id: "sub-1"))
+        ])
+        let getWorker = try await makeReviewSubmissionsWorker(transport: getTransport)
+        let get = try await getWorker.handleTool(.init(
+            name: "review_submissions_get",
+            arguments: ["submission_id": .string("sub-1"), "include": .string("app"), "item_limit": .int(7)]
+        ))
+        #expect(get.isError != true)
+        let getQuery = try reviewSubmissionQuery(try #require(await getTransport.recordedRequests().first))
+        #expect(getQuery["include"] == "app")
+        #expect(getQuery["limit[items]"] == nil)
+    }
+
     @Test("continuation links still reject token drift inside set-valued query values")
     func multiValueContinuationStillRejectsTokenDrift() async throws {
         let baseQuery = reviewSubmissionListQuery(appID: "app-1")
@@ -2226,7 +2284,7 @@ private func reviewSubmissionListQuery(
     states: String? = nil,
     platforms: String? = nil,
     includes: String = "app,items,appStoreVersionForReview,submittedByActor,lastUpdatedByActor",
-    itemLimit: Int = 50,
+    itemLimit: Int? = 50,
     limit: Int = 25
 ) -> [String: String] {
     var query: [String: String] = [
@@ -2236,10 +2294,10 @@ private func reviewSubmissionListQuery(
         "fields[appStoreVersions]": reviewSubmissionAppVersionFields,
         "fields[actors]": reviewSubmissionActorFields,
         "include": includes,
-        "limit[items]": String(itemLimit),
         "filter[app]": appID,
         "limit": String(limit)
     ]
+    query["limit[items]"] = itemLimit.map(String.init)
     query["filter[state]"] = states
     query["filter[platform]"] = platforms
     return query